| Message ID | 20230607140525.833982-3-hugo@hugovil.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp234615vqr;
Wed, 7 Jun 2023 07:19:18 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ69kW1kWv0QgtwW6nSb547YFc3aAubPg6BuuSCTxRD8azWt4Pk561lwAwYu5hh6F8Ktb9Gw
X-Received: by 2002:a17:902:d487:b0:1ac:8cd6:9323 with SMTP id
c7-20020a170902d48700b001ac8cd69323mr2391893plg.22.1686147557813;
Wed, 07 Jun 2023 07:19:17 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686147557; cv=none;
d=google.com; s=arc-20160816;
b=zBF++n5YSXvq6wf751zakmIQyQgzEj7n3CMeo8dMeNIAcYz6anDyY0mc40eVIs2XiD
7XZSu9VPE0MPGTQLddi6sm71AMvCowE7lGMTHWD7Vo5rOSqrYg0AES6P1CAhUQ3ec3Es
jnPhmEy6HmDbpaH2/v4SDxlIasnmqL4G2uDLmdTkdWcT6fxolFHJ6SB/q1IgBBzoasgV
HPjjWnU7BfSTYk4dIUtbvo/NxneTN4k+if2o01U+sV2ygjai5NN60i5YlBDBbGFgXQYi
bKp+vdXvWf92onCgklu4Kd6PehNhP+oBpW+U51QrKe2lvO29W5jOxqJx5hxF2uTiLBgF
+c2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:subject:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:cc:to:from:dkim-signature;
bh=T/ybH+luXFJtRUNLsANdxNj5MlosRcBXIwuB3tKL/mQ=;
b=NAdfweP8vZRH3KYhtoZv+pmks+dkXEpROyyrUhiYxXdODA8yfxatZ/5Cc+M3BLCZU7
s24Gk7XEecgA6+Kf5VMlbxUgqsdAe55RN1JbvBGBfEDV0X4lhihUNyCmPxLaV/jeZi8q
Q9Zk9jVduRZPV5HurdQGjGWkL7Sa1aaY49XyMaT1hWuLHi+PFEa7AgnkjMzdwBfOhdh8
3fHwUoh4w5Npp81LIpBYAVgjgOcmGG2c+Wia5mhreF/A40OPLH7FYyglR9lrSJC6CJSn
UFEiPeQczMF6g1WCMR6wCmntWPn/08dnvv0QC1mZRIeS7F16im7/1Jw3wZEPWQzIMwb8
XUxA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@hugovil.com header.s=x header.b=YyRwUwfD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
f12-20020a170902ab8c00b001ac83d19265si8665314plr.291.2023.06.07.07.19.03;
Wed, 07 Jun 2023 07:19:17 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@hugovil.com header.s=x header.b=YyRwUwfD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S240896AbjFGOFz (ORCPT <rfc822;xxoosimple@gmail.com> + 99 others);
Wed, 7 Jun 2023 10:05:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40944 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S240240AbjFGOFt (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 7 Jun 2023 10:05:49 -0400
Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 021C51BF7;
Wed, 7 Jun 2023 07:05:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com
; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=T/ybH+luXFJtRUNLsANdxNj5MlosRcBXIwuB3tKL/mQ=;
b=YyRwUwfDS9hvhAfcBTaZtOmciQ
1q4n0JWY9J3VW9et83md5m3Z43i+nxh5Jn7HHIsBQ87dXVAGt7+o4SBxgIOk6t++l8duSPtTcmmW3
rDDR7cp12DA4bEXqKGZUqRF1w4sw1wk49Ca15En2D/VapQ+sikf8PUW1XBhbfMXcIEKQ=;
Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:57832
helo=pettiford.lan)
by mail.hugovil.com with esmtpa (Exim 4.92)
(envelope-from <hugo@hugovil.com>)
id 1q6tn3-0005dF-WB; Wed, 07 Jun 2023 10:05:35 -0400
From: Hugo Villeneuve <hugo@hugovil.com>
To: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
jesse.sung@canonical.com, isaac.true@canonical.com,
l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, hugo@hugovil.com,
linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org, Lech Perczak <lech.perczak@camlingroup.com>
Date: Wed, 7 Jun 2023 10:05:16 -0400
Message-Id: <20230607140525.833982-3-hugo@hugovil.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230607140525.833982-1-hugo@hugovil.com>
References: <20230607140525.833982-1-hugo@hugovil.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 70.80.174.168
X-SA-Exim-Mail-From: hugo@hugovil.com
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
X-Spam-Level:
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
Subject: [PATCH v8 02/10] serial: sc16is7xx: mark IOCONTROL register as
volatile
X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000)
X-SA-Exim-Scanned: Yes (on mail.hugovil.com)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768053861351665219?=
X-GMAIL-MSGID: =?utf-8?q?1768053861351665219?=
|
| Series |
serial: sc16is7xx: fix GPIO regression and rs485 improvements
|
|
Commit Message
Hugo Villeneuve
June 7, 2023, 2:05 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Bit SRESET (3) is cleared when a reset operation is completed. Having the IOCONTROL register as non-volatile will always read SRESET as 1, which is incorrect. Also, if IOCONTROL register is not a volatile register, the upcoming patch "serial: sc16is7xx: fix regression with GPIO configuration" doesn't work when setting some shared GPIO lines as modem control lines. Therefore mark IOCONTROL register as a volatile register. Cc: <stable@vger.kernel.org> # 6.1.x Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com> Tested-by: Lech Perczak <lech.perczak@camlingroup.com> --- drivers/tty/serial/sc16is7xx.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index faa51a58671f..0c903d44429c 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -488,6 +488,7 @@ static bool sc16is7xx_regmap_volatile(struct device *dev, unsigned int reg) case SC16IS7XX_TXLVL_REG: case SC16IS7XX_RXLVL_REG: case SC16IS7XX_IOSTATE_REG: + case SC16IS7XX_IOCONTROL_REG: return true; default: break;