From patchwork Wed Jun 7 14:05:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 104538 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp242467vqr; Wed, 7 Jun 2023 07:30:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5vLIjRkv+522q/Dgz0jfnny5RuX+sa4qvC79YgZvdGrvTLeEfJr5IgnwtnAa3pzh+Xxf82 X-Received: by 2002:a17:90b:1953:b0:253:37ef:ce63 with SMTP id nk19-20020a17090b195300b0025337efce63mr15610225pjb.18.1686148236357; Wed, 07 Jun 2023 07:30:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686148236; cv=none; d=google.com; s=arc-20160816; b=l1oVwcYfCEvUIm8cvW9yiI/S1uuyq7Xpnbzudz2CTl8H6fLAknN1b0m65jG5cxiaVu wXTZgehfbTU85NoAq8+iOBA83qTvYxC7ExoAZpowB29paZ0Fn2htGqddiYaMZ4a534tU 7Peq99HvC0ztZ5GWoI8ADnBddF2aWp6eG3iD6Ujq/N/zt5GtzIkwvlF7+PU51XchkyQQ 05ln8OhKnOe+7a1alqjw99VBWv2yXRFECM6cBsfePh5ZiGLq8FSWhAwbkPS7ZG1H2VHg cbvM65aLlrzNMnCAlSt3U1MYkOF59eLyB3SElxbQsTF6kf41IuBw5MzZNdhdwqKhLidi TjRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=1wgVQQIBSKwC6a09QZuw7yLN+cODKGZA1pW4FrlWgRo=; b=j3t0S5YFrg6tWq+wBGvcvGh8ZoYAf5j+vNnvyk0tQAKFu9JvE/9zUiSAb1YsqWHH6k DZY6Hc9WdWcU65/YPVQI+IllbyFoxc2ZW5C11kHy/oY9ny7SO/t14ypJey0/Kyb1TEKD SC7b8twI/6YqeEMIkkvA9AWNuiPhasLvu4xS9cx8q3tNCab7hdxeHjp1fK3IK2M5l4tx PpWXXbOtxqU4Yk2vyvQKociuO70Ea1yhYLDZD/l+67N0Ef44r0fXPutS/OkUfjj9wK1G 7nSmahls57vGK1fSNgQlf+iyQemjn6rln+S+x1AFj2Odal5/CsryLr31KhZ3lNJ0huYy 7bsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=S9eRLsXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s10-20020a17090aad8a00b0024e3527e8e9si1201219pjq.9.2023.06.07.07.30.23; Wed, 07 Jun 2023 07:30:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=S9eRLsXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240959AbjFGOGN (ORCPT + 99 others); Wed, 7 Jun 2023 10:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240881AbjFGOFx (ORCPT ); Wed, 7 Jun 2023 10:05:53 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 883851BD9; Wed, 7 Jun 2023 07:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1wgVQQIBSKwC6a09QZuw7yLN+cODKGZA1pW4FrlWgRo=; b=S9eRLsXgf/qZPcVSSQEcJdZJgV /U18B4hk+p3HMG4bUdVw+9JfPMt24pIFGTohUNZQIe8Tvgob3/RvTkIwEe37tgi5Z2UDJMuTOqpk+ LaKuRON7/OS5m1Q9FrpTKxkjx1sqajNswfbjkkohr/4a50hQsT9W/MUngUPm9wTASSrY=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:57832 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1q6tnF-0005dF-Ji; Wed, 07 Jun 2023 10:05:46 -0400 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, jesse.sung@canonical.com, isaac.true@canonical.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, linux-gpio@vger.kernel.org, Hugo Villeneuve , Lech Perczak Date: Wed, 7 Jun 2023 10:05:23 -0400 Message-Id: <20230607140525.833982-10-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230607140525.833982-1-hugo@hugovil.com> References: <20230607140525.833982-1-hugo@hugovil.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v8 09/10] serial: sc16is7xx: add post reset delay X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768054573215410703?= X-GMAIL-MSGID: =?utf-8?q?1768054573215410703?= From: Hugo Villeneuve Make sure we wait at least 3us before initiating communication with the device after reset. Signed-off-by: Hugo Villeneuve Reviewed-by: Lech Perczak Tested-by: Lech Perczak --- drivers/tty/serial/sc16is7xx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 7246f8997fda..7616703f7438 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1526,6 +1526,12 @@ static int sc16is7xx_probe(struct device *dev, regmap_write(s->regmap, SC16IS7XX_IOCONTROL_REG << SC16IS7XX_REG_SHIFT, SC16IS7XX_IOCONTROL_SRESET_BIT); + /* + * After reset, the host must wait at least 3us before initializing a + * communication with the device. + */ + usleep_range(5, 10); + for (i = 0; i < devtype->nr_uart; ++i) { s->p[i].line = i; /* Initialize port data */