diff mbox series

[v1,4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties

Message ID 20230607115508.2964574-4-l.goehrs@pengutronix.de
State New
Headers
Series [v1,1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible |

Commit Message

Leonard Göhrs June 7, 2023, 11:55 a.m. UTC 
  The termination-gpios property allows specifying a GPIO pin that
enables/disables a termination resistor on said CAN interface.
The termination-ohms property specifies the resistance of said resistor.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
---
 Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Conor Dooley June 7, 2023, 5:51 p.m. UTC | #1 
On Wed, Jun 07, 2023 at 01:55:03PM +0200, Leonard Göhrs wrote:
> The termination-gpios property allows specifying a GPIO pin that
> enables/disables a termination resistor on said CAN interface.
> The termination-ohms property specifies the resistance of said resistor.
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Rob Herring June 7, 2023, 11:03 p.m. UTC | #2 
On Wed, Jun 07, 2023 at 01:55:03PM +0200, Leonard Göhrs wrote:
> The termination-gpios property allows specifying a GPIO pin that
> enables/disables a termination resistor on said CAN interface.
> The termination-ohms property specifies the resistance of said resistor.
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index 67879aab623b5..106c79fa560c3 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -118,6 +118,9 @@ properties:
>    phys:
>      maxItems: 1
>  
> +  termination-gpios: true
> +  termination-ohms: true

All you should need here is change additionalProperties to 
unevaluatedProperties as these are defined by can-controller.yaml.

> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
index 67879aab623b5..106c79fa560c3 100644
--- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
+++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
@@ -118,6 +118,9 @@  properties:
   phys:
     maxItems: 1
 
+  termination-gpios: true
+  termination-ohms: true
+
 required:
   - compatible
   - reg