From patchwork Wed Jun 7 09:35:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 104376 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp132481vqr; Wed, 7 Jun 2023 02:48:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ61nUhDnivUU6WJ9UvjYVdCNWe7X43//21fogapGFE9KhVLXLMECTN6r2kNZBC007gz/Y88 X-Received: by 2002:a17:902:a405:b0:1b0:bf80:d1bb with SMTP id p5-20020a170902a40500b001b0bf80d1bbmr4506409plq.7.1686131293850; Wed, 07 Jun 2023 02:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686131293; cv=none; d=google.com; s=arc-20160816; b=PZHJ75eN3JeItFNk93TYTQe/CaJrdajZnaA2WHi2qiUgTrjqlMUfcU6rgLFm+4npWw I9u4XHAQEWKrOYX6GnhuDB0i0XcfJDMxgDAcQyRZoA4sexZgiPAzdQVyr+6mYN81Hg4r WqPf1KJ7Oaxqq1bKcOsTA0svIWf9S8mNX/0fiHEq3xYoGoxBNGuAsN94jHXVmz1f0Is2 IJ1KMOi9MNTUY5lDl41kryVBRnjRDrDti1W8gSPF+VSzKPmtr7JjvBqbvjBDemEiCwt1 zn52Ettjn488tPTrOJYxZzajY3jmHFwACMPoQhjOEMkOvcf86W6vQHd2hMgZoq8Rsz7P VnOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NOY3NRn/KvNWRXGwlZBfvP6iKd9z8q9pNCH358Yyu8s=; b=n28HDCYE0LQhEPPtAX2LmeqzY0bVPdLzI9HQsq3JdC1xQB33+ocIsicTnx2LCjYX+i GP34Re76RIy2smeshb/BJtxxOB0+pOfxPB3AMV295tnyq0aacpUgj0EbTqjjR2lMO7pP BAoj5AgVZxWL00oiklPj4IRc18ewU8fWO8xjPRK+3MtGBIxw39dRojIgkdt1L3g6rvYe KvgXh+NYldI6BadFDgJTHUv168VH2y0Z7F3of10DvjPruiyk1zo1LiINj2mffNJnrI+Y tlpObWo8WWF1P6n2cndlMlMUuxEszDpGYEqkYe9MjgvH7KQrKrdDQboNZfiBA3+N2HrU Y7vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a170903110e00b001b02ccb155bsi8616780plh.327.2023.06.07.02.48.00; Wed, 07 Jun 2023 02:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235210AbjFGJfq (ORCPT + 99 others); Wed, 7 Jun 2023 05:35:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240429AbjFGJf3 (ORCPT ); Wed, 7 Jun 2023 05:35:29 -0400 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 269E31720; Wed, 7 Jun 2023 02:35:18 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R581e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0Vka6Hhf_1686130515; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0Vka6Hhf_1686130515) by smtp.aliyun-inc.com; Wed, 07 Jun 2023 17:35:16 +0800 From: Yang Li To: mani@kernel.org Cc: lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org, bhelgaas@google.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] PCI: endpoint: Remove redundant dev_err(). Date: Wed, 7 Jun 2023 17:35:14 +0800 Message-Id: <20230607093514.104012-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768036807528146122?= X-GMAIL-MSGID: =?utf-8?q?1768036807528146122?= There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. Eliminate the following warning: ./drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq_byname() already prints an error Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5449 Signed-off-by: Yang Li --- drivers/pci/endpoint/functions/pci-epf-mhi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c index 1227f059ea12..371d6f80845e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c @@ -359,7 +359,6 @@ static int pci_epf_mhi_bind(struct pci_epf *epf) ret = platform_get_irq_byname(pdev, "doorbell"); if (ret < 0) { - dev_err(dev, "Failed to get Doorbell IRQ\n"); iounmap(epf_mhi->mmio); return ret; }