diff mbox series

[V2,1/4] arm64: dts: ti: k3-am65-main: Fix mux controller node name

Message ID 20230606160643.3618390-2-nm@ti.com
State New
Headers
Series arm64: dts: ti: k3-am65: dtbs_check warnings fixups |

Commit Message

Nishanth Menon June 6, 2023, 4:06 p.m. UTC 
  Add unit address to form a proper node name.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
No change since V1
V1: https://lore.kernel.org/r/20230424144949.244135-3-nm@ti.com

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Davis June 6, 2023, 4:29 p.m. UTC | #1 
On 6/6/23 11:06 AM, Nishanth Menon wrote:
> Add unit address to form a proper node name.
> 

This is only needed when the node has a reg property, which
we have not added yet to this node. This patch instead adds a
warning:

> node has a unit name, but no reg or ranges property

Andrew

> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> No change since V1
> V1: https://lore.kernel.org/r/20230424144949.244135-3-nm@ti.com
> 
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 1adba2f2c153..f64b4e782ec3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -506,7 +506,7 @@ serdes1_clk: clock@4090 {
>   			reg = <0x00004090 0x4>;
>   		};
>   
> -		serdes_mux: mux-controller {
> +		serdes_mux: mux-controller@4080 {
>   			compatible = "mmio-mux";
>   			#mux-control-cells = <1>;
>   			mux-reg-masks = <0x4080 0x3>, /* SERDES0 lane select */
Nishanth Menon June 6, 2023, 5:07 p.m. UTC | #2 
On 11:29-20230606, Andrew Davis wrote:
> On 6/6/23 11:06 AM, Nishanth Menon wrote:
> > Add unit address to form a proper node name.
> > 
> 
> This is only needed when the node has a reg property, which
> we have not added yet to this node. This patch instead adds a
> warning:
> 
> > node has a unit name, but no reg or ranges property

/me bangs head.. I missed it. Thanks for catching it. Will drop
this patch from the series. will wait till tomorrow in case of any
additional comments.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 1adba2f2c153..f64b4e782ec3 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -506,7 +506,7 @@  serdes1_clk: clock@4090 {
 			reg = <0x00004090 0x4>;
 		};
 
-		serdes_mux: mux-controller {
+		serdes_mux: mux-controller@4080 {
 			compatible = "mmio-mux";
 			#mux-control-cells = <1>;
 			mux-reg-masks = <0x4080 0x3>, /* SERDES0 lane select */