From patchwork Tue Jun 6 14:37:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 103904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3457157vqr; Tue, 6 Jun 2023 08:01:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5vs432Iq4/iFeUeYBnV4eikpXbJu/9XjlFVvHGLFkYZ9JR95MTWFaLmUvBEGL+P7I9VzRr X-Received: by 2002:a05:620a:8b03:b0:75b:23a0:e7d8 with SMTP id qw3-20020a05620a8b0300b0075b23a0e7d8mr2019355qkn.57.1686063671932; Tue, 06 Jun 2023 08:01:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686063671; cv=none; d=google.com; s=arc-20160816; b=gH8vB+zuiQ5xQzVjv/ElEdXZmJJN/xUP7gS/u+57dyN3ZLxENlgDkBqTVrWg+NqRyt Af79+jvvtHEoBJTRJHdr5t69JuzU79f4bLHHUlQLrPr3SeGQtscL8vrZd9UJhmF2Jv91 NDW2T2vDs+JQ2JvUD6+/4SSG9hPBdGBntidtdgTa7H9fHnbi3hHtBrDZ4qdiP3Q6ve1Y lyGdO+SQsz1Ndxzyb7n2x0W34X6kpcLqXPWhyQnbS5x36xkivJb+VdWkEk7o4ToHvCHm 3JE9Y3WBE1vyrp6K1B2QuyJD9WFsH8CpU4+kSMGmjMM+yggU6iVvnT3JdnsiyxUVkR7w XHbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=Oszm2ZXBXWLXUTPr0v8LyoBnFHycifs2Z0aI1dsyju0=; b=SD74GNt4YMKrhR97mox8LPEY/0zPPQJ0JDHbGwN7Y9wXvfKvcn3X1scMtTBYvy2lJB bVbpR9LF0eBZpwPKZlYnm4bdS0x6BGc/iPJkCIbqfpbEQ4VwsKUK4JhFapl5OIh0ii1Z P+aPl6p0rBMNODi/WDWyxTDakdim5hstIYkcS+MAbwwVA5ZvS6nNgWTXpHTkbCCnrKJn bEzgKWYwiF4VvYGXY+XkcFxplh5tIj8Xpx98ttS/tPrW1wXONaamb5YhpWbL7S+eW3Cc Mm3WXBOwpFB4a0TEC4WCUx+LGwZLc0JbE8EFIEJqsiG+gygXnFfAvRkaJY7Bm5rEc60m qwBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=D0ntuw5C; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o14-20020a05620a130e00b0075ce3d37b63si5850683qkj.554.2023.06.06.08.00.56; Tue, 06 Jun 2023 08:01:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=D0ntuw5C; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238256AbjFFOjE (ORCPT + 99 others); Tue, 6 Jun 2023 10:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238195AbjFFOiT (ORCPT ); Tue, 6 Jun 2023 10:38:19 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61A2919BA for ; Tue, 6 Jun 2023 07:37:52 -0700 (PDT) Message-ID: <20230606142032.151323086@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1686062270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Oszm2ZXBXWLXUTPr0v8LyoBnFHycifs2Z0aI1dsyju0=; b=D0ntuw5CvYsxl7SSpv78NSEO1OXove23skoVb9/culdydz2S3W/9AodOxMk18vwf/Sda8X PLJ+JN27N/9vZ/ZbfB4sfPzgijMO/Czl53luFkcn4sIF4hJJcmNPGHjzTsXxzCTuQXM/8N dVHffqboWgZ/JDXz5LZmHKgSfX30JvUl6sWrLznm6Gq8WUW9vvZvUIF7Ubzq7vYct7mHgY +oow8XxaFw958QPoqnCvgEGlpcHVj22vj1yHcS7Yg4+2vkOHWiq3s4w8X+RGdZSVeFy45v 5lYPgme3D0nI8L6FjetOVpodb/vsthI08TeP63e4ezMc159nfQ853OizEUzDEw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1686062270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Oszm2ZXBXWLXUTPr0v8LyoBnFHycifs2Z0aI1dsyju0=; b=5htpoKmcrRXlS0Nl4wNjcwhNX8aRSMwzaKf44yg10U6SoWgH0XxX8TaMn1da7IsgGlX4ih 8rmcZVlqOixyvoDQ== From: Thomas Gleixner To: LKML Cc: Frederic Weisbecker , Anna-Maria Behnsen , John Stultz , Peter Zijlstra , Ingo Molnar , Stephen Boyd , Eric Biederman , Oleg Nesterov Subject: [patch 20/45] signal: Replace BUG_ON()s References: <20230606132949.068951363@linutronix.de> MIME-Version: 1.0 Date: Tue, 6 Jun 2023 16:37:50 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767965901135180744?= X-GMAIL-MSGID: =?utf-8?q?1767965901135180744?= These really can be handled gracefully without killing the machine. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker --- kernel/signal.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1932,10 +1932,11 @@ struct sigqueue *sigqueue_alloc(void) void sigqueue_free(struct sigqueue *q) { - unsigned long flags; spinlock_t *lock = ¤t->sighand->siglock; + unsigned long flags; - BUG_ON(!(q->flags & SIGQUEUE_PREALLOC)); + if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC))) + return; /* * We must hold ->siglock while testing q->list * to serialize with collect_signal() or with @@ -1963,7 +1964,10 @@ int send_sigqueue(struct sigqueue *q, st unsigned long flags; int ret, result; - BUG_ON(!(q->flags & SIGQUEUE_PREALLOC)); + if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC))) + return 0; + if (WARN_ON_ONCE(q->info.si_code != SI_TIMER)) + return 0; ret = -1; rcu_read_lock(); @@ -1998,7 +2002,6 @@ int send_sigqueue(struct sigqueue *q, st * If an SI_TIMER entry is already queue just increment * the overrun count. */ - BUG_ON(q->info.si_code != SI_TIMER); q->info.si_overrun++; result = TRACE_SIGNAL_ALREADY_PENDING; goto out;