diff mbox series

[11/45] posix-cpu-timers: Remove incorrect comment in posix_cpu_timer_set()

Message ID 20230606142031.648340279@linutronix.de
State New
Headers
Series posix-timers: Cure inconsistencies and the SIG_IGN mess |

Commit Message

Thomas Gleixner June 6, 2023, 2:37 p.m. UTC 
  A leftover from historical code which describes fiction.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/time/posix-cpu-timers.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Frederic Weisbecker June 27, 2023, 10:30 a.m. UTC | #1 
On Tue, Jun 06, 2023 at 04:37:36PM +0200, Thomas Gleixner wrote:
> A leftover from historical code which describes fiction.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>


> ---
>  kernel/time/posix-cpu-timers.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -704,13 +704,8 @@ static int posix_cpu_timer_set(struct k_
>  		}
>  	}
>  
> +	/* Retry if the timer expiry is running concurrently */
>  	if (unlikely(ret)) {
> -		/*
> -		 * We are colliding with the timer actually firing.
> -		 * Punt after filling in the timer's old value, and
> -		 * disable this firing since we are already reporting
> -		 * it as an overrun (thanks to bump_cpu_timer above).
> -		 */
>  		unlock_task_sighand(p, &flags);
>  		goto out;
>  	}
>
diff mbox series

Patch

--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -704,13 +704,8 @@  static int posix_cpu_timer_set(struct k_
 		}
 	}
 
+	/* Retry if the timer expiry is running concurrently */
 	if (unlikely(ret)) {
-		/*
-		 * We are colliding with the timer actually firing.
-		 * Punt after filling in the timer's old value, and
-		 * disable this firing since we are already reporting
-		 * it as an overrun (thanks to bump_cpu_timer above).
-		 */
 		unlock_task_sighand(p, &flags);
 		goto out;
 	}