From patchwork Tue Jun 6 12:24:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 103788 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3363522vqr; Tue, 6 Jun 2023 05:41:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7NrpdISe4e28+lc9T3BLTHNIuNniUF6d3FMGDJ9W3monJ7VyItci/PlZ8GQm2m9CDSMDql X-Received: by 2002:a05:6358:9fa2:b0:125:506d:36db with SMTP id fy34-20020a0563589fa200b00125506d36dbmr2878722rwb.14.1686055309255; Tue, 06 Jun 2023 05:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686055309; cv=none; d=google.com; s=arc-20160816; b=J9+ov+Es/P8aM7RHd3oGf86gg6l6HBKKQLztCS4BMM4/SpriywOocX4rjy5/vvgauW Bbv6VUi6uVKSFrHNEhtIO6L0QUac53qIWpEL2uRkQ3wLd7rLz+aZQ9VsIbeJWkKEFu0i 5gJ7W/VnH0WmIFfo3oEaTe5vMHQsfF7O95ZvUrDFV36CXNPldvEfe/+zmJsW9HrjiFS0 3/N+uigieidfjqyPTkQalbwSU6N7F4+SRJcaV19OpdCrdJ3x0NXGKdJVid0puPwFI5VA LF2st8u/8SaNbKoNAWqphHjKDi36S1v5zscsQi3H9+FlJsdoOVkFZ29ncBpK7/8hUaJo PKEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=wb/zjNGR8vZ6lz2lsTJaQdU6G03xji6YZEjNm9p9xpM=; b=Xwsp/9OE8X9uwxDC4/VrrSr3dPk78Rrje/ZYCO8bBxAGMWSuKv8jeOOBEMTpmSfPaH gRk44FXFnRpWpWEm67lgmvCL61r4PZXEUykMazugxErqsWV116qJqaXXJB+iGew7Gm9H Gbo2WatM8+bv0JijF+NcUMixWXl22O9MPTEfJnLf/00HnRrXN9/oxlv6G/dzPD/aQNkL WraO+Zqydu0BJeG+4OZFWsAW5PToB8Mc+AN9mgxa3FjgxCpv8mrzW4z2tZkNdGow+1WN yMyf8b/GVZVbjzK+5pR4WKSqCd9GG+d01NLJJi6lHi/OMQUq/8ZxuMy6HWV4Q/xVQcEk iKHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XbRAzKIk; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q1-20020aa79601000000b006536902d31fsi7007951pfg.185.2023.06.06.05.41.36; Tue, 06 Jun 2023 05:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XbRAzKIk; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236640AbjFFMY1 (ORCPT + 99 others); Tue, 6 Jun 2023 08:24:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232356AbjFFMYZ (ORCPT ); Tue, 6 Jun 2023 08:24:25 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD7D010C7; Tue, 6 Jun 2023 05:24:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5A2321FD69; Tue, 6 Jun 2023 12:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686054263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wb/zjNGR8vZ6lz2lsTJaQdU6G03xji6YZEjNm9p9xpM=; b=XbRAzKIk+8BwZMJqCTkROBCnYCApL5tn3HVK3mLxE01nMJ13uoOtRVNt7R452KNNNUiXNz CP85SeKxXqHb1GIMAWU+Z+jF8oTf/FjHldEzmA42cnXvMU7brPyiAX8CgoWEwLy7uIHc8Z g8jX2KkCSzVJTw+ufERjCA4U8dZe84k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686054263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wb/zjNGR8vZ6lz2lsTJaQdU6G03xji6YZEjNm9p9xpM=; b=cqVAqDwKfn7FglB6pJlPli5dVhc49ugHt/54UYqQV+sO+PsyKWwb/p5I0iUShcsrNtIjaU iUVuONkOQcHmTWBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4CA9E13519; Tue, 6 Jun 2023 12:24:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Rw6PEnclf2SDOAAAMHmgww (envelope-from ); Tue, 06 Jun 2023 12:24:23 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki , Sagi Grimberg , Hannes Reinecke , Daniel Wagner Subject: [PATCH v4 1/1] nvmet-fcloop: Do not wait on completion when unregister fails Date: Tue, 6 Jun 2023 14:24:11 +0200 Message-Id: <20230606122411.7972-2-dwagner@suse.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230606122411.7972-1-dwagner@suse.de> References: <20230606122411.7972-1-dwagner@suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767957131702583794?= X-GMAIL-MSGID: =?utf-8?q?1767957131702583794?= The nvme_fc_unregister_localport() returns an error code in case that the locaport pointer is NULL or has already been unegisterd. localport is is either in the ONLINE state (all resources allocated) or has already been put into DELETED state. In this case we will never receive an wakeup call and thus any caller will hang, e.g. module unload. Signed-off-by: Daniel Wagner Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- drivers/nvme/target/fcloop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 1ab3d900f2bf..c65a73433c05 100644 --- a/drivers/nvme/target/fcloop.c +++ b/drivers/nvme/target/fcloop.c @@ -1166,7 +1166,8 @@ __wait_localport_unreg(struct fcloop_lport *lport) ret = nvme_fc_unregister_localport(lport->localport); - wait_for_completion(&lport->unreg_done); + if (!ret) + wait_for_completion(&lport->unreg_done); kfree(lport);