Message ID | 20230605191508.1826853-1-AVKrasnov@sberdevices.ru |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2906239vqr; Mon, 5 Jun 2023 12:25:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jfwzaElT7hi9T1jApq8zgrPNwS31d6yruGJM9qSb5GVaxNSSMj4IFq7molcN5mCFypD+5 X-Received: by 2002:a05:620a:2713:b0:75e:bb66:5155 with SMTP id b19-20020a05620a271300b0075ebb665155mr911672qkp.36.1685993154447; Mon, 05 Jun 2023 12:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685993154; cv=none; d=google.com; s=arc-20160816; b=MUcQcVB0rUn47lwCByJ7SSsuorsUfBS18zXnobdOWg6aKLYsh9B31O/YZVfFhSRWiH g8WTt6V2V2LzTU/uI8NzHoFNSXVBW0ClfC9C0aItl7yZ7SVW3Yw87cVBSLYGpmVOvnth stZqY53NG7kg9xKCqPe/sruoXh3sKVa0mbguad808kjh/KEhQtbLxpKLqaiOAy4Vn6NS bSG/oFaYc0WA9umDTbYg7zqbbKY3oWrUXfDoVtpK3dopq1o7HYXJ9tIoIp/UqQh/i5lr s72HM9OzokiyPy3aibnGJBeB/55DgUN560K+hcbSPW38+mfZLxOc/GKDFxtvqeDi+Her DA+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0bxcR34M60uuJQZ4Wt+CPZ8iyFTacwVg8Rt7W46V6l4=; b=NaLtSQaZfk6uEcP+gta6x1RwiCqIeKvG+SRzBclRzQkIjw6SViLG4KnWDxN90aiNFn Lg370L6iGiiRCmvlGgVWjr8qXyzl3lQAw00rg3lmGI7YmljORzep1Jt+O70La4InEZHE FSdYDOLZRHxpohovzNyU9w5/JysoUbqt+YSsJjlVLOQmRSlHCXalPNx0f1zxvuWsYyLX qpvV+1S2vHDV4BJz7TKzro1J7jY6k4L6Su87xZujnJp70F3LyclspmIStR5Vj3WOV76Y 2sPJGalrbuAA2lRp+Kiqcmcqx/PbrBAKAtQFe5oWWshmNfrGnchijkO+pLxgudwEG2II g73w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=E2WGj9qE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a05620a139100b0075b1a33db5asi4837216qki.589.2023.06.05.12.25.38; Mon, 05 Jun 2023 12:25:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=E2WGj9qE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232480AbjFETUr (ORCPT <rfc822;xxoosimple@gmail.com> + 99 others); Mon, 5 Jun 2023 15:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232223AbjFETUp (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 5 Jun 2023 15:20:45 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA7D718E for <linux-kernel@vger.kernel.org>; Mon, 5 Jun 2023 12:20:18 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 6BF175FD20; Mon, 5 Jun 2023 22:20:09 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1685992809; bh=0bxcR34M60uuJQZ4Wt+CPZ8iyFTacwVg8Rt7W46V6l4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=E2WGj9qE1hqoADU+k0pjgucB5yUQ+kCM1pQP1F1qqoaZ+6abq3lCH9BHNn78PDaAE 4EF5COfe5a/HiiNVBtwPhi9g2gmS38duYSv18cJeQDaCMJL6AyV8NpbbpY030SgV59 lgKWEo62+uqznorMrRZAbnmO/5+MPBHmRERPp2/V3E0qrJk17pkMGeCOp0JiWfMr4u /92nghLeRfBcUJmpBG7xIs77iTjfvGd2sLfPZkUo7jUN9z1lEw9rcOqFAA/38ukG4I SnYrwrX0HZwVuLXaT3+eohEk46Tz0oMOvHSsuDqOm026bgS8A6hj2490t4p/kqdrPc iL7eP8iTAULNQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Mon, 5 Jun 2023 22:20:09 +0300 (MSK) From: Arseniy Krasnov <AVKrasnov@sberdevices.ru> To: Liang Yang <liang.yang@amlogic.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com> CC: <oxffffaa@gmail.com>, <kernel@sberdevices.ru>, Arseniy Krasnov <AVKrasnov@sberdevices.ru>, <linux-mtd@lists.infradead.org>, <linux-arm-kernel@lists.infradead.org>, <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Date: Mon, 5 Jun 2023 22:15:08 +0300 Message-ID: <20230605191508.1826853-1-AVKrasnov@sberdevices.ru> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/06/05 13:50:00 #21435193 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767891957900311360?= X-GMAIL-MSGID: =?utf-8?q?1767891957900311360?= |
Series |
[v1] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes
|
|
Commit Message
Arseniy Krasnov
June 5, 2023, 7:15 p.m. UTC
Both operations have no effect.
Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
---
drivers/mtd/nand/raw/meson_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi again Miquel, Liang! What do You think about this patch? Thanks, Arseniy On 05.06.2023 22:15, Arseniy Krasnov wrote: > Both operations have no effect. > > Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> > --- > drivers/mtd/nand/raw/meson_nand.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index 074e14225c06..50d3110ad321 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand, > cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN; > nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0; > > - addrs[0] = cs | NFC_CMD_ALE | 0; > + addrs[0] = cs | NFC_CMD_ALE; > if (mtd->writesize <= 512) { > cmd_num--; > row_start = 1; > } else { > - addrs[1] = cs | NFC_CMD_ALE | 0; > + addrs[1] = cs | NFC_CMD_ALE; > row_start = 2; > } >
On 2023/6/8 5:18, Arseniy Krasnov wrote: > [ EXTERNAL EMAIL ] > > Hi again Miquel, Liang! > > What do You think about this patch? > > Thanks, Arseniy > > On 05.06.2023 22:15, Arseniy Krasnov wrote: >> Both operations have no effect. >> >> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> >> --- >> drivers/mtd/nand/raw/meson_nand.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c >> index 074e14225c06..50d3110ad321 100644 >> --- a/drivers/mtd/nand/raw/meson_nand.c >> +++ b/drivers/mtd/nand/raw/meson_nand.c >> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand, >> cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN; >> nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0; >> >> - addrs[0] = cs | NFC_CMD_ALE | 0; >> + addrs[0] = cs | NFC_CMD_ALE; >> if (mtd->writesize <= 512) { >> cmd_num--; >> row_start = 1; >> } else { >> - addrs[1] = cs | NFC_CMD_ALE | 0; >> + addrs[1] = cs | NFC_CMD_ALE; >> row_start = 2; >> } Hi Arseniy and Miquel, The two zeros indcates two column address. maybe we could use the micro "COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE | ALE | addr" consistency and also let function "meson_nfc_rw_cmd_prepare_and_execute" be more readable. Thanks, Liang >>
On 08.06.2023 06:23, Liang Yang wrote: > > > On 2023/6/8 5:18, Arseniy Krasnov wrote: >> [ EXTERNAL EMAIL ] >> >> Hi again Miquel, Liang! >> >> What do You think about this patch? >> >> Thanks, Arseniy >> >> On 05.06.2023 22:15, Arseniy Krasnov wrote: >>> Both operations have no effect. >>> >>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> >>> --- >>> drivers/mtd/nand/raw/meson_nand.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c >>> index 074e14225c06..50d3110ad321 100644 >>> --- a/drivers/mtd/nand/raw/meson_nand.c >>> +++ b/drivers/mtd/nand/raw/meson_nand.c >>> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand, >>> cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN; >>> nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0; >>> >>> - addrs[0] = cs | NFC_CMD_ALE | 0; >>> + addrs[0] = cs | NFC_CMD_ALE; >>> if (mtd->writesize <= 512) { >>> cmd_num--; >>> row_start = 1; >>> } else { >>> - addrs[1] = cs | NFC_CMD_ALE | 0; >>> + addrs[1] = cs | NFC_CMD_ALE; >>> row_start = 2; >>> } > Hi Arseniy and Miquel, > > The two zeros indcates two column address. maybe we could use the micro "COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE | ALE | addr" consistency and also let function "meson_nfc_rw_cmd_prepare_and_execute" be more readable. Liang, done in v2:) Thanks, Arseniy > > Thanks, > Liang > >>>
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index 074e14225c06..50d3110ad321 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand, cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN; nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0; - addrs[0] = cs | NFC_CMD_ALE | 0; + addrs[0] = cs | NFC_CMD_ALE; if (mtd->writesize <= 512) { cmd_num--; row_start = 1; } else { - addrs[1] = cs | NFC_CMD_ALE | 0; + addrs[1] = cs | NFC_CMD_ALE; row_start = 2; }