From patchwork Mon Jun 5 18:01:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 103426 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2873086vqr; Mon, 5 Jun 2023 11:22:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uFh8167uvPA7ESG/bQMDF1aYLMJ1E5UGN0gVbscfVOykVg5yPWV/5PDzLMCvb55fO+eCK X-Received: by 2002:a17:90a:c907:b0:256:4196:f722 with SMTP id v7-20020a17090ac90700b002564196f722mr4442260pjt.47.1685989344825; Mon, 05 Jun 2023 11:22:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685989344; cv=none; d=google.com; s=arc-20160816; b=wRlAonh8rToCPu8sKjXmOTaUqdIrneR6Rg9m7EqGEFwK3cIWO7ChaE7dd5qkI8POt8 8qbkxCbvCXYjUnbr0mfCpkBAlL07h2J1+k53j/BM/xmPDl/z8DAl4HLNp6SolpchJoE9 9P53bbKzlFRT/xtAmFhaPK0RWfO8/aVnPOM3NlEbQ0MtHYbAaItqB/t6tjnSBJ6BqebC 7JYf2fTrNlm8emjeacp1dL41Sq8xbrmmsB0mtSYzYjPUHP+J/mSbyoOGqE0C5eLh/Cs+ E6pXHJQMOOw65h3TChZw+S3TD2vCQh985B6x8dFV0M3Q2GC5lwdCR5S+nQfZgkrRj2IG lsSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ie87Rsgo8aPg48rij4Uj4QljQhDDMMh4hRxx38WJNYg=; b=fJ/1Vo1Q0Gg2xsblLQNazIn+BSXdyTpMzYNn1fBuSfmHKTHnnZMJ4ZtrV+7f7X9i0v 6FYVsk9koTOA6nXGHitGX3SzbOW7ve6tu55fjSPFjGaTr07JSwkZFEsBmffsbAfLwJ6s ur2q6NFqh/CAuRIHV6emY4p2on+o9svi70X4XU2NhWaT7g2KWdkSSrWyvayuqTRoIRXA FEEvXADAIeXkkaBChiJPKMzF43S1DBbmHpdgXYw12C+OaMbrBd9d1jwH3P52rIg4+39W XwqIRyA2yZduzLOO/FdYb6AvsLKcTeJr1kvXXmXpZLELILGgzdIX+UxDPQBmcX0K7zqt O1WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ppw4iyId; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v8-20020a17090a898800b002507aba141asi5912391pjn.171.2023.06.05.11.22.11; Mon, 05 Jun 2023 11:22:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ppw4iyId; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235182AbjFESC7 (ORCPT + 99 others); Mon, 5 Jun 2023 14:02:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232040AbjFESCo (ORCPT ); Mon, 5 Jun 2023 14:02:44 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3EE1E44; Mon, 5 Jun 2023 11:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685988156; x=1717524156; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RHLCXP5hfTbJ6gU+y68uMeUeAxpYN4g03xl30+9ejJk=; b=Ppw4iyId8ONnJheAOl3+grToJiUy02GnGhtHm9Rr/83hlOXTiNfSnoTD Zk0xh874vZ/mUZOkNvt87qaW1PuXBLH8+ODSGtl2t8FxxzYjGwv6gvOE3 BnLMa+ldFRGyYHZPinanEmwFNcxZYvY6XOXYGzwH0XmxpMHrWbO4fafau OoM57ZgkUB/jBgzrnkB5vAvc3DwLpoyUmQgi08NzzI6GGCpkoGgBZtJlE Uf2PbOtvV7fMM1tVy/xcLxgdwCvjOI8946GqpCFDKlY9171EA0E+ZePO9 f+LdQ9qOi33DFJTktUTGwLyea3K8F77dE6hLZGQpSXVJ/uXf31pCllGxC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="442815026" X-IronPort-AV: E=Sophos;i="6.00,218,1681196400"; d="scan'208";a="442815026" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 11:02:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="821274061" X-IronPort-AV: E=Sophos;i="6.00,218,1681196400"; d="scan'208";a="821274061" Received: from gfittedx-mobl.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.252.47.115]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 11:02:26 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Reinette Chatre , Shuah Khan , Shaopeng Tan , Fenghua Yu , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v3 07/19] selftests/resctrl: Refactor remount_resctrl(bool mum_resctrlfs) to mount_resctrl() Date: Mon, 5 Jun 2023 21:01:33 +0300 Message-Id: <20230605180145.112924-8-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230605180145.112924-1-ilpo.jarvinen@linux.intel.com> References: <20230605180145.112924-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767887963192774456?= X-GMAIL-MSGID: =?utf-8?q?1767887963192774456?= Mount/umount of the resctrl FS is now paired nicely per test. Rename remount_resctrl(bool mum_resctrlfs) to mount_resctrl(). Make it unconditionally try to mount the resctrl FS and return error if resctrl FS was mounted already. While at it, group the mount/umount prototypes in the header. Signed-off-by: Ilpo Järvinen --- tools/testing/selftests/resctrl/resctrl.h | 2 +- .../testing/selftests/resctrl/resctrl_tests.c | 8 ++++---- tools/testing/selftests/resctrl/resctrlfs.c | 20 +++++-------------- 3 files changed, 10 insertions(+), 20 deletions(-) diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h index f455f0b7e314..23af3fb73cb4 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -85,8 +85,8 @@ extern char llc_occup_path[1024]; int get_vendor(void); bool check_resctrlfs_support(void); int filter_dmesg(void); -int remount_resctrlfs(bool mum_resctrlfs); int get_resource_id(int cpu_no, int *resource_id); +int mount_resctrlfs(void); int umount_resctrlfs(void); int validate_bw_report_request(char *bw_report); bool validate_resctrl_feature_request(const char *resctrl_val); diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c index 0ee73e722acc..048ea8ae1e28 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -77,7 +77,7 @@ static void run_mbm_test(bool has_ben, char **benchmark_cmd, int span, ksft_print_msg("Starting MBM BW change ...\n"); - res = remount_resctrlfs(true); + res = mount_resctrlfs(); if (res) { ksft_exit_fail_msg("Failed to mount resctrl FS\n"); return; @@ -106,7 +106,7 @@ static void run_mba_test(bool has_ben, char **benchmark_cmd, int span, ksft_print_msg("Starting MBA Schemata change ...\n"); - res = remount_resctrlfs(true); + res = mount_resctrlfs(); if (res) { ksft_exit_fail_msg("Failed to mount resctrl FS\n"); return; @@ -132,7 +132,7 @@ static void run_cmt_test(bool has_ben, char **benchmark_cmd, int cpu_no) ksft_print_msg("Starting CMT test ...\n"); - res = remount_resctrlfs(true); + res = mount_resctrlfs(); if (res) { ksft_exit_fail_msg("Failed to mount resctrl FS\n"); return; @@ -160,7 +160,7 @@ static void run_cat_test(int cpu_no, int no_of_bits) ksft_print_msg("Starting CAT test ...\n"); - res = remount_resctrlfs(true); + res = mount_resctrlfs(); if (res) { ksft_exit_fail_msg("Failed to mount resctrl FS\n"); return; diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c index b3a05488d360..f622245adafe 100644 --- a/tools/testing/selftests/resctrl/resctrlfs.c +++ b/tools/testing/selftests/resctrl/resctrlfs.c @@ -48,29 +48,19 @@ static int find_resctrl_mount(char *buffer) } /* - * remount_resctrlfs - Remount resctrl FS at /sys/fs/resctrl - * @mum_resctrlfs: Should the resctrl FS be remounted? + * mount_resctrlfs - Mount resctrl FS at /sys/fs/resctrl * * If not mounted, mount it. - * If mounted and mum_resctrlfs then remount resctrl FS. - * If mounted and !mum_resctrlfs then noop * * Return: 0 on success, non-zero on failure */ -int remount_resctrlfs(bool mum_resctrlfs) +int mount_resctrlfs(void) { - char mountpoint[256]; int ret; - ret = find_resctrl_mount(mountpoint); - if (ret) - strcpy(mountpoint, RESCTRL_PATH); - - if (!ret && mum_resctrlfs && umount(mountpoint)) - ksft_print_msg("Fail: unmounting \"%s\"\n", mountpoint); - - if (!ret && !mum_resctrlfs) - return 0; + ret = find_resctrl_mount(NULL); + if (!ret) + return -1; ksft_print_msg("Mounting resctrl to \"%s\"\n", RESCTRL_PATH); ret = mount("resctrl", RESCTRL_PATH, "resctrl", 0, NULL);