From patchwork Mon Jun 5 17:05:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 103404 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2839679vqr; Mon, 5 Jun 2023 10:22:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7QzL5VABj9D4rvUtxPBKyfYTcUle3O146AuNnLvYV5NRa05T7ziA3ItN9eM6JVnbFooirv X-Received: by 2002:a17:902:cccb:b0:1a9:3b64:3747 with SMTP id z11-20020a170902cccb00b001a93b643747mr4930808ple.17.1685985726264; Mon, 05 Jun 2023 10:22:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685985726; cv=none; d=google.com; s=arc-20160816; b=TOlq4+1mjiYNiNANYcScCNVpSmlLffvyPg7vTK0XzYjGvoKjnhpImfSXDckKW6ZIQ7 /7Tz+4lPQnnzsbLJcr1ZbIsuA8RjsaCWYn6angNofoPiTBZ+kA+tBZzEinFG6HQZZ/GT 0Z821jHB5nqFI91So+m6uMcinu/G3M51r8rWP4vuo/ZtXjq+UrNWQJmlhGl2FWWm0Ia0 7msfAfHOubUq4GNDo+zYLWLzEubJD5f5/RTzIdopGw8dF0toPUOOZwVRxqNvu9JZeJRJ kZUh9n6SBG4CZlfSnBU5He0KlJ1vzsPCVwamhql2pbWxTKIcZii4lwZXqVUVZxeQSU8K UFwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dyRJChjL9Vc/5oc5t+l1x2RE1uTtdGFuiDanwyKmj2s=; b=eFsh5o2NRXTbZjIFW8MXfRUQR0w+TMWcVS1n2PPqvMTB93Cp0lqOIj9/yqN7mIsYd5 HidCtNov6k6ExjG39w+O2n6dNt5xIW/g4c/OrWC0ChW1V8b18p+uAGr4D40toHYBtdF2 woiyylC7DjuqUoh/eEVWe9pJfkv+QkXRGuHq7ZQb9pTdsDp+SRXvL664W6XxCkwhNLm7 LbE3S2SSlGETlfhRKzI2e+uWNabnf0ks6gajEcxrMnGJzCYLHle0VjuISe/BQ0QIEdH6 OhQb3CAyL4DZafFRnZ7luzGa5nTXSAdgSaCzmIFztXkPwg/ukNjFTCd9fi8O7U+YzzYH 534Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gZnt7i7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a170902680700b001a69d1be184si5590878plk.506.2023.06.05.10.21.53; Mon, 05 Jun 2023 10:22:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gZnt7i7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235182AbjFERGA (ORCPT + 99 others); Mon, 5 Jun 2023 13:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232289AbjFERF6 (ORCPT ); Mon, 5 Jun 2023 13:05:58 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90D9EF1; Mon, 5 Jun 2023 10:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685984753; x=1717520753; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Uqba7KW+LSTrR6KDuN+F/tgiTmPx6AhRcJexGJYfzL0=; b=gZnt7i7S5RAKnCKhWoOseINM9UweFOim683+c0tM4l+IvhnrTiEsvNsw JAbAU1C6zGh/Jgx/2ys2TRPKu32shLHlX47KJdo9lEMBGzeqdPFOutF6E sXVfRKyebWO6uAl1SSnvYo2BJLsEGI2CyZNgM23CdLIWozuWyhe7pHjfY l9Nxg6UnQShrJF8Q7HpHEZB+EtoN5++Oz4mwgOXik1k7dVyxUHOZIqEDC eU/oQPvR4mY32FA+j5qW6AJJtHJwXa5CPKCnY9K/cT2jPhSqrirF88/rR s3YfBWRqAuPdYQ4yjKUwKZbtbhqMVxwOqK5YTIKOdCtUO9LfCAyauBLRi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="356431378" X-IronPort-AV: E=Sophos;i="6.00,218,1681196400"; d="scan'208";a="356431378" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 10:05:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="773807505" X-IronPort-AV: E=Sophos;i="6.00,218,1681196400"; d="scan'208";a="773807505" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 05 Jun 2023 10:05:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AE297379; Mon, 5 Jun 2023 20:05:56 +0300 (EEST) From: Andy Shevchenko To: Kees Cook , Greg Kroah-Hartman , Andy Shevchenko , Cezary Rojewski , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Theodore Ts'o" , Jan Kara , Andy Shevchenko , "Rafael J. Wysocki" Subject: [PATCH v3 3/3] kobject: Use return value of strreplace() Date: Mon, 5 Jun 2023 20:05:53 +0300 Message-Id: <20230605170553.7835-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230605170553.7835-1-andriy.shevchenko@linux.intel.com> References: <20230605170553.7835-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767884168982763132?= X-GMAIL-MSGID: =?utf-8?q?1767884168982763132?= Since strreplace() returns the pointer to the string itself, we may use it directly in the code. Signed-off-by: Andy Shevchenko --- lib/kobject.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index f79a434e1231..16d530f9c174 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -281,8 +281,7 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt, kfree_const(s); if (!t) return -ENOMEM; - strreplace(t, '/', '!'); - s = t; + s = strreplace(t, '/', '!'); } kfree_const(kobj->name); kobj->name = s;