From patchwork Mon Jun 5 13:08:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 103261 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2681973vqr; Mon, 5 Jun 2023 06:21:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6roUcCItN+OBLgfwgLVffaSSRq42ndu4hs8FFnFvb0yep+K2yFRGB9UMQoAJMILOYU65+1 X-Received: by 2002:a17:902:b212:b0:1b2:1a78:fb5c with SMTP id t18-20020a170902b21200b001b21a78fb5cmr606441plr.29.1685971263018; Mon, 05 Jun 2023 06:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685971263; cv=none; d=google.com; s=arc-20160816; b=RzVW+pl0BQF52Z0xywAc3PTzeUjMXhsYlVW0us0HOqaOQlnJ7B4UX2YRuMfXt7BCu8 JqCQjr9a+ByGsQcNVcDZ+Q7YFOpzxMbY6ps7/Fwm5kyymU9nYRkJ0bodwrTOWok/f4JR Hd+vWDzCeh9nMLe1pYpLR+52iKQMH4V47cYuMWSdTuW4StLzIwti3c9GTKf01jmEPM7m 7PcZQd2LKlkqcrVSg+jiTvlpDnAQbgKbIDPs9jRo3AjndRht2WIV5v2wBdWYE0gVaiiG jMG6zmyM4PBjUPkf+yLhriimRt4362G/b+AvblrRQSrCfbPWcZl1/W0rP3jK7IEekFfa Recw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HVZpwAe7ZJYKa3APlo8w0/nQ0GlrZrHkao0x4jFZcis=; b=cCKoO93mlQqQaIooL7EtxYRSGpapfGSf6vusfLKBbif2wON91siwsfpVNvKq7FRmB6 KxqxB3rNTQM/siez27pUR9ds1xNbW3kDtrzxX9WRyMWyM2RnwWyhmdBP0G+svZ/lzmOd M5cbaZjE4MnxW4VZS3pS1RjWQExLjApCcjoWQTHWFQGiSsWe5wNGFMo2ECGJ0FFKdcmJ CHy7RT7eWhdBUkYw5+nCdxZvdlRJuUxZ0cwBAUwy1YQ7nVxAkpFossQ/rFYSdjCxzGJm Ec96+kLtyNMR5cD3+waaE6aWsgSGf+yMC3Tm1jDGtJn2YK2j6dRWa7kYlL4RkfJBZUdC 69fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l3-20020a170903244300b001ab21df5958si5538322pls.515.2023.06.05.06.20.47; Mon, 05 Jun 2023 06:21:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233993AbjFENKU (ORCPT + 99 others); Mon, 5 Jun 2023 09:10:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233965AbjFENJs (ORCPT ); Mon, 5 Jun 2023 09:09:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31EF4116 for ; Mon, 5 Jun 2023 06:09:44 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q69xM-0001WI-KH; Mon, 05 Jun 2023 15:09:08 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q69xF-005HiM-PH; Mon, 05 Jun 2023 15:09:01 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q69xF-00BOyL-3v; Mon, 05 Jun 2023 15:09:01 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman , Michael Ellerman Cc: kernel@pengutronix.de, Jiri Slaby , Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4?= =?utf-8?q?rvinen?= , Kumaravel Thiagarajan , Nicholas Piggin , Christophe Leroy , Tharun Kumar P , Rob Herring , Helge Deller , Randy Dunlap , Geert Uytterhoeven , Matthew Gerlach , Liang He , linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] powerpc/legacy_serial: Warn about 8250 devices operated without active FSL workarounds Date: Mon, 5 Jun 2023 15:08:56 +0200 Message-Id: <20230605130857.85543-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230605130857.85543-1-u.kleine-koenig@pengutronix.de> References: <20230605130857.85543-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1676; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OtOaPvHV+suEiSPknSI11DIRzLXr23I/hyoeM+NczkQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkfd5llrJCU4sjBgMwgCCNdyx9Kyzm5rtUF5+sf RdKQxmUQbeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZH3eZQAKCRCPgPtYfRL+ Tq7eB/9IStn2Ffu4XF3y20ak+X/QW+d/F/9OSKKrxvbue63tJH1XovgRrOqDXRCPotg42yDFPi5 4QcZBIlNrKxNhMRphq0LBtZVu0j8SpDQkzZ07G1GIst+sSI6e1AFmeg2sy++pKU+ZJE7O8YCwSK ioX/dZcnsbQ8j8ZZJ7oCD+PRUmwuEm7dcCVLFELf4THj/fSde9hLXZJNHCa9cLKr17Nbp/qe0VV W4OAAbiGQkcms4U7LQ6k3E2iYqVa+VAwVo41xada+WXokF676A3FrjUwrsyZhkzHRrVb0b7GmGQ 6ZHbfutMWtjnwG/Uk9lK3rX2n4aVCy7fz7qx/ge5PVsKxKj5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767869003450682693?= X-GMAIL-MSGID: =?utf-8?q?1767869003450682693?= If the 8250 driver is built as a module (or built-in without console support) the Freescale specific workaround were silently not activated. Add a warning in this case. Currently CONFIG_SERIAL_8250_FSL=y implies that the function fsl8250_handle_irq() is built-in and can be used. However with the changes of the next commit CONFIG_SERIAL_8250_FSL might be enabled also when the 8250 driver is a module and so more care is needed when fsl8250_handle_irq() is to be used. The code added here is able to handle the new situation already. Signed-off-by: Uwe Kleine-König --- arch/powerpc/kernel/legacy_serial.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c index c9ad12461d44..fdbd85aafeb1 100644 --- a/arch/powerpc/kernel/legacy_serial.c +++ b/arch/powerpc/kernel/legacy_serial.c @@ -508,12 +508,16 @@ static void __init fixup_port_irq(int index, port->irq = virq; -#ifdef CONFIG_SERIAL_8250_FSL - if (of_device_is_compatible(np, "fsl,ns16550")) { - port->handle_irq = fsl8250_handle_irq; - port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE); + if (IS_ENABLED(CONFIG_SERIAL_8250) && + of_device_is_compatible(np, "fsl,ns16550")) { + if (IS_REACHABLE(CONFIG_SERIAL_8250)) { + port->handle_irq = fsl8250_handle_irq; + port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE); + } else { + pr_warn_once("Not activating Freescale specific workaround for device %pOFP\n", + np); + } } -#endif } static void __init fixup_port_pio(int index,