From patchwork Mon Jun 5 11:20:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 103212 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2614588vqr; Mon, 5 Jun 2023 04:33:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ50HphnPljaSrIFU2LvSeIXQJnBbsLkiXxdF2p6Y3NTzrC/QTnGBIbrFSapYZKOi7q7ye3q X-Received: by 2002:a05:6359:5:b0:129:c6d1:2176 with SMTP id en5-20020a056359000500b00129c6d12176mr759937rwb.15.1685964821671; Mon, 05 Jun 2023 04:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685964821; cv=none; d=google.com; s=arc-20160816; b=W5LmID7w4V6dD2zT/tfwbgih3MXWb4OK/nXABAE8kckmnka6LFXer2auhXVrL909TK zZjydpfrUikVq5hz0LiHl6Buz+XkdkesYp6sDDWyCykJhA54UcA1QzczymQszKJ49pd9 k/SVxlDM3V1fbf1dgAMczgvPsYUtsuNVW2EB7fljrm0rqt8LZ86cyLEnyw9omq5S90gh RVyzdbJ5Yj3IEyX91FK951axVHL+lakJma+dpD2gU1AV88pVTkJWrVQ/Kx6XICInJ/Su L0BI9L7w9505qm0harYmr+cru5/B7UiXY1F0hmmhnxkcLPGMKEaiTsI91ffP0hl/HCeA A3Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1R4fhfv273BRKa7g8QftkcVToX74NsXhfGkqmQOQQSA=; b=yab3ayDy2+q9CHzNBFSp1VUsvO2ALpar78MXTKTuTCk1fxBJgR7ccTo00zxSkT+0RA MNnNXdZuuQ5wQ//sAOD4nrgT3T5CwZoBYfPHk8l4fYyh5ZGqHX3GeFQbiPYJuy9XDn4c V0xIWBiq40bBzomjprDh1aUiP4Wf1u/51HPOdXiPIUf5oIaR3HWcB8vInSx5tZWJKTv2 pbsM+d+YRJl3SoCcv8iHK8sgUgCd/8ffofKnJ+bP5psygBUI9u0zVKAeRRfQs9wz5SW7 ab67dFpuR9GDAG/3AbNP/Wr4d5XxHWlLOYJ0OyucYseNPCoZ1BhkS4OdKvT1kupT8nYh B/Ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a17090acf0800b002563e365aeasi3948569pju.53.2023.06.05.04.33.29; Mon, 05 Jun 2023 04:33:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbjFELUt (ORCPT + 99 others); Mon, 5 Jun 2023 07:20:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbjFELUp (ORCPT ); Mon, 5 Jun 2023 07:20:45 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D78DE6 for ; Mon, 5 Jun 2023 04:20:44 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q68GL-0003m5-19; Mon, 05 Jun 2023 13:20:37 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1q68GK-005G7Q-4P; Mon, 05 Jun 2023 13:20:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q68GJ-00BNMZ-7a; Mon, 05 Jun 2023 13:20:35 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stuart Yoder , Laurentiu Tudor Cc: Nathan Chancellor , Nick Desaulniers , Tom Rix , Li Yang , Ioana Ciornei , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel@pengutronix.de, kernel test robot Subject: [PATCH 1/2] bus: fsl-mc: fsl-mc-allocator: Initialize mc_bus_dev before use Date: Mon, 5 Jun 2023 13:20:24 +0200 Message-Id: <20230605112025.80061-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1578; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=c6bJ2ay5Rd48NgkuUkmtQ3ctU95uZds+wP3O7QXgqjE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkfcT3WoV9/4ClH+99osCsQZT1sNqjx+MC9tL5m S3TFV3l0ZGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZH3E9wAKCRCPgPtYfRL+ TiP4B/9JfNY9jYUBzOzHl1+OEEEBUVuuH7CN/1WXNljG4uV9//brOqKUpidsC4v/eBl5t/1b5+f VbFJhu9yabAvap7+4dzjNv+/vAlacjCOd0bzvLUq2ZDHbppDDcjJAJi6YRC8Tj4S5S8Wy8Vrfpi PsPLi2Mndl8vVdOsyl3KoibnDSM3kUi0aB9ntMElteQhDLiiXcqtszvfdtWcYkpeExi6qepHAmK bBLuTztJGFH1m/9+U35ohRkdaLHq9dla+/O8s3rOB/fn3XSPFSgjlo05lV+p1vD0oWnXmudz7mQ dN9TPx6og3FfrGApIQEbBAgdNi28azHOB1O/rO7nNd+Rb49c X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767862248810876035?= X-GMAIL-MSGID: =?utf-8?q?1767862248810876035?= Fixes a clang compiler warning: >> drivers/bus/fsl-mc/fsl-mc-allocator.c:108:12: warning: variable 'mc_bus_dev' is uninitialized when used here [-Wuninitialized] dev_err(&mc_bus_dev->dev, "resource mismatch\n"); Fixes: b3134039c5b3 ("bus: fsl-mc: fsl-mc-allocator: Improve error reporting") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306021936.OktTcMAT-lkp@intel.com/ Signed-off-by: Uwe Kleine-König Reviewed-by: Nathan Chancellor --- drivers/bus/fsl-mc/fsl-mc-allocator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) base-commit: 59272ad8d9e8ea6398a96f8c6d62da284bf2ae6e diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c index 0ad68099684e..991273f956ce 100644 --- a/drivers/bus/fsl-mc/fsl-mc-allocator.c +++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c @@ -103,14 +103,15 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device struct fsl_mc_resource *resource; int error = -EINVAL; + mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent); + mc_bus = to_fsl_mc_bus(mc_bus_dev); + resource = mc_dev->resource; if (!resource || resource->data != mc_dev) { dev_err(&mc_bus_dev->dev, "resource mismatch\n"); goto out; } - mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent); - mc_bus = to_fsl_mc_bus(mc_bus_dev); res_pool = resource->parent_pool; if (res_pool != &mc_bus->resource_pools[resource->type]) { dev_err(&mc_bus_dev->dev, "pool mismatch\n");