From patchwork Mon Jun 5 10:58:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 103207 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2607416vqr; Mon, 5 Jun 2023 04:21:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6MmOcHONlARm2FxdmwfyaaUyB0spHun4bMXuWsoU0hXn/38NjgmksT/X39cfgP/SxDMdQ9 X-Received: by 2002:a17:903:189:b0:1b1:76c2:2966 with SMTP id z9-20020a170903018900b001b176c22966mr7700642plg.20.1685964063473; Mon, 05 Jun 2023 04:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685964063; cv=none; d=google.com; s=arc-20160816; b=aXmEO8xHkl/LDXhn8n0Kp9lmxqLAQuA19XzkAg7Cp/NiExcZ3PzMWz2DrcGsz9QEGI bdtRnFtbk5ri2UpkLQGjZbUuAWEAoZyDuemV2qTNYVBG9yotMX548kDcxBohvHW2hgZV hw3WEjGl5tLYzKAx/R3IiAvklNLmlv7eT+deH1kKimhMZ9AHL833I9tJRfeVMpwRck7V Flt3R2fYbkdhB642w8vvB+EJhvjl/Ge3n8nKAX8wktfrN1dMT888SdGbxtcmgUbbFlD/ Mq7PA+HBpjYj5mBWtX9BIkpJQe19gOla6nXobXX1WoT6DdTjRk1r3zWTYSDZPzMpNuH6 a6Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MmI/y0ket11kGdOgwNXYHoHDSx1W8buj/ysRgmI96tM=; b=xIk2RzFlJdZKESkIqUWJeDwjyLHDyXk/rxpQZb0hGJnqVFp5182SEpQ4zKJaXaZQmy L15k1qsnAX1Tav/ESxJW1sqa0+fZqrRDUd/X6FsSv1I+CuZ8F9p8yeBOVnDmphzs4PFb f5dJaKLcy7KYc2MkD/0qA/gGkHQLbTkDXOeo96bwSrfss//5wgTSFR6m0cePK+f50oe6 6ywtQ0H3DfNdJy1qdWy6BqCJxdZ04Fik2ksDHljF5+oH2cOYwL+AkBDvAe9SbgXFC0qb U+9nCDygHiOuDa2YkiJm01tacW4gtq+OeNym6QJN14f7gUj79IV/Eyo2ptVLypX55XRg HX4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rBrmPNUs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f3-20020a170902ce8300b001a9b29b6763si5431807plg.399.2023.06.05.04.20.50; Mon, 05 Jun 2023 04:21:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rBrmPNUs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230300AbjFEK6o (ORCPT + 99 others); Mon, 5 Jun 2023 06:58:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjFEK6m (ORCPT ); Mon, 5 Jun 2023 06:58:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA93FED for ; Mon, 5 Jun 2023 03:58:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60BE16155E for ; Mon, 5 Jun 2023 10:58:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E8AAC433EF; Mon, 5 Jun 2023 10:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685962720; bh=zFZh3DbitN9/k0ynfjMxiJVKXQDruFuT+gVPq2YmqCo=; h=From:To:Cc:Subject:Date:From; b=rBrmPNUsgjY6al0qoJqoSXyT5aYOhiIKrmiF/ZdmjXFxlThaQMW7jlGR9p1jzPNQc IpMDKNokZ4FTmzs4tvOl+sb/RxGbQCXpx7nMXMXI4N9xPZRtzW/zNYMlC+abLbnSnS eMwz2g1ZKQ2JxWuIGKGhjNEtqUwj+x7pwlTHsmM+srlIG/j5yWcEQk3qSL39F+I3XL RklCd6dmIlnbLCD98jmsSMASvZX+QzU9u42KgyLZfnP1tClmLBqjux4OcTTXjLZlV0 aoaW5QYhEg28wGfb/GUYKYQzEzbMQmy+ukoGcUW1OeEiC8CRNuWwClPV/go/0IUHHi t6UzQ30QEb6CQ== From: Arnd Bergmann To: Felix Kuehling , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Jonathan Kim Cc: Arnd Bergmann , Ramesh Errabolu , Hawking Zhang , Yifan Zha , Le Ma , Mukul Joshi , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdkfd: mark som eclear_address_watch() callback static Date: Mon, 5 Jun 2023 12:58:28 +0200 Message-Id: <20230605105834.702945-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767861453929781330?= X-GMAIL-MSGID: =?utf-8?q?1767861453929781330?= From: Arnd Bergmann Some of the newly introduced clear_address_watch callback handlers have no prototype because they are only used in one file, which causes a W=1 warning: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c:164:10: error: no previous prototype for 'kgd_gfx_aldebaran_clear_address_watch' [-Werror=missing-prototypes] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v11.c:782:10: error: no previous prototype for 'kgd_gfx_v11_clear_address_watch' [-Werror=missing-prototypes] Mark these ones static. If another user comes up in the future, that can be reverted along with adding the prototype. Fixes: cfd9715f741a1 ("drm/amdkfd: add debug set and clear address watch points operation") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v11.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c index efd6a72aab4eb..bdda8744398fe 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c @@ -161,7 +161,7 @@ static uint32_t kgd_gfx_aldebaran_set_address_watch( return watch_address_cntl; } -uint32_t kgd_gfx_aldebaran_clear_address_watch(struct amdgpu_device *adev, +static uint32_t kgd_gfx_aldebaran_clear_address_watch(struct amdgpu_device *adev, uint32_t watch_id) { return 0; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v11.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v11.c index 52efa690a3c21..131859ce3e7e9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v11.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v11.c @@ -779,7 +779,7 @@ static uint32_t kgd_gfx_v11_set_address_watch(struct amdgpu_device *adev, return watch_address_cntl; } -uint32_t kgd_gfx_v11_clear_address_watch(struct amdgpu_device *adev, +static uint32_t kgd_gfx_v11_clear_address_watch(struct amdgpu_device *adev, uint32_t watch_id) { return 0;