From patchwork Sun Jun 4 13:12:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 102993 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2141160vqr; Sun, 4 Jun 2023 06:29:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ojK7CjBdZS4qTnEBe7VZSCudyt26GdTb7m0+5K57Hh3Uyi6eaN55YqTp1ZKmcW8VrES+Y X-Received: by 2002:a17:902:f685:b0:1af:b92d:b5fe with SMTP id l5-20020a170902f68500b001afb92db5femr6215581plg.0.1685885350759; Sun, 04 Jun 2023 06:29:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685885350; cv=none; d=google.com; s=arc-20160816; b=PrCqkQFTOweEGHcD8J3ALywsmK1ka2D/zT8HyHMWbm5BwEkCHsOM0/HgNS+P462PBw lgSJBDj6BqSyEF66FlBpxD1nSWkllmfHIibvdkHgQwDa0EyLFDHtYUhvWm3iUkSebJ/y 5tg0XMpZpmuPyVNVCDhjWDGxJK0Eiz0WxP4urd4D7LEpTID2gSdBlfD/okiOGn6Dgh7u QDkKrxgPPdhOn+vUwafZLvLl+etksZEtJi7B0n8P6uvkz1dI3nQ6ggp+XYYVem5HQS5I dlWTKMEdcD3wQBOaevkBhv2wVTcwRVE7gCXl3c1tqP6rf499MTaXQdZpYOZ0+outJDoa S77Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X0MDlKF81xttyNk8qOLv823Jp1xEdupisXcPM+en/hU=; b=QeiliT3BhzyJZruGCLtjLssDEblm+FjPdicu60G6qOGnVq8ILJmIsoM4r6nfuqsJCH V2daBPriYyUbijBsRBYD9fp8qGm2IIrufpl4HoJJLC9oiGlnGA9PlkkMstu1wrZW9vRj 7BgOWN6rliWZS0tuSv3nujI9GINSMNoJiqxNX4DVeGggiRYYEgRY2Auqoiy2oq7p9tXH grNtI/qCstjr+ppZn4BevhNIbQvUSc1J3tfW1FDT+OVpFl8UmSLY7JCcfs7Nujn/Wn6y /fh0RWtLHamg5qdKSYctyMiCvCu62qtuQnIVuOkk8tKXSriqoVme/WJd9Us974tNzsHN OC6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IrBDL5qQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a170902d34c00b001ac6189cac3si3946487plk.187.2023.06.04.06.28.59; Sun, 04 Jun 2023 06:29:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IrBDL5qQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231944AbjFDNMR (ORCPT + 99 others); Sun, 4 Jun 2023 09:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230487AbjFDNMO (ORCPT ); Sun, 4 Jun 2023 09:12:14 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE84BCA; Sun, 4 Jun 2023 06:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685884333; x=1717420333; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5vg61FkTTaqJtLcNTfO3vDFQp7XbtULOPcw177woejk=; b=IrBDL5qQtkpLI0y1HgvscPKxqGxzgIYD2r0705Jmsj7Zwntx5Uh05epQ 3k4obwcy8dTjjYq8ONPVGBNgThcKfig5Q29XP+QPPQ7lStBgX9gKqrgIe tPSRX4qVgL7X//DWhbpwj6xWs9ATyfsGgL5NgpqknjcQBAguQjQI+bKbm 8MJLehGtPJfM6TewBDvYb3fAsHUJj0dWKuSRl+S0hCI41SemOLzBx2vMb JlOmHTWsmgVqwh3HtlA71ibdPhyv7hcH1S7UUyjMmjzuDvaKvtYdiO/tD oNEVbAK4+Xn2ASG2/X13kJ/4VGx2WFv0gJubPuKf/MmCnrsxu9QQz985Q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="422008645" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="422008645" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2023 06:12:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="778251867" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="778251867" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 04 Jun 2023 06:12:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D02A72A6; Sun, 4 Jun 2023 16:12:17 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij Subject: [PATCH v1 2/2] pinctrl: Relax user input size in pinmux_select() Date: Sun, 4 Jun 2023 16:12:15 +0300 Message-Id: <20230604131215.78847-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230604131215.78847-1-andriy.shevchenko@linux.intel.com> References: <20230604131215.78847-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767778917705876173?= X-GMAIL-MSGID: =?utf-8?q?1767778917705876173?= This is debugfs and there is no much sense to strict the user from sending as much data as they can. The memdup_user_nul() will anyway fail if there is not enough memory. Relax the user input size by removing an artificial limitaion. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinmux.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 2d2f3bd164d5..82c750a31952 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -677,7 +677,6 @@ void pinmux_show_setting(struct seq_file *s, DEFINE_SHOW_ATTRIBUTE(pinmux_functions); DEFINE_SHOW_ATTRIBUTE(pinmux_pins); -#define PINMUX_SELECT_MAX 128 static ssize_t pinmux_select(struct file *file, const char __user *user_buf, size_t len, loff_t *ppos) { @@ -689,9 +688,6 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf, unsigned int num_groups; int fsel, gsel, ret; - if (len > PINMUX_SELECT_MAX) - return -ENOMEM; - buf = memdup_user_nul(user_buf, len); if (IS_ERR(buf)) return PTR_ERR(buf);