From patchwork Sat Jun 3 15:03:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 102771 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1509374vqr; Sat, 3 Jun 2023 00:12:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7lfcUcEZfH9KKrhsDjWdxqgLt2vZUvwgyLC7D2q2EmD5sHfxUbw1rFstpsLC3SPzBhsAy3 X-Received: by 2002:a05:6830:1484:b0:6af:9f36:fae4 with SMTP id s4-20020a056830148400b006af9f36fae4mr5006310otq.10.1685776377369; Sat, 03 Jun 2023 00:12:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685776377; cv=none; d=google.com; s=arc-20160816; b=EWM1ORRMy9e9vhCNibRpLznkxesNaCBykD4kcIJsmNw60PfYTA5CuruOr9j1nHjTCo zVes7fwHC4MaQxFonTYf5uJnKhvUHn1IMXTy9bG+rrstcGeO4Ba+5T6+jFo3+GES3nyG e3L3DJlAWKSQaq1dLLnc1nWqLTTE8YpgBtogR7dQSV8zNpByluRZg3wq4OcCS6gH7S67 zkBv04gotHlFDvAoIefMrLG+Fjjl6q+cdvwCH2V3uY9r+0Y60MM1VVzfdEak1s7q6k/N yFCfwQjIq71WNeu7XHZ9ehVfg2LQj9G226AUkvPvXDnkUNyvNLKQPiGMcAXL1sSSTW86 Gy9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HhgbWGRGgl3wevaVjOCRlzAaK3a+ULy1j78iHfpP4FE=; b=MP16MqC6SdkMm+RrbogDPGiO1AvsgJDKsJh0aAaR7zkXKCupGmu4rHQks/P236WKuW EVlAfC5CHYOKw41H1AjATUASzTw+s6gg/EAQC07Kn+HHn5UZvnbNnMkEEsaRvantS4+G LWPq45IsXnVULFPK0enJ9HXgpkplQCI9SYLgUkkToMOG/Hda5ktU1YzixuM1rDUmHTks UgcoD4lcEd4t4R/PVwBKyH4bgfktomJ0brtKLjRbPBJGA1g9LJZyOfFomSHX7RhIvsY+ siDIfd5jmPKIvbBS3jxLVGBbct7a1FKPnTBS9V8cnpFTP/cOLS3DYFWHsKfdXi4hAz+I 3tPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a621713000000b0062d7d3c6cadsi1918119pfx.333.2023.06.03.00.12.43; Sat, 03 Jun 2023 00:12:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234105AbjFCHC3 (ORCPT + 99 others); Sat, 3 Jun 2023 03:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232259AbjFCHCK (ORCPT ); Sat, 3 Jun 2023 03:02:10 -0400 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF20E180; Sat, 3 Jun 2023 00:02:05 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4QY9lq74kZz4f3npx; Sat, 3 Jun 2023 15:01:59 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgCHOKxk5Xpk+MxPKw--.30174S5; Sat, 03 Jun 2023 15:02:01 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, ojaswin@linux.ibm.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com Subject: [PATCH v4 03/19] ext4: fix wrong unit use in ext4_mb_find_by_goal Date: Sat, 3 Jun 2023 23:03:11 +0800 Message-Id: <20230603150327.3596033-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230603150327.3596033-1-shikemeng@huaweicloud.com> References: <20230603150327.3596033-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgCHOKxk5Xpk+MxPKw--.30174S5 X-Coremail-Antispam: 1UD129KBjvdXoWrZFWUCw4UZF4rCr4Duw43trb_yoWftwc_J3 WqyrykGFWrJr1fC3WFyw4rtrnaga1rJr1YgFWrtr15WF1qgrWFk3Wvkr4fZw4xWa1UXa9x KrnxXrZ7GF1F9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r1rM28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6I AqYI8I648v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAq x4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r 1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF 7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV WUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTR HMKAUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767664650175476550?= X-GMAIL-MSGID: =?utf-8?q?1767664650175476550?= We need start in block unit while fe_start is in cluster unit. Use ext4_grp_offs_to_block helper to convert fe_start to get start in block unit. Signed-off-by: Kemeng Shi Reviewed-by: Ojaswin Mujoo --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index d8caef7cd9d0..f6dc4f276ca4 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2210,8 +2210,7 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, if (max >= ac->ac_g_ex.fe_len && ac->ac_g_ex.fe_len == sbi->s_stripe) { ext4_fsblk_t start; - start = ext4_group_first_block_no(ac->ac_sb, e4b->bd_group) + - ex.fe_start; + start = ext4_grp_offs_to_block(ac->ac_sb, &ex); /* use do_div to get remainder (would be 64-bit modulo) */ if (do_div(start, sbi->s_stripe) == 0) { ac->ac_found++;