From patchwork Sat Jun 3 14:52:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Demi Marie Obenour X-Patchwork-Id: 102844 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1700863vqr; Sat, 3 Jun 2023 07:54:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xydS9YgMujLjPnniJDadYwuLCfiPcHXCAr/8j125tf8TgKwSYnuOKbDzD+BqgNtitujn9 X-Received: by 2002:a05:6a20:8f25:b0:105:2e9e:b13a with SMTP id b37-20020a056a208f2500b001052e9eb13amr1799321pzk.8.1685804079318; Sat, 03 Jun 2023 07:54:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685804079; cv=none; d=google.com; s=arc-20160816; b=1GhalGXWMClcMkMvTlVNs6pSbe2xMp0PEOTadt2wVD7pNmAQX+qVISgt+CRytgL433 v09ALHAmjCj5aQNP6bvidxrb4LuoymI5gJCEE0hWTE1hEHPW0FgVLOFdxyAsxtPtMkhb mgM9IXeWouJQviG81HcnMjnOCc6RpiiMch7w1VoM8FVXwFuONQEcgmu5hXoyYKsOngT3 SP2k7vswSZLr+bsVVKGy9rbGsSrNAjbeP06vmzH4d3jNqKcqNn+i1ILe+Yzt/B0ulYYU IDlk4sjlRsDXibqw00LNlg9kJgAH7gqMmZ+othJ/raIdA39BEwo8gQBt6Au0dySw4RbF cBWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=bzf2lzXwm0yOFyHlXVDw/mThYLsZ0cA++V3ZJ1NyFW4=; b=Tjg06ZnjVxETPxvNvCp6yb9A7M73Rn5uqXoB2pQynYqtQhPO6lBc2FBShoUqvFqbYo 2c8CkSAPPgC0s5JECJjSTuVFgGotEpSrMGqCgUMiVBBB6AMxQUKbcHh+VY4b805LjoD8 q8bjjkRGtJbe4Q6C1/+gcwbZ9TQ6ZirskiKk09cuNVm8yk7g/7kWvVFGW8gaYSDKZPrZ BLrJPygzyktCrcZB9UR4b4oobAlCJDg0UZ30TjjMORkwZyIU144H9SVwlPsLHGOBguIZ /gri5v4gZFSA9xjhaw8Mt+sGqw/2eDafosZWUPlHTO/KiQM5mRunv9XClgqVVv0weK6i 5htQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@invisiblethingslab.com header.s=fm1 header.b=ksRwITEN; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=mK3adYSf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020aa793c4000000b006391322d3f8si2145533pff.375.2023.06.03.07.54.25; Sat, 03 Jun 2023 07:54:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@invisiblethingslab.com header.s=fm1 header.b=ksRwITEN; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=mK3adYSf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237136AbjFCOxc (ORCPT + 99 others); Sat, 3 Jun 2023 10:53:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235879AbjFCOxV (ORCPT ); Sat, 3 Jun 2023 10:53:21 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9BEE1A5 for ; Sat, 3 Jun 2023 07:53:20 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 441865C018B; Sat, 3 Jun 2023 10:53:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 03 Jun 2023 10:53:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1685804000; x=1685890400; bh=bzf2lzXwm0 yOFyHlXVDw/mThYLsZ0cA++V3ZJ1NyFW4=; b=ksRwITENMjfZbLijYMBGgB4obj Z8jhiq5RyMTyd7FtGeuPdHhxAtTkH7l5FU2eduhrz+jaXKhExJPqken41iClDagx /7PSOKaEcQmI5VejX1xzh5ADEBtIvTSeXbx1mCm/ex5XmyMxM42zZpWJ0tC6pZWV /zdF1oq7J4H9ZfzPJntxkAz+Nw4dQVMf+ksDop/LjJ3QVO3ltqX6/l1QZAhOl52i FBDH5WCLAVL1VV/0/KXk69BSXntmkInEk+b399rZHodrvvvaNUBn5vXsiaWS/GCb qbAJ5FPdv3H3++kNYAhetFinoEgVgXzwbvTBShksM85uKgX34xQypXarAqbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1685804000; x= 1685890400; bh=bzf2lzXwm0yOFyHlXVDw/mThYLsZ0cA++V3ZJ1NyFW4=; b=m K3adYSf3veZMGbd7z2H9VE0Rk34pWAOoILfsPZfDA2b6VUwR8d9LPbjmKqGy28qW ItbDoXOIGdomPzzvdmYvQd4CFhjM+b7CHhkTSiH93L0a0yjKNkuyRzd/F1fX8x4H 1w4/5i1PkAAcDBn8GIS1h+6RLk8uxdXocy4uIhNSi6bv3K0RpTM7uIXdi17WoZyz qQ0IpUTX009Yf9zi7PT21hI/jNqIvvowg+eyBOaAws4yu88kRPgOHA6cSJ+6CiD+ x1umJG38gkBLKWuHuuFSFtAXGDIrPeIp2p6P4eCpYTsV0Kfw+jDwKutF14KgDHTj rg7zQo7uL44vEg8lM6WLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelhedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgepfeenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 3 Jun 2023 10:53:19 -0400 (EDT) From: Demi Marie Obenour To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com Cc: Demi Marie Obenour , linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] device-mapper: Refuse to create device named "control" Date: Sat, 3 Jun 2023 10:52:43 -0400 Message-Id: <20230603145244.1538-6-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230603145244.1538-1-demi@invisiblethingslab.com> References: <20230601212456.1533-1-demi@invisiblethingslab.com> <20230603145244.1538-1-demi@invisiblethingslab.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767537545562559086?= X-GMAIL-MSGID: =?utf-8?q?1767693698098541447?= Typical userspace setups create a symlink under /dev/mapper with the name of the device, but /dev/mapper/control is reserved for the control device. Therefore, trying to create such a device is almost certain to be a userspace bug. Signed-off-by: Demi Marie Obenour --- drivers/md/dm-ioctl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index 7510afe237d979a5ee71afe87a20d49f631de1aa..5b647ab044e44b0c9d0961b5a336b41f50408f88 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -767,7 +767,12 @@ static int get_target_version(struct file *filp, struct dm_ioctl *param, size_t static int check_name(const char *name) { if (strchr(name, '/')) { - DMERR("invalid device name"); + DMERR("device name cannot contain '/'"); + return -EINVAL; + } + + if (strcmp(name, DM_CONTROL_NODE) == 0) { + DMERR("device name cannot be \"%s\"", DM_CONTROL_NODE); return -EINVAL; }