From patchwork Fri Jun 2 15:26:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 102623 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1118084vqr; Fri, 2 Jun 2023 08:39:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6D/aV7gLb1+LSkgWNDFpd0OTY0wU1+XSyIA0KGTrcEzkTVIvCxZ5yCLUBFsF/3WgVLOA00 X-Received: by 2002:a05:6358:3a19:b0:127:c640:5c05 with SMTP id g25-20020a0563583a1900b00127c6405c05mr7817434rwe.13.1685720366416; Fri, 02 Jun 2023 08:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685720366; cv=none; d=google.com; s=arc-20160816; b=r4/XVWiMTJg3YGjhXW3UYC7cGj6IK0HvRe2pPePf3ueaHzm5KEupW4t/zgTm4on10O jWZl2v4pRcE3ZyLR/pe8bxSVIPLT/fznYsf7FHpTx3DKAShXpuopnTaPX3OTnDy0FQmj xD+G+G3y3h8Jzx14xM6wQE+pNaUxTIaB0OZIByWgsIVZenKNmRqU2OLlxx6VB7zo/mNf gtbdi7iccufeWL9gw6qQvsZ9wA3c8ART+6wyrjq2vRrm2UTi30DQYX0vgH99fmwbIbNk A4Y6UhNCnqUuQa0jnCanOf9PHQDn+Mc8k1atbx/gW0U8dtjHnSCJ5RNjZlOlUMuWQaEG aw5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=3T6UXLK3EsXDF6+uvRiO5BPvcjJvRpCunMRH973U/yc=; b=Suqfor9i3V5CvpNkWNeu3Cpt9h/fuvixZt/RYHMXz8eyAT4gysagHlUAJ+V50OASvy r3Wz+WJDodkAdvcQlYEdpDB4D9/ShX3qzvjLC0qDJFRUmajNiVcnv8qvBxTsPXHnnmw/ jR18Ce+rURRCYXMsJltQM+SZ9yxM6Ig6SUu6SqBj9dqRMEkByYcdn7eGJaGSBLgNzTNL 51rUDsPIAEowNP/1uW9amXKqk0JBsVojnEx9cNuV8QzbALA9dWBSYLZgAIXeef0x8L8w ShI+wrb0lTQ17EIa50LNn2bLNpXpH2MaQzPAK0q9Id8hEoNx94R4Y7JBdKYtxqkTjsh0 ocew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=IWbv5cJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot5-20020a17090b3b4500b0024df0aab0e2si1281016pjb.8.2023.06.02.08.39.14; Fri, 02 Jun 2023 08:39:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=IWbv5cJr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236642AbjFBP1S (ORCPT + 99 others); Fri, 2 Jun 2023 11:27:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236645AbjFBP0s (ORCPT ); Fri, 2 Jun 2023 11:26:48 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B301B7; Fri, 2 Jun 2023 08:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3T6UXLK3EsXDF6+uvRiO5BPvcjJvRpCunMRH973U/yc=; b=IWbv5cJrEbvgdh9mUvH5bINuFD 2oHO1BEH+LOzjgWhDXigNyh3JmOtiO2697y3ULeIG5DrsRN6C+atDqvKThX7BUIpf/CdYyV18/u9H ClObCmJZ2RaGZfDsVsNDe+nA62TKqtoXF2RHhswEFbn6jEjYFmTaymZ6Oal8jDPqcNmQ=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:50948 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1q56fp-0008Hq-Os; Fri, 02 Jun 2023 11:26:42 -0400 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, linux-gpio@vger.kernel.org, Hugo Villeneuve , Lech Perczak Date: Fri, 2 Jun 2023 11:26:24 -0400 Message-Id: <20230602152626.284324-9-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230602152626.284324-1-hugo@hugovil.com> References: <20230602152626.284324-1-hugo@hugovil.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v7 8/9] serial: sc16is7xx: add post reset delay X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767605918684975276?= X-GMAIL-MSGID: =?utf-8?q?1767605918684975276?= From: Hugo Villeneuve Make sure we wait at least 3us before initiating communication with the device after reset. Signed-off-by: Hugo Villeneuve Reviewed-by: Lech Perczak Tested-by: Lech Perczak --- drivers/tty/serial/sc16is7xx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 9eef7fcd8863..6a8d594a90c8 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1522,6 +1522,12 @@ static int sc16is7xx_probe(struct device *dev, regmap_write(s->regmap, SC16IS7XX_IOCONTROL_REG << SC16IS7XX_REG_SHIFT, SC16IS7XX_IOCONTROL_SRESET_BIT); + /* + * After reset, the host must wait at least 3us before initializing a + * communication with the device. + */ + usleep_range(5, 10); + for (i = 0; i < devtype->nr_uart; ++i) { s->p[i].line = i; /* Initialize port data */