diff mbox series

usb: typec: mux: Fix extraneous semicolon

Message ID 20230601213342.3334659-1-arnd@kernel.org
State New
Headers
Series usb: typec: mux: Fix extraneous semicolon |

Commit Message

Arnd Bergmann June 1, 2023, 9:33 p.m. UTC 
  From: Arnd Bergmann <arnd@arndb.de>

A recent patch introduced a typo in the fwnode_typec_mux_get()
stub function that causes a build failure in some configurations:

In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token
include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]

Fixes: 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/usb/typec_mux.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH June 2, 2023, 7:45 a.m. UTC | #1 
On Thu, Jun 01, 2023 at 11:33:37PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A recent patch introduced a typo in the fwnode_typec_mux_get()
> stub function that causes a build failure in some configurations:
> 
> In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
> include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token
> include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]
> 
> Fixes: 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/usb/typec_mux.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
> index 11bfa314529fd..2489a7857d8e1 100644
> --- a/include/linux/usb/typec_mux.h
> +++ b/include/linux/usb/typec_mux.h
> @@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
>  
>  #else
>  
> -static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
> +static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
>  {
>  	return NULL;
>  }
> -- 
> 2.39.2
> 

Should already be fixed in my tree, and in the next linux-next, sorry.

greg k-h
diff mbox series

Patch

diff --git a/include/linux/usb/typec_mux.h b/include/linux/usb/typec_mux.h
index 11bfa314529fd..2489a7857d8e1 100644
--- a/include/linux/usb/typec_mux.h
+++ b/include/linux/usb/typec_mux.h
@@ -73,7 +73,7 @@  void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
 
 #else
 
-static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
+static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
 {
 	return NULL;
 }