From patchwork Thu Jun 1 21:31:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102209 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp632630vqr; Thu, 1 Jun 2023 14:49:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6PWmdnRYpIllx9HVh7OaD2VdC+edh4asOZ2iIziMM2n3IRAup3tft8H9yY19sZPX3WbT9J X-Received: by 2002:a17:903:228f:b0:1ae:dadc:ca2a with SMTP id b15-20020a170903228f00b001aedadcca2amr559036plh.57.1685656193213; Thu, 01 Jun 2023 14:49:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685656193; cv=none; d=google.com; s=arc-20160816; b=ukR0eKPtiuissxJP0S9TTZ8hyDrnZyHpC8o4b9vjPNs3CSPJdoWFI0uSSXZXgFrj2E No3Bxh8PEXWSICl2sbYxBUqaxZV7mmUb4QyxFQOnxmTJb7K4k+orVbE7kQagvUcHbSH9 iYwePUexH1nXN2sPIZkdBSyigyzy7AGGBavqvm8GHEFnE22tSWA/tdvgDMRy3fXyBaRq jOIp+Agz4+A8gwlaZt/vRSGhfKHbs3IsI34rGcz5zF/3ZFxRJUpitfBU/2VUly1vhlee DEjQcF1g84RLbceMGFKj4CUhfMfKd7FggxbyFhgVx+yE8onqzkLYll/vYFkNr1IAEMeP IcPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FTvh2mSgeHZO+J3unty8/WFjlld+YImC2U6CFj127Kg=; b=vGLPEVa1htAolWlUOoduCZKZtrEecLDB5Cy1yEgIAZ8mcbLLESS6n3Bs2rRBIXJLvu mRRDZxPz7PlNGmjWDfYx6GYrO2sW2+PBHfz3ONjvUmO+Loj86qnkHrH0741oSDKY88mH QuSSsPBk85Ue/OFi4F+ZsC+dSDvPRxC+KDiiTchuOIRotT6XM8apEtD+77uZDKHH2MAB maFATKNJXymOCwqrxJUODdgl4NWtbN25w932Pdz3BtIaBc8hRfX6lNlZWoTemVK8ixQ6 3p6YNEqHmBzGvV+R9CYRAVwX1Q4ZfZO5z99ip6SZf9BAUa9SDNzX/+TVGu4ln/otU4M+ 3+aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VDx29Is+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m5-20020a170902db8500b001b03e56a51dsi1617456pld.29.2023.06.01.14.49.38; Thu, 01 Jun 2023 14:49:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VDx29Is+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232356AbjFAVbW (ORCPT + 99 others); Thu, 1 Jun 2023 17:31:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjFAVbU (ORCPT ); Thu, 1 Jun 2023 17:31:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8BE184 for ; Thu, 1 Jun 2023 14:31:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DA26649F3 for ; Thu, 1 Jun 2023 21:31:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DD57C433D2; Thu, 1 Jun 2023 21:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685655078; bh=Rq/YPhUrxxmon4lsDaGRDkAmNIYRrnC5b1pXLnZ3MbA=; h=From:To:Cc:Subject:Date:From; b=VDx29Is+heLSHZendXg04+AgJJOfhzDRchuOF/qJ5fqzXQshWgSpyhA8H50/huNLd pINbTUfx8y2pP0q+Eq7t1xM2QbJzMb8sxEw+NNdEolt4WXQV4GkxatzEq0TOphHQLa jKwieLVkqsEVui4bdtJQkm0vunj/GtbUkKhRMeqJqhwejXt0ukzlRLgG901gefA9YP CAEIYvrlzF6Rlt09Q4Re1gsNsgnQhlpXMvZ61u1Zk4xTSRr8pO5hsMELLKh0JqRFMc D7gFui3Uwamc6waP115/MJzbVl0PBzIGsbZExrTFPSvVJAk04PEU+g3h42Df9t6PrE eUpfOTnW2D2OA== From: Arnd Bergmann To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency Date: Thu, 1 Jun 2023 23:31:04 +0200 Message-Id: <20230601213111.3182893-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767538628699448267?= X-GMAIL-MSGID: =?utf-8?q?1767538628699448267?= From: Arnd Bergmann Without LED triggers, the driver now fails to build: drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds': drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has no member named 'hw_control_is_supported' 403 | port_led->cdev.hw_control_is_supported = qca8k_cled_hw_control_is_supported; | ^ There is a mix of 'depends on' and 'select' for LEDS_TRIGGERS, so it's not clear what we should use here, but in general using 'depends on' causes fewer problems, so use that. Fixes: e0256648c831a ("net: dsa: qca8k: implement hw_control ops") Signed-off-by: Arnd Bergmann --- drivers/net/dsa/qca/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/qca/Kconfig b/drivers/net/dsa/qca/Kconfig index 4347b42c50fd2..de9da469908bc 100644 --- a/drivers/net/dsa/qca/Kconfig +++ b/drivers/net/dsa/qca/Kconfig @@ -20,6 +20,7 @@ config NET_DSA_QCA8K_LEDS_SUPPORT bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" depends on NET_DSA_QCA8K depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K + depends on LEDS_TRIGGERS help This enabled support for LEDs present on the Qualcomm Atheros QCA8K Ethernet switch chips.