| Message ID | 20230601201844.3739926-3-hugo@hugovil.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp596828vqr;
Thu, 1 Jun 2023 13:32:53 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ7NcCHm/SigNyzE0iVcOaopIk28QCgaibPxAyLxk2oTaDjx98nsIfjeRtA2QGD7dNdBOcSf
X-Received: by 2002:a05:6a21:32a2:b0:110:f65a:139d with SMTP id
yt34-20020a056a2132a200b00110f65a139dmr8832163pzb.44.1685651572643;
Thu, 01 Jun 2023 13:32:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1685651572; cv=none;
d=google.com; s=arc-20160816;
b=jzSet83pQyajhn3sw82h2slsL8DdqoJ5HTa6ShScgYnV6iPND/1KAXdnlFiZFIZ+qv
e1qk+M+WLvKMdk++TFLt71CNZIhoDSIRTnC3XWXfim+m8Rt9uTwneZnC0mhHEIThy4Xb
VwqFwZdfyAWvqU+1/Osk2HVV+wTgTwetmnXRPkgOQXL71S1JlBiTI5GB8yipzMHTwBdH
i2Fg9FddrssuNo9yLuljLnbKQrDOa6vpbj0J4Rh0gKe1A4df/Gc+uMT+4jGMI/yjBnqr
d8wymhvwqIj4lixOQeexOK5s/x6PpXCeartuJHfzUMBOYUeMkBZTxW6hvuWE58PO3rYv
XZ3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:subject:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:cc:to:from:dkim-signature;
bh=T/ybH+luXFJtRUNLsANdxNj5MlosRcBXIwuB3tKL/mQ=;
b=yhfLG7qO5NjeQFZJ8m9nNtm7JMLo5qaaeXGQDnfJ/CQEXwCw2GfOFwylrQ1LJ60VuK
vFVzWew4WK2/AH2XT+FbMdFqobeRwRIA0jevhqoEAh+6aTB0MubTYI2/eqnh6sVLir0b
budrzX6dbLj3OwxGj3KsREOv8wNWVQt4tyHlXMHPiilLhALhzJeu2/RlFBiz+eFhf+oz
lrUKe5vLUhha8ZE09yhY967vguRxoG7A45pXgvLYqgZEiMag1QmBjjq81b/nX6VGOWqV
/oXyh3lYTt8cCfzI3kUbkzjbV+Btr/B77aDg0nwCpgMBYvvWPN0SVMje99vEvcEyZulm
se0w==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@hugovil.com header.s=x header.b=XBVYQPn5;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
b5-20020a63eb45000000b005346bd7dee9si3390134pgk.682.2023.06.01.13.32.40;
Thu, 01 Jun 2023 13:32:52 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@hugovil.com header.s=x header.b=XBVYQPn5;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229884AbjFAUTH (ORCPT <rfc822;limurcpp@gmail.com> + 99 others);
Thu, 1 Jun 2023 16:19:07 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48248 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231520AbjFAUS6 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 1 Jun 2023 16:18:58 -0400
Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBF65D1;
Thu, 1 Jun 2023 13:18:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com
; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=T/ybH+luXFJtRUNLsANdxNj5MlosRcBXIwuB3tKL/mQ=;
b=XBVYQPn54+UaXJWMEcflRq65nw
X1YXvZHzNzS78BamaYD7NhzYDX+Sl0Kr16oGgpC0ETGhgH3ppum1Q6V+GagI+qxUjQysjs9SkzSXm
skLeYA9l2lRGkkUXNMMQIbY1gz0BN+mvrGMAJ/6K7pEeXKGGix2b8xb5eaBHnYQ7LKYA=;
Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:39204
helo=pettiford.lan)
by mail.hugovil.com with esmtpa (Exim 4.92)
(envelope-from <hugo@hugovil.com>)
id 1q4ol0-000686-4g; Thu, 01 Jun 2023 16:18:50 -0400
From: Hugo Villeneuve <hugo@hugovil.com>
To: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com
Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, hugo@hugovil.com,
linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org, Lech Perczak <lech.perczak@camlingroup.com>
Date: Thu, 1 Jun 2023 16:18:37 -0400
Message-Id: <20230601201844.3739926-3-hugo@hugovil.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230601201844.3739926-1-hugo@hugovil.com>
References: <20230601201844.3739926-1-hugo@hugovil.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 70.80.174.168
X-SA-Exim-Mail-From: hugo@hugovil.com
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
X-Spam-Level:
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
Subject: [PATCH v6 2/9] serial: sc16is7xx: mark IOCONTROL register as volatile
X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000)
X-SA-Exim-Scanned: Yes (on mail.hugovil.com)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1767533783176317065?=
X-GMAIL-MSGID: =?utf-8?q?1767533783176317065?=
|
| Series |
serial: sc16is7xx: fix GPIO regression and rs485 improvements
|
|
Commit Message
Hugo Villeneuve
June 1, 2023, 8:18 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Bit SRESET (3) is cleared when a reset operation is completed. Having the IOCONTROL register as non-volatile will always read SRESET as 1, which is incorrect. Also, if IOCONTROL register is not a volatile register, the upcoming patch "serial: sc16is7xx: fix regression with GPIO configuration" doesn't work when setting some shared GPIO lines as modem control lines. Therefore mark IOCONTROL register as a volatile register. Cc: <stable@vger.kernel.org> # 6.1.x Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com> Tested-by: Lech Perczak <lech.perczak@camlingroup.com> --- drivers/tty/serial/sc16is7xx.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index faa51a58671f..0c903d44429c 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -488,6 +488,7 @@ static bool sc16is7xx_regmap_volatile(struct device *dev, unsigned int reg) case SC16IS7XX_TXLVL_REG: case SC16IS7XX_RXLVL_REG: case SC16IS7XX_IOSTATE_REG: + case SC16IS7XX_IOCONTROL_REG: return true; default: break;