From patchwork Thu Jun 1 16:16:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 102077 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp462614vqr; Thu, 1 Jun 2023 09:36:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dxMnucBw9zAAKolOo2CpPIhoAV18OPsfs8+CcvwxFsFwtPG+XJRYvt6J4nvo1tCJ2seso X-Received: by 2002:a17:903:124a:b0:1ae:73b8:747e with SMTP id u10-20020a170903124a00b001ae73b8747emr7601395plh.31.1685637404211; Thu, 01 Jun 2023 09:36:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685637404; cv=none; d=google.com; s=arc-20160816; b=ppM8+ttevEY1EUAfPl/4Aqo/Hm1RICmqVvw6K8qYUG21okSQT+Iakk/gNPUrQeZ08o hSyFJzu/V3pVM6d0VsLmLo1hNbhANH/2+qwOzaGXsFOYobloCufRggf4fVhn8ncLbDEj cHLsCTWlS44Q0JeQRCTYsS0SEgIDppjNzuvtH/RPJ1zP3ienpE/K8FhvuDV3TvQjC8r0 cT3MC7w2o2NZefoFqipzSFTtYxCDSU5Svi0Lu3V8LY5ogLFJd6///qSdoO4ulrDgThYF kOuzZfMmtbjZyPtJeQQ0CHl1anKfHeCr/lQuZJdSnrmnZlmtHB19sJdpr3KE1Q29k2bC ASVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WVl77aDZPiiy/Xm2MeadfaVYJBvh09LDGtM6Q0gPMuI=; b=UOBaDgrg1KK53ffoXtATeKV403BxggnKj0yVs2ioI//oRHPicMAYU7sihlSb+Ab2la 2hQ0h08cHyYAUR52/dKZd0tEO6AAxbceFyraazt8rJzZm2uhID/zJqcFyI5jZjaUBSn9 Pw3YNO+CX+JKQxXAOoNin1cDppCxOJlLFmKj64EZP6R4nNMgEeNzVIM3S0EIS4uB1sX7 50xDxnYH+Y7ZZaGBKMiHg1/gqYJsbJLsSOIc4amU3rS8UK+jEttES3Z5U6+9Efn9Iwq8 SkBtvkH8x5pWV0ZsSSaSs+l7AgwCGlBY6I0IBe2LNncGmo94KWDyuckNwJldSzTdl9LL 8mSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=b9MVpmVj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k18-20020a170902c41200b001aaff31bcccsi3154398plk.124.2023.06.01.09.36.28; Thu, 01 Jun 2023 09:36:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=b9MVpmVj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbjFAQQ7 (ORCPT + 99 others); Thu, 1 Jun 2023 12:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231191AbjFAQQu (ORCPT ); Thu, 1 Jun 2023 12:16:50 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79FE91A8 for ; Thu, 1 Jun 2023 09:16:47 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 351BpAhP020645; Thu, 1 Jun 2023 11:16:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=WVl77aDZPiiy/Xm2MeadfaVYJBvh09LDGtM6Q0gPMuI=; b=b9MVpmVjFCP1W+VRojkkvlCYHS0nH3raAy/dPqlNwsNtapxNZYsvU5SaZzEAXYd7K5gw FZ7Hma7K7r6K2eOedz/ZIKgpQUwPJk1727uNeyElo8Krro4/NSn/jssjkBSiwsUhhwbZ 01Ue0A7BpglNDQocs4fTxfHQek6V+REulUvHUdVIdrExINHLsuJg1yd+npmhtghZfsIQ I2pQ5vPMc9tPVB+mSGjcecnQnR1xhsv5fBriOXzml7pkxTgq+ktZ8xdBLVz4g3dlzAM7 gXdyoWe6mVHKS3XR8/L8TvfmHSvQu/z33Wd9e2ns7myQ7Jpe/PEN25L7nIMPwBay2zdB ug== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3que9mxmbs-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 11:16:25 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 1 Jun 2023 17:16:22 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 1 Jun 2023 17:16:22 +0100 Received: from algalon.ad.cirrus.com (algalon.ad.cirrus.com [198.90.251.122]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id AEFBF468; Thu, 1 Jun 2023 16:16:22 +0000 (UTC) From: Charles Keepax To: CC: , , , , , Subject: [PATCH 1/4] soundwire: stream: Add missing clear of alloc_slave_rt Date: Thu, 1 Jun 2023 17:16:19 +0100 Message-ID: <20230601161622.1808135-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: _k6sMXl3nmUC_5yfSH5nMaB7j9PP9N91 X-Proofpoint-ORIG-GUID: _k6sMXl3nmUC_5yfSH5nMaB7j9PP9N91 X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767518927048417815?= X-GMAIL-MSGID: =?utf-8?q?1767518927048417815?= The current path that skips allocating the slave runtime does not clear the alloc_slave_rt flag, this is clearly incorrect. Add the missing clear, so the runtime won't be erroneously cleaned up. Signed-off-by: Charles Keepax Reviewed-by: Pierre-Louis Bossart --- drivers/soundwire/stream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c index c2191c07442b0..379228f221869 100644 --- a/drivers/soundwire/stream.c +++ b/drivers/soundwire/stream.c @@ -2021,8 +2021,10 @@ int sdw_stream_add_slave(struct sdw_slave *slave, skip_alloc_master_rt: s_rt = sdw_slave_rt_find(slave, stream); - if (s_rt) + if (s_rt) { + alloc_slave_rt = false; goto skip_alloc_slave_rt; + } s_rt = sdw_slave_rt_alloc(slave, m_rt); if (!s_rt) {