Message ID | 20230601101451.357662-2-o.rempel@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp200451vqr; Thu, 1 Jun 2023 03:31:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ56FzHGA/pA1fowSqRuISsZ9p0zBT6PguWpq+J6C+AylC7LEC8siNtiTofYazQ5v6KdAlcD X-Received: by 2002:a05:6a00:1988:b0:63d:2d99:2e7c with SMTP id d8-20020a056a00198800b0063d2d992e7cmr10239151pfl.0.1685615463645; Thu, 01 Jun 2023 03:31:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685615463; cv=none; d=google.com; s=arc-20160816; b=ZEe1h6WyxuWhT79798nQLBncvp2d18kx6xBD5itOJvShSmIVufAqVejNOnt6V1AyPx aWD03ZhDPjkhAe76+ZiA8QYTkMD4zIpwzNPqOw9pI8ErmaeyLsxooUNPeD3qMngN6xEe D7t+FhFcwabpv8x/YpyWSNqICyB/RKZZQZA7jzRQs43QAfNe0QqOeFwSA0dcrbuUhxch WFwkAFypQQutOcw3ojac3qBmN3OzW/k7X9CoVCC0vRz4HmGq8hGn5aKRyNOtR7PkFNgV y+F4pic8bF/zKCfKPdPbpNfbob6zoC9CUaIUrWbXGRwjCAGzoGt+81YDybCyu5nq9NYc kvCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TybGBEwslhVEtamzLkaYtnTKN6lDaLVZ/pq+lmgNHE4=; b=BH8PfrQVJIFDevnuzRrzC0Bfu15Pdiuo41fHZ/FAVR9BNVQGtomnM40o4viOVdAqGE 1fZKim+gcjoHgTEPJDjPCOFOfDCUSBi9hxAqfyBS5fj26QSxqIzBDGWYTget21ciiso5 8mdaiUoHadRs2tkeixFQm+pXTr+R2RgSuGRwJErI2ekk/bWh8W+9cTkWqNwjSFUAfx3Y JZxxBrb5OqPohkMAMTm+X2sUwctVxlTa/JigR1ruZeGBWD9dJ2q+uWzwNvs2DuRDqueU VssJ7t+N4IJTMyhXTdNlt02vEvYOZRmzf91HQMVUTrmDYFBLnA3w4P1qicRmAwhRAkZe OFiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k26-20020a637b5a000000b00530b7f4243dsi2608418pgn.191.2023.06.01.03.30.49; Thu, 01 Jun 2023 03:31:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233510AbjFAKTS (ORCPT <rfc822;limurcpp@gmail.com> + 99 others); Thu, 1 Jun 2023 06:19:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233208AbjFAKSb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 1 Jun 2023 06:18:31 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A62B1FF7 for <linux-kernel@vger.kernel.org>; Thu, 1 Jun 2023 03:15:55 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ore@pengutronix.de>) id 1q4fKZ-0004WA-5h; Thu, 01 Jun 2023 12:14:55 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1q4fKX-004KWB-JG; Thu, 01 Jun 2023 12:14:53 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1q4fKW-001V3d-J1; Thu, 01 Jun 2023 12:14:52 +0200 From: Oleksij Rempel <o.rempel@pengutronix.de> To: Abel Vesa <abelvesa@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Ulf Hansson <ulf.hansson@linaro.org> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, Peng Fan <peng.fan@nxp.com>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Michael Trimarchi <michael@amarulasolutions.com>, Mark Brown <broonie@kernel.org>, Dario Binacchi <dario.binacchi@amarulasolutions.com>, Anson Huang <Anson.Huang@nxp.com>, Marek Vasut <marex@denx.de>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org Subject: [PATCH v1 1/7] dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support Date: Thu, 1 Jun 2023 12:14:45 +0200 Message-Id: <20230601101451.357662-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230601101451.357662-1-o.rempel@pengutronix.de> References: <20230601101451.357662-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767495920402419623?= X-GMAIL-MSGID: =?utf-8?q?1767495920402419623?= |
Series |
Add support for various features to i.MX6 bindings
|
|
Commit Message
Oleksij Rempel
June 1, 2023, 10:14 a.m. UTC
Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
the fsl-imx-esdhc.yaml file. This is required to match the compatible
strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
commit addresses the following dtbs_check warning:
imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
'nxp,s32g2-usdhc']
From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On Thu, Jun 01, 2023 at 12:14:45PM +0200, Oleksij Rempel wrote: > Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in > the fsl-imx-esdhc.yaml file. This is required to match the compatible > strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This > commit addresses the following dtbs_check warning: > imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed, > one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long > 'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc', > 'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc', > 'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc', > 'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc', > 'nxp,s32g2-usdhc'] > From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > index fbfd822b9270..090e781705d3 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > @@ -30,6 +30,7 @@ properties: > - fsl,imx6q-usdhc > - fsl,imx6sl-usdhc > - fsl,imx6sx-usdhc > + - fsl,imx6ul-usdhc How come this gets added as a standalone compatible _and_ one that should fall back to imx6sx? > - fsl,imx7d-usdhc > - fsl,imx7ulp-usdhc > - fsl,imx8mm-usdhc > @@ -42,6 +43,7 @@ properties: > - enum: > - fsl,imx6sll-usdhc > - fsl,imx6ull-usdhc > + - fsl,imx6ul-usdhc > - const: fsl,imx6sx-usdhc > - items: > - const: fsl,imx7d-usdhc > -- > 2.39.2 >
On Thu, Jun 01, 2023 at 07:18:31PM +0100, Conor Dooley wrote: > On Thu, Jun 01, 2023 at 12:14:45PM +0200, Oleksij Rempel wrote: > > Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in > > the fsl-imx-esdhc.yaml file. This is required to match the compatible > > strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This > > commit addresses the following dtbs_check warning: > > imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed, > > one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long > > 'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc', > > 'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc', > > 'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc', > > 'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc', > > 'nxp,s32g2-usdhc'] > > From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index fbfd822b9270..090e781705d3 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -30,6 +30,7 @@ properties: > > - fsl,imx6q-usdhc > > - fsl,imx6sl-usdhc > > - fsl,imx6sx-usdhc > > + - fsl,imx6ul-usdhc > > How come this gets added as a standalone compatible _and_ one that > should fall back to imx6sx? Whoops, sent too soon. I meant to point out that the only user in-tree uses the fallback to imx6sx. Cheers, Conor. > > - fsl,imx7d-usdhc > > - fsl,imx7ulp-usdhc > > - fsl,imx8mm-usdhc > > @@ -42,6 +43,7 @@ properties: > > - enum: > > - fsl,imx6sll-usdhc > > - fsl,imx6ull-usdhc > > + - fsl,imx6ul-usdhc > > - const: fsl,imx6sx-usdhc > > - items: > > - const: fsl,imx7d-usdhc > > -- > > 2.39.2 > >
On 01/06/2023 12:14, Oleksij Rempel wrote: > Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in > the fsl-imx-esdhc.yaml file. This is required to match the compatible > strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This > commit addresses the following dtbs_check warning: > imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed, > one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long > 'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc', > 'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc', > 'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc', > 'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc', > 'nxp,s32g2-usdhc'] > From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml Except what Conor wrote, please don't wrap that much the error log - it is unreadable. Trim it, remove unneeded parts and keep some decent one/two lines even if it exceeds the commit msg. This applies to other patches as well. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml index fbfd822b9270..090e781705d3 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml @@ -30,6 +30,7 @@ properties: - fsl,imx6q-usdhc - fsl,imx6sl-usdhc - fsl,imx6sx-usdhc + - fsl,imx6ul-usdhc - fsl,imx7d-usdhc - fsl,imx7ulp-usdhc - fsl,imx8mm-usdhc @@ -42,6 +43,7 @@ properties: - enum: - fsl,imx6sll-usdhc - fsl,imx6ull-usdhc + - fsl,imx6ul-usdhc - const: fsl,imx6sx-usdhc - items: - const: fsl,imx7d-usdhc