diff mbox series

[1/2] regmap: regmap-irq: Move handle_post_irq to before pm_runtime_put

Message ID 20230601101036.1499612-1-ckeepax@opensource.cirrus.com
State New
Headers
Series [1/2] regmap: regmap-irq: Move handle_post_irq to before pm_runtime_put |

Commit Message

Charles Keepax June 1, 2023, 10:10 a.m. UTC 
  Typically handle_post_irq is going to be used to manage some
additional chip specific hardware operations required on each IRQ,
these are very likely to want the chip to be resumed. For example the
current in tree user max77620 uses this to toggle a global mask bit,
which would obviously want the device resumed. It is worth noting this
device does not specify the runtime_pm flag in regmap_irq_chip, so
there is no actual issue.

Move the callback to before the pm_runtime_put, so it will be called
whilst the device is still resumed.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
 drivers/base/regmap/regmap-irq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Mark Brown June 1, 2023, 1:40 p.m. UTC | #1 
On Thu, 01 Jun 2023 11:10:35 +0100, Charles Keepax wrote:
> Typically handle_post_irq is going to be used to manage some
> additional chip specific hardware operations required on each IRQ,
> these are very likely to want the chip to be resumed. For example the
> current in tree user max77620 uses this to toggle a global mask bit,
> which would obviously want the device resumed. It is worth noting this
> device does not specify the runtime_pm flag in regmap_irq_chip, so
> there is no actual issue.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/2] regmap: regmap-irq: Move handle_post_irq to before pm_runtime_put
      commit: 02534c8e967b51940ae7c0cd99befe216f1c2c8d
[2/2] regmap: Add missing cache_only checks
      commit: 99e8dd39f34333d745e6c220be5d166e85214e6c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index 330da5d6c8c3a..ced0dcf86e0bf 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -502,12 +502,12 @@  static irqreturn_t regmap_irq_thread(int irq, void *d)
 	}
 
 exit:
-	if (chip->runtime_pm)
-		pm_runtime_put(map->dev);
-
 	if (chip->handle_post_irq)
 		chip->handle_post_irq(chip->irq_drv_data);
 
+	if (chip->runtime_pm)
+		pm_runtime_put(map->dev);
+
 	if (handled)
 		return IRQ_HANDLED;
 	else