From patchwork Wed May 31 22:08:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 101602 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3215605vqr; Wed, 31 May 2023 15:26:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Wmn4E+gudgdYHXq/Q3RKCURIn32q+6j07/jjo3jHLnbuqcdgA2hT+RyBA5y6Gq/IWEQap X-Received: by 2002:a05:6808:2220:b0:399:8529:6726 with SMTP id bd32-20020a056808222000b0039985296726mr7457676oib.51.1685572018356; Wed, 31 May 2023 15:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685572018; cv=none; d=google.com; s=arc-20160816; b=r5qVD4rlTKP/zFmrMim0QVY9sQ3Su01NBDyyWv9N7lCBPnE1zISfxBi91CfD4LXBru 5JQRYvGzy6H3Jue0QKEdHfRGNJvfHGxFSbLO1YrAxJI8JC+RC1F2TA6mvp0n7NZR17qJ zcyPjgAzZa8K1l2aBvL6svoJfxpHNZMvPUSWLqzUtdUc9SkixgA90tuCtZ4gQSRYsw15 vt4WclyXa5YQ91oFMapE1akPN8ytvbfNvA+8xZp2Z4VgBnNa6x4zXQOFiZwvdOScCTz0 NfSynrWBAeVW1Rqpzxo4IPDH1vh1862031lJLihgEYthCMlWNXeObIJ6b/q/zIC/z2+m WYxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hVpzQtIDQfKWEqbseo+tZ+eEsBzkT6BTR9cKFnwSYiE=; b=yr+ecPXPnizxwSutpOiMukjFAR2lLdCI31DJcWgBRXJndZ4GCRfwrZs3vNos9lqUVr Y5gXoz/zOfekrJyrX8YPXqIg7qBTmcdGJBlHr7E59rkK11iFLZ/DZUXo0nz3W38GfXLB mQB8InE/a7FeyQmxBUmVAzKMs0rZrSekFUEkqXe/dFjVrB48Ua4AaZITcZPuKiDrySNu YsvP/tvrVIygQTkR7i/WApFNCsMjLZmgUy6zxRX39IP02PccQffylMhxtCwbb2Mh/J4M uaop54DKcXePwJDy1CTpHfDr/9hNsFWcGxPcP15tOQgMhmXuNzYuVnqpV/YG2I2wjaHI QdEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=UVc+juOd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a170903110e00b001aaf78f7a95si1749132plh.101.2023.05.31.15.26.44; Wed, 31 May 2023 15:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=UVc+juOd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbjEaWIu (ORCPT + 99 others); Wed, 31 May 2023 18:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbjEaWIm (ORCPT ); Wed, 31 May 2023 18:08:42 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61D38E41 for ; Wed, 31 May 2023 15:08:21 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-6260de7cfaeso2198446d6.2 for ; Wed, 31 May 2023 15:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1685570900; x=1688162900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hVpzQtIDQfKWEqbseo+tZ+eEsBzkT6BTR9cKFnwSYiE=; b=UVc+juOdhvc+cdjx5ehHJJwwP68jGUuabxnGl2sSfw5+c3rM6PEEz7zmzj6t/Ykjlz IEsXCnKiFlo+h2JixjtD4OcEGGHRU/PJBz4uJQNMcO2ZId0sz4Pi773QRZBHIET4s7rS u0CUYL69ZSD7t8s8GCIDl4lvJdB5gvJ7I/eFc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685570900; x=1688162900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hVpzQtIDQfKWEqbseo+tZ+eEsBzkT6BTR9cKFnwSYiE=; b=PV8l5PDrEtOb1lgDDGuWGt0YfoyJXsoJY6OEPo1d2qu8u+W26yTVdS3wkcDKMfZLBD Fbum5qRSWZh86sjcIP4NtWM7cv3FfOQ/WbL8rsTMt6zq9ack00q/Be3FbY1Hu5axbCOb c6Nf9lWG6oFmEvwvVLqcFEWfoSVUtNXNXbOBD7q7K/jY8EmzlpvcN0wjwwV4IgKsyErh Tj3EfaNGwzHXBcXR36EcABDyjB29jp+VexCPc8q2hurcLjf+1z1rbb0MSLMwYLwx0TLv kyezXcpAJy3mRdzFDFpSCZ1xHCkc2UBraJRs7RQNN84yAbhuVuLldBVZIftHZS8SS/M3 R0lg== X-Gm-Message-State: AC+VfDyRFtSxIU70rwN4XkYWd0o3V7bR9V/byxkDMs2x5U1+mhVAobAf 2h/tBHgYzebFL4pxRWEA779BQXZOPUW4q3P7ShI= X-Received: by 2002:a05:6214:1ccc:b0:625:1c04:6761 with SMTP id g12-20020a0562141ccc00b006251c046761mr8116673qvd.27.1685570899912; Wed, 31 May 2023 15:08:19 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id f2-20020ac87f02000000b003f6b0f4126fsm6666172qtk.8.2023.05.31.15.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 15:08:19 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra , Vineeth Pillai Subject: [PATCH v4 3/7] selftests: mm: Fix failure case when new remap region was not found Date: Wed, 31 May 2023 22:08:03 +0000 Message-ID: <20230531220807.2048037-4-joel@joelfernandes.org> X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog In-Reply-To: <20230531220807.2048037-1-joel@joelfernandes.org> References: <20230531220807.2048037-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767450364544858006?= X-GMAIL-MSGID: =?utf-8?q?1767450364544858006?= When a valid remap region could not be found, the source mapping is not cleaned up. Fix the goto statement such that the clean up happens. Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..6822d657f589 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (addr + c.dest_alignment < addr) { ksft_print_msg("Couldn't find a valid region to remap to\n"); ret = -1; - goto out; + goto clean_up_src; } addr += c.dest_alignment; }