From patchwork Wed May 31 10:17:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 101340 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2771560vqr; Wed, 31 May 2023 03:25:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5QmYBfFGz3Repf6m3aHmkjHbnuP+Fd1sJpERLPBn30fizesbgW9hVYHpVrAue9t3m5sdzn X-Received: by 2002:a92:cb43:0:b0:338:b887:b674 with SMTP id f3-20020a92cb43000000b00338b887b674mr2064952ilq.2.1685528716002; Wed, 31 May 2023 03:25:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685528715; cv=none; d=google.com; s=arc-20160816; b=qmjb6oTTG+6h1gAmADrhBxG0WkZKfiiyvVS8BbN3k5eL0Uk8hu8vyu2WEyDBdMPXsL LGyB32kiXFgB64vi6O0qXUxerfwrQfvcSqg9dhGpvAvTZFVMZ1XDGtBHohdwwnaGBrRz 9m9VJREpSA0PV40mOViTClnDstmbcozTdSjTdKm6+zPi478DN1CU0J4aKSMqj+JS84Jc jZFigggs/ruzELrMtu9UqaU3KtbbabMvJzeHfceaRwWGCWP4CeoEDuzucL2fpry/plKe UNB6oqqU/f6L9sPfD4+M5zQfgyIEroA6108Fhz95i8zg4OZ1yYNOg4c/DAzIhR36JCkv vr+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XI1HfNRvy5Oglov6uWmtpOhIBIXFf6JlxohySTgRLw4=; b=GFbJG9SOkqcrHLnwlXbEB/tL77sCiqRqHgtlBwm/u0SqaY8ILksqQkwesHB6EGIV5B FrZe3DQBnOUr7kCA/R2JABRSj37NZsSjwEvDb+fUqibPscwDZRetZqZT0zt5npj5kkQ8 enIslKWM9M7ZXou1mQCB+A+BX5XSE5ywF0ofh6GwNSwxQTx8FgLfAo5YTVM0q1CNlL6x I31CMHwOUdyOMZ4R/p42od82LAJJHLeTa9RDx01dKKqjRGil6GAV3lPzHgXdPDca/zqq F/vFC1yGuXgiKYKZWefQKlbgheRIvPtoHt88+fmJ+l3wSBPVDW0H5UuWB/aGi2DLAWY/ 4F3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="b/QCg1wW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a170902a50900b001a29280c544si641522plq.263.2023.05.31.03.25.03; Wed, 31 May 2023 03:25:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="b/QCg1wW"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235860AbjEaKSF (ORCPT + 99 others); Wed, 31 May 2023 06:18:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235580AbjEaKRz (ORCPT ); Wed, 31 May 2023 06:17:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEA5B189; Wed, 31 May 2023 03:17:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A3C763082; Wed, 31 May 2023 10:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8369EC433D2; Wed, 31 May 2023 10:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685528272; bh=3ZmWcklXUR3MN9rHzHFfe6CnosWBzUs6vc5XNpXadQg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b/QCg1wWiNj9X/gkuZ0Hj0YPkz0x7EprEOoUIVhh1cluWe91jhRxuFn8VRtDjkl4O iteyi2K+SmcZskb3rmpPuP0P3oGf5/hw3qwZaFJPI00YJqSRR4hhpUi1ooL57mSfqy VrPHr7pluMcGH2DlYoj5SJaMnv3vGzZlGgFN/XKRbAhNpQvLCjeaL0AypR8OP+EaAx W/dYpCC154dWA/qjMzSp639es5o6NbwKg/gfoIajV5C1FGsjTU3wlhfiqdV2+ScOHL Dq4+opCaI1ey7lfmIq3PQPlHdKaE84JOw36SmyM8t4rCU4s0IWscLODhwAmTD4773B Pyfs+GtT3zSrQ== From: Frederic Weisbecker To: "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , rcu , Uladzislau Rezki , Neeraj Upadhyay , Joel Fernandes , Giovanni Gherdovich Subject: [PATCH 2/9] rcu: Use rcu_segcblist_segempty() instead of open coding it Date: Wed, 31 May 2023 12:17:29 +0200 Message-Id: <20230531101736.12981-3-frederic@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230531101736.12981-1-frederic@kernel.org> References: <20230531101736.12981-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767404958795502374?= X-GMAIL-MSGID: =?utf-8?q?1767404958795502374?= This makes the code more readable. Signed-off-by: Frederic Weisbecker Reviewed-by: Joel Fernandes (Google) Reviewed-by: Qiuxu Zhuo --- kernel/rcu/rcu_segcblist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c index f71fac422c8f..1693ea22ef1b 100644 --- a/kernel/rcu/rcu_segcblist.c +++ b/kernel/rcu/rcu_segcblist.c @@ -368,7 +368,7 @@ bool rcu_segcblist_entrain(struct rcu_segcblist *rsclp, smp_mb(); /* Ensure counts are updated before callback is entrained. */ rhp->next = NULL; for (i = RCU_NEXT_TAIL; i > RCU_DONE_TAIL; i--) - if (rsclp->tails[i] != rsclp->tails[i - 1]) + if (!rcu_segcblist_segempty(rsclp, i)) break; rcu_segcblist_inc_seglen(rsclp, i); WRITE_ONCE(*rsclp->tails[i], rhp); @@ -551,7 +551,7 @@ bool rcu_segcblist_accelerate(struct rcu_segcblist *rsclp, unsigned long seq) * as their ->gp_seq[] grace-period completion sequence number. */ for (i = RCU_NEXT_READY_TAIL; i > RCU_DONE_TAIL; i--) - if (rsclp->tails[i] != rsclp->tails[i - 1] && + if (!rcu_segcblist_segempty(rsclp, i) && ULONG_CMP_LT(rsclp->gp_seq[i], seq)) break;