Message ID | 20230531072854.142629-1-claudiu.beznea@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2702236vqr; Wed, 31 May 2023 00:46:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ67BFtUxU+JwMlfqLmy1TZ+LJVq+JmZU6EAjvhNtKY2GsopGt4/AoHyy6auQmgPeaNPRMrt X-Received: by 2002:ac8:5a8b:0:b0:3ef:6c09:edcc with SMTP id c11-20020ac85a8b000000b003ef6c09edccmr5072055qtc.22.1685519191490; Wed, 31 May 2023 00:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685519191; cv=none; d=google.com; s=arc-20160816; b=tUzhNxuBuluxtrK5CnHiA4J8seTQ0BEGhsxrPj2xkr8rzMJma45e2vqNDZDdsZ3OXb XqZr1enYaBs/1jhQfwC6+AyxJ5CfwPd8d80qp1a5nvWXe5wHvplbItq/RiqzdFmyC5fB 6hHQ8fdca9UvtpTtKUDDYwY/mO8Al7+oduD8cf2PctmjatFZeKvCrilHfYzwM6cGr596 cvFvuif81CqZkhy/n/NzzSQAiGvwh1o02tXv91lRfgneng4EN35ynJ75M59l5LcyVJHA jCG4OELJfzjzyvAlPNdGA/H3NK9JiZIB8KKyfGHDAfrjjllGuuDgj4bQXXT64WGbHb0u tclA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9EEVz/iH8Y6Xt+KI8Imbfus31nTNXlrxJR9B4KX0LDU=; b=d4mKpptOfY2KVJRN0r0UsQ6nTf5s7D5ndHpcPk4SU1wuAfFODAeQJFCJlxWiun24qd a/aBMIMjKRap1/+qwNlsTkUnFamaFyNfVVWKJw0/aD8VzjR2wnr2muY+BRb3lxpgO0pe laDz7idPn+80LnfJsuf9NoGMDpQE6LKDG4yv+losF5BP19RGpHNiarHxq/SZyb78u2YX GPV/Vjrl8U008U9EWBRUgc1TVU6zBsAcSndqbtfaa117vOzxXtRPcep7aroWYalwcw7c Tezo0yzhshE1XMY7SH/T7HmZYcNgi5eKSI3kTsrQA/v4osa7sPgF5DTU5Oo5ud5vcH1T b+3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=EhePIZmH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ck18-20020a17090afe1200b00250a4d72bc9si514436pjb.108.2023.05.31.00.45.47; Wed, 31 May 2023 00:46:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=EhePIZmH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234606AbjEaH3f (ORCPT <rfc822;callmefire3@gmail.com> + 99 others); Wed, 31 May 2023 03:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234659AbjEaH3Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 31 May 2023 03:29:24 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 065D013E for <linux-kernel@vger.kernel.org>; Wed, 31 May 2023 00:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685518156; x=1717054156; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OFS01oMh3vyVox4i27eCh4n3gvVM54Ok/qp21x0hPuA=; b=EhePIZmHRDbJblEx7lhEOYUBdGj8wPsZtnMzWawZ6SQ0lfUmlAPJ8vSH 2sAO3WoinDr5Ufnj3kUpodQknQaPjbod6tt3pb8I+R2MmZmDW5ehIZdm7 cQAG95VrWqaIPrFsxmwjlW7qhWK1HCk8n/RWyG63O6BZpYrF6Z+3hDZI7 t2HOhbW8rK0DujGE2J7mUVPBtN/k1JPmThIgFrvsa7M2YttDUBN1O6X5e q9/OHhDgdlL0hfh/FQlv3icnWYn7sDE6q49wHsZfAqLuMostnOQjNzGxL +6FYg+EZIlBqCZ1lSHA8QTMVpmCK6UtM/8vK48hMT8EUZYrda7F1TtSNq w==; X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="227735487" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 31 May 2023 00:29:16 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 31 May 2023 00:29:16 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Wed, 31 May 2023 00:29:10 -0700 From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <yannick.fertre@foss.st.com>, <raphael.gallais-pou@foss.st.com>, <philippe.cornu@foss.st.com>, <airlied@gmail.com>, <daniel@ffwll.ch>, <mcoquelin.stm32@gmail.com>, <alexandre.torgue@foss.st.com> CC: <dri-devel@lists.freedesktop.org>, <linux-stm32@st-md-mailman.stormreply.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH] drm/stm: ltdc: check memory returned by devm_kzalloc() Date: Wed, 31 May 2023 10:28:54 +0300 Message-ID: <20230531072854.142629-1-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767394971287590877?= X-GMAIL-MSGID: =?utf-8?q?1767394971287590877?= |
Series |
drm/stm: ltdc: check memory returned by devm_kzalloc()
|
|
Commit Message
Claudiu Beznea
May 31, 2023, 7:28 a.m. UTC
devm_kzalloc() can fail and return NULL pointer. Check its return status.
Identified with Coccinelle (kmerr.cocci script).
Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
Hi,
This has been addressed using kmerr.cocci script proposed for update
at [1].
Thank you,
Claudiu Beznea
[1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@microchip.com/
drivers/gpu/drm/stm/ltdc.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On 5/31/23 09:28, Claudiu Beznea wrote: > devm_kzalloc() can fail and return NULL pointer. Check its return status. > Identified with Coccinelle (kmerr.cocci script). > > Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > > Hi, Hi Claudiu > > This has been addressed using kmerr.cocci script proposed for update > at [1]. > > Thank you, > Claudiu Beznea > > [1] https://lore.kernel.org/all/20230530074044.1603426-1-claudiu.beznea@microchip.com/ > > drivers/gpu/drm/stm/ltdc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 03c6becda795..9f3ac54d4cb3 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -1579,6 +1579,8 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev, > ARRAY_SIZE(ltdc_drm_fmt_ycbcr_sp) + > ARRAY_SIZE(ltdc_drm_fmt_ycbcr_fp)) * > sizeof(*formats), GFP_KERNEL); > + if (!formats) > + return NULL; > > for (i = 0; i < ldev->caps.pix_fmt_nb; i++) { > drm_fmt = ldev->caps.pix_fmt_drm[i]; Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Thanks for your patch. Cheers, Raphaƫl G.-P.
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 03c6becda795..9f3ac54d4cb3 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -1579,6 +1579,8 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev, ARRAY_SIZE(ltdc_drm_fmt_ycbcr_sp) + ARRAY_SIZE(ltdc_drm_fmt_ycbcr_fp)) * sizeof(*formats), GFP_KERNEL); + if (!formats) + return NULL; for (i = 0; i < ldev->caps.pix_fmt_nb; i++) { drm_fmt = ldev->caps.pix_fmt_drm[i];