From patchwork Wed May 31 05:35:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 101240 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2664229vqr; Tue, 30 May 2023 23:06:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5qC/0aYgRfRv34Cde4kYo16OcsLKxEi3kOy7KTnFi+i+LlKaCfLp0sINVMFZtTsQzYoSqa X-Received: by 2002:a05:6870:5b34:b0:19f:fdb:98d3 with SMTP id ds52-20020a0568705b3400b0019f0fdb98d3mr3006872oab.16.1685513214743; Tue, 30 May 2023 23:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685513214; cv=none; d=google.com; s=arc-20160816; b=LDeokEv3C0aeGs4jrCvnTz6V77TMxgLgzNzE9s7oxTgslyuIrtsIx/v2ZQBO7T5AFD HHOtLEi7aR71O+8BZM/SHfwpDjoXmPcThldBmqgZN50gFWCssHhs2do7SiBPVGMvSl15 ySb07TQHWQtziNrICX7Bx5q/wLe5T8TIazlrkz8Dc60TOEn6fcVQP19TVm846SKpJeEM sheOGVlF/sXat6vybylCKziUFOdwxocf1PP5KKe3659gYgB4uelOg3lJx2gQourRtpE6 2Yo1dFEyl33zv3BH7GylnAsOneb05fNtDUO3bykSXcjvBZNu2DHJ0ZlO1wAvHs2ceJgF oBMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=n2EeMrdfr5wDxb2eZxsqBeZ0jfN7UYvorqxNMkGj3/I=; b=JRqHXsq1DsbtVKE/GBVBKvooE8Z/QuDRb0/fLyFeeMRCAGB2/Iyfmisnxhlz5EsKgP ql6ygkwUDcXjeZPghnMIxPOtk4eoZ3NX9weSHtOgaAXwsroKzN46n9uSqt+H2pez/khV awkTliGmrGlMBwHdxx6ihjVm5dYYeGJJb/cd6MiHcQOm1IqBVOxGjdAklXIE8ps29xXs ObG3zx3vv2W19RS/XQ4ofrGK90YMncLmkb4mEoLT8AuVM7sO91XP+W+3NgDHXJPTjU/9 fIji9ugNDSaT8436GAhAb7dAiEhNkv9TcXpKGPBNRYIlHXD6ywM20pk5hVNe7YvIueEe QeXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y30-20020a63b51e000000b00530b6949dcdsi439415pge.218.2023.05.30.23.06.42; Tue, 30 May 2023 23:06:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232156AbjEaFgW (ORCPT + 99 others); Wed, 31 May 2023 01:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229865AbjEaFgV (ORCPT ); Wed, 31 May 2023 01:36:21 -0400 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62345D9; Tue, 30 May 2023 22:36:19 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R561e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VjwC2E9_1685511360; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VjwC2E9_1685511360) by smtp.aliyun-inc.com; Wed, 31 May 2023 13:36:15 +0800 From: Jiapeng Chong To: pavel@ucw.cz Cc: lee@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] leds: flash: leds-qcom-flash: Fix an unsigned comparison which can never be negative Date: Wed, 31 May 2023 13:35:59 +0800 Message-Id: <20230531053559.5702-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767388704779249564?= X-GMAIL-MSGID: =?utf-8?q?1767388704779249564?= The variable 'count' is defined as unsigned type, so the following if statement is invalid, we can modify the type of count to int. if (count <= 0) { dev_err(dev, "No led-sources specified\n"); return -ENODEV; } ./drivers/leds/flash/leds-qcom-flash.c:546:5-10: WARNING: Unsigned expression compared with zero: count <= 0. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5344 Signed-off-by: Jiapeng Chong --- drivers/leds/flash/leds-qcom-flash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c index c8d41a3caf38..b089ca1a1901 100644 --- a/drivers/leds/flash/leds-qcom-flash.c +++ b/drivers/leds/flash/leds-qcom-flash.c @@ -538,9 +538,9 @@ static int qcom_flash_register_led_device(struct device *dev, struct led_init_data init_data; struct led_classdev_flash *flash = &led->flash; struct led_flash_setting *brightness, *timeout; - u32 count, current_ua, timeout_us; + u32 current_ua, timeout_us; u32 channels[4]; - int i, rc; + int i, rc, count; count = fwnode_property_count_u32(node, "led-sources"); if (count <= 0) {