Message ID | 20230530201421.847792-1-florian.fainelli@broadcom.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2444002vqr; Tue, 30 May 2023 13:32:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4qXhxawscAfC+a2QUffzRPIArbUV9q4ezZctmEsLTkoKSXcyQDPjM9nggPN5zytoGvib6F X-Received: by 2002:a17:902:76c8:b0:1ab:d6f:51b0 with SMTP id j8-20020a17090276c800b001ab0d6f51b0mr3118192plt.18.1685478742170; Tue, 30 May 2023 13:32:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685478742; cv=none; d=google.com; s=arc-20160816; b=Pj6645zLfmBWbXP47Gczw/WXpMPBhqoVF42d1Z4iOfCx376vF+ahZjx4ZFy+dz71dT eeAqSBnxBG4DuMaLQhxjKIcbqROMLD60vX7GQbLXJaNf5LQMSJp2PhSglgn5ipySBFCy 7ELctlD1GyvlswsOWz7qxJ7Wyd35ZNmWynt14NEvwbiPuEfBoPIV9zbBodKbm/zmRK0y RpURHtd4zMhchXer8nNOUwpBgUvoShc3+jCwf9qbXDEn53iMSg8pfCEGNyxVLodmuMii vxIEBrM258mw7QYyuN4Wi/25heli/jiIU7PnkgbHJa0tUEWAXL7il/rvs0BHN+oA04o6 yOtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=qfF2eep617J21NPyHMmCPASbViSlLJAUXXoTGAdchIc=; b=JqTIbZoR84TLhbWMHr4iTyOA/tkM2GxeXOdq3VC0SfG5qqEX/b9r+UORPjgpPiIiT0 tADBty/hpQxm+wuuhvG0tDv5z9NTKL0F9tFLhFdLOvLH3b4ArAlxYGXZ6A+3OTXqLyiY mnceWKccgQrOrqQVLq6w6qQ552sSqMRhIh9Xq9Fr8SyMxAa7ezuMYqg7vC6sGJrCxTNP P3fMih2+YgM3hwBAaMQa9bl3VwW8EgH6DEyLcTtvtaXjjNSuTTmqxqDKwf093CalgTpY fb/JCgpyfwYh5FRJ+8oVOYNLNLzmNOkumVk7e2CKWzY7npd76qkelqH0wtgBvBi0jlqh 4IWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=WiaXoG6d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i12-20020a1709026acc00b0019f3064da41si780021plt.383.2023.05.30.13.32.08; Tue, 30 May 2023 13:32:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=WiaXoG6d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231546AbjE3UPF (ORCPT <rfc822;andrewvogler123@gmail.com> + 99 others); Tue, 30 May 2023 16:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbjE3UPC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 30 May 2023 16:15:02 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33803129 for <linux-kernel@vger.kernel.org>; Tue, 30 May 2023 13:14:31 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-64d5b4c400fso5506615b3a.1 for <linux-kernel@vger.kernel.org>; Tue, 30 May 2023 13:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1685477670; x=1688069670; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qfF2eep617J21NPyHMmCPASbViSlLJAUXXoTGAdchIc=; b=WiaXoG6dFmosXospc/dzdFwoYw8fapA34vAl5bxtjWvl1LIa8LXDQRWOqearSijWi7 sjxneLjcJ7OshZjZEa70kYdGPJlIuDiH3nwVBKQyEhTeTt6KImZBk3rLOhq81SE1rIH1 xnkmw1lHnCsL7bLBDVmyRva4PfQpAvBHZ6O20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685477670; x=1688069670; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qfF2eep617J21NPyHMmCPASbViSlLJAUXXoTGAdchIc=; b=BpZ+ByDHVDfzOjkjsuaye1QvuYSPjSHvqbnLBz7DVtdTHxvjsgsG4JFHakzhGBZkHM dypQxmYWXnAUIvVN9P5abn47JQg9udnAms0F9Slw8HJXud59XCNADQHb177GINhVdOYM S3wzy8p0QdxlCGrdoVIcUYdg/HtrK3Qbe1cXl/d9lfGRfTVKEs3vpGYmLq8piiOF8UQK ptTJofcCxFeKzy+i427I9sYtDxffT8pWn1XQeN2F0sEo0VPf2DbzRZ1Jto4xplXnKTh7 QfwfILzZkArrGRgFp+SOmzv4Lp4dKfHiRPmgUsyxcqgcWmTt8aILNiJq3TT5WSjadOw0 plsQ== X-Gm-Message-State: AC+VfDwDVztbqNit1cgzZio13Vc4jbFm014nYOxfTXrq+LEC8DGeyST3 Fj8DKr2Wa34X+FAWMDh5xrZ/OQ== X-Received: by 2002:a05:6a00:80e:b0:64d:2e8a:4cc1 with SMTP id m14-20020a056a00080e00b0064d2e8a4cc1mr4446651pfk.27.1685477670582; Tue, 30 May 2023 13:14:30 -0700 (PDT) Received: from stbirv-lnx-3.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x4-20020aa79184000000b0064d3881e687sm2051547pfa.35.2023.05.30.13.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 13:14:29 -0700 (PDT) From: Florian Fainelli <florian.fainelli@broadcom.com> To: stable@vger.kernel.org Cc: Pierre Gondois <pierre.gondois@arm.com>, Conor Dooley <conor.dooley@microchip.com>, Sudeep Holla <sudeep.holla@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org (open list:GENERIC ARCHITECTURE TOPOLOGY) Subject: [PATCH stable 6.3] arch_topology: Remove early cacheinfo error message if -ENOENT Date: Tue, 30 May 2023 13:14:20 -0700 Message-Id: <20230530201421.847792-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000da9e0405fceed9eb" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767352557834496786?= X-GMAIL-MSGID: =?utf-8?q?1767352557834496786?= |
Series |
[stable,6.3] arch_topology: Remove early cacheinfo error message if -ENOENT
|
|
Commit Message
Florian Fainelli
May 30, 2023, 8:14 p.m. UTC
From: Pierre Gondois <pierre.gondois@arm.com> fetch_cache_info() tries to get the number of cache leaves/levels for each CPU in order to pre-allocate memory for cacheinfo struct. Allocating this memory later triggers a: 'BUG: sleeping function called from invalid context' in PREEMPT_RT kernels. If there is no cache related information available in DT or ACPI, fetch_cache_info() fails and an error message is printed: 'Early cacheinfo failed, ret = ...' Not having cache information should be a valid configuration. Remove the error message if fetch_cache_info() fails with -ENOENT. Suggested-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/ Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20230414081453.244787-4-pierre.gondois@arm.com Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/base/arch_topology.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index 147fb7d4af96..b741b5ba82bd 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -843,10 +843,11 @@ void __init init_cpu_topology(void) for_each_possible_cpu(cpu) { ret = fetch_cache_info(cpu); - if (ret) { + if (!ret) + continue; + else if (ret != -ENOENT) pr_err("Early cacheinfo failed, ret = %d\n", ret); - break; - } + return; } }