diff mbox series

drivers/gpio : Remove redundant clearing of IRQ_TYPE_SENSE_MASK

Message ID 20230530162034.4004-1-sensor1010@163.com
State New
Headers
Series drivers/gpio : Remove redundant clearing of IRQ_TYPE_SENSE_MASK |

Commit Message

Lizhe May 30, 2023, 4:20 p.m. UTC 
  Before executing microchip_sgpio_irq_set_type(),
type has already been cleared IRQ_TYPE_SENSE_MASK, see __irq_set_trigger().

Signed-off-by: Lizhe <sensor1010@163.com>
---
 arch/arm/plat-orion/gpio.c | 1 -
 drivers/gpio/gpio-mvebu.c  | 1 -
 2 files changed, 2 deletions(-)

Comments

Bartosz Golaszewski May 30, 2023, 4:30 p.m. UTC | #1 
On Tue, May 30, 2023 at 6:21 PM Lizhe <sensor1010@163.com> wrote:
>
> Before executing microchip_sgpio_irq_set_type(),
> type has already been cleared IRQ_TYPE_SENSE_MASK, see __irq_set_trigger().
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
>  arch/arm/plat-orion/gpio.c | 1 -
>  drivers/gpio/gpio-mvebu.c  | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
> index 595e9cb33c1d..863fa497b1a2 100644
> --- a/arch/arm/plat-orion/gpio.c
> +++ b/arch/arm/plat-orion/gpio.c
> @@ -364,7 +364,6 @@ static int gpio_irq_set_type(struct irq_data *d, u32 type)
>                 return -EINVAL;
>         }
>
> -       type &= IRQ_TYPE_SENSE_MASK;
>         if (type == IRQ_TYPE_NONE)
>                 return -EINVAL;
>

What have you not understood about splitting this into two patches?

Bart

> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index a68f682aec01..34fd007b0308 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -505,7 +505,6 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
>         if ((u & BIT(pin)) == 0)
>                 return -EINVAL;
>
> -       type &= IRQ_TYPE_SENSE_MASK;
>         if (type == IRQ_TYPE_NONE)
>                 return -EINVAL;
>
> --
> 2.34.1
>
Russell King (Oracle) May 30, 2023, 4:43 p.m. UTC | #2 
On Wed, May 31, 2023 at 12:20:34AM +0800, Lizhe wrote:
> Before executing microchip_sgpio_irq_set_type(),
> type has already been cleared IRQ_TYPE_SENSE_MASK, see __irq_set_trigger().
> 
> Signed-off-by: Lizhe <sensor1010@163.com>

Please do as Bart has requested.

Your patch touches two files, each of which are managed by *different*
people via *different* trees. Re-posting your patch will *not* get it
applied, because the reason it can't be applied is because you have not
split it as people have asked you to do.

So, there is no point you re-posting it in its current form. You will
only make people frustrated, and if that continues, you will end up
being ignored.

Thanks.
diff mbox series

Patch

diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
index 595e9cb33c1d..863fa497b1a2 100644
--- a/arch/arm/plat-orion/gpio.c
+++ b/arch/arm/plat-orion/gpio.c
@@ -364,7 +364,6 @@  static int gpio_irq_set_type(struct irq_data *d, u32 type)
 		return -EINVAL;
 	}
 
-	type &= IRQ_TYPE_SENSE_MASK;
 	if (type == IRQ_TYPE_NONE)
 		return -EINVAL;
 
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index a68f682aec01..34fd007b0308 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -505,7 +505,6 @@  static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 	if ((u & BIT(pin)) == 0)
 		return -EINVAL;
 
-	type &= IRQ_TYPE_SENSE_MASK;
 	if (type == IRQ_TYPE_NONE)
 		return -EINVAL;