Message ID | 20230530093913.1656095-9-claudiu.beznea@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2068487vqr; Tue, 30 May 2023 03:12:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Mt+B5lJRKnrwLA+wtg3PPuj6noQozpocY4/bEbLer096GEUP8ezs9FvwXNw2il4OI2DeL X-Received: by 2002:a17:903:244e:b0:1ac:63b6:f1ca with SMTP id l14-20020a170903244e00b001ac63b6f1camr2309903pls.0.1685441540836; Tue, 30 May 2023 03:12:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685441540; cv=none; d=google.com; s=arc-20160816; b=Z+iO1Nm5vvs8/44sXG4fA89IqNmux4KfFfKapdIN0EGQs+soh1JdiIGXMmM0Ylke4J cBh0NQi2ySfeNjU31hd5e0NJxOsG7SsuxqwCcgCD99pKZ67xSMMGazTpuOHf39gWTbU3 P1dCRqdp/knGK+xqKq0+QFx5dEicA6P22z+KnWBxZG1XwmgLzNFBc+9wi0y1hk5QNC8g zZ/DiZKlZ488i5BP5m2zUwsEJdsmDhPiQmYoB5cmtz7/KGwGxi531LEDX7BKkGNuidDe p+lNTtezxnsh0g21a2wODQND+ykcKpZV8KT9cv4vjWYrdd/0VUohcdNdM2w9TStzbK9i axgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YcJ+Ul7iik6g1/YN18xYYxKmKzNODTkRg4/vvMtGX+w=; b=M6tUgkMnjErkZWNeVUd3o8M7CZzndHRd00zad/D9Cya5i8bJdJD9VuALHasfJmieWp PZs3koWDylD9V50YEm4Ajqnwp95X80YVjvzp7z9r9c+u5QAMFbDAAviTqW5Sa6pjxr1W zg8CJ8xqzwmsV45zZJc/+ID6kWwt+OO2e95O73yPXXpi3Qzdx1o/CEKNbee30znls84r 7/2ESlji4LO5szpgJIsTdkOrDgmgWdi3aDCMtGO4V73f2vmq/l0yBo42BC7seG69vU9n Yn7APAsqwBJjozdEl+U1FH5xi8WJTRG6RHLLVqolm/FNTKhUFNcnWh7b+5DKxkzFELWA gWeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=m63MsVKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a170902758700b001b049aae135si829230pll.246.2023.05.30.03.12.03; Tue, 30 May 2023 03:12:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=m63MsVKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjE3Jkt (ORCPT <rfc822;andrewvogler123@gmail.com> + 99 others); Tue, 30 May 2023 05:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231236AbjE3Jkj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 30 May 2023 05:40:39 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4388C19C; Tue, 30 May 2023 02:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685439619; x=1716975619; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zaCpku09a8GcgYcESUClblE15AQp+FSilf+S/hwA1+k=; b=m63MsVKpRQkaRdOVATWkZrPT1iixUWDb0L682jzGv/OjtRbcTyHLiwbw umVRTWcIMhq1KDrRMowK4++H8imoHg+LqDQ803IqdRKEF2Yeclk2onODZ l/bss9CxsV0LLXBA6ICSFWg4P2PMD6BEZ8jJWQetf/wCq1LMMIGtkxoKX n/785UP5A4NOWDtOwmooLSOt2Jfhbd0f2pXioEE7ot11IJNo/kzyKnzGw B4HA/WH7i+BdPL11us0pmvbGrGOTr2cencGkr3UcHf2M1KxIfSVJ3EPiY c5Z+zSiQEeALX0HWWih5EigqYB4RZthB8nfXylyKX8ymt6ljpbPcpI6TN Q==; X-IronPort-AV: E=Sophos;i="6.00,203,1681196400"; d="scan'208";a="227558719" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 May 2023 02:40:18 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 30 May 2023 02:40:16 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Tue, 30 May 2023 02:40:11 -0700 From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <mturquette@baylibre.com>, <sboyd@kernel.org>, <luca.ceresoli@bootlin.com>, <nm@ti.com>, <kristo@kernel.org>, <ssantosh@kernel.org>, <michal.simek@xilinx.com> CC: <aford173@gmail.com>, <mike.looijmans@topic.nl>, <robert.hancock@calian.com>, <shawn.guo@linaro.org>, <fabio.estevam@freescale.com>, <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-omap@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH 8/8] clk: clocking-wizard: check return value of devm_kasprintf() Date: Tue, 30 May 2023 12:39:13 +0300 Message-ID: <20230530093913.1656095-9-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230530093913.1656095-1-claudiu.beznea@microchip.com> References: <20230530093913.1656095-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767313548995555423?= X-GMAIL-MSGID: =?utf-8?q?1767313548995555423?= |
Series |
clk: check memory returned by {devm_}kasprintf()
|
|
Commit Message
Claudiu Beznea
May 30, 2023, 9:39 a.m. UTC
devm_kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).
Fixes: 2046338dcbc6 ("ARM: mxs: Use soc bus infrastructure")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 5 +++++
1 file changed, 5 insertions(+)
Comments
Quoting Claudiu Beznea (2023-05-30 02:39:13) > devm_kasprintf() returns a pointer to dynamically allocated memory. > Pointer could be NULL in case allocation fails. Check pointer validity. > Identified with coccinelle (kmerr.cocci script). > > Fixes: 2046338dcbc6 ("ARM: mxs: Use soc bus infrastructure") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- Applied to clk-next
diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c index e83f104fad02..20e0e91552bc 100644 --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c @@ -648,6 +648,11 @@ static int clk_wzrd_probe(struct platform_device *pdev) } clkout_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_out0", dev_name(&pdev->dev)); + if (!clkout_name) { + ret = -ENOMEM; + goto err_disable_clk; + } + if (nr_outputs == 1) { clk_wzrd->clkout[0] = clk_wzrd_register_divider (&pdev->dev, clkout_name,