Message ID | 20230530083713.2527380-2-o.rempel@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2033354vqr; Tue, 30 May 2023 01:56:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ47Ou87vo9icAAhVAuFRYOWexGjUj4hKGqUIkSQb4CfMHc5JD/I9AW/6UuyoFMK6e1Zhncv X-Received: by 2002:a05:6a20:5483:b0:10b:2f5a:83af with SMTP id i3-20020a056a20548300b0010b2f5a83afmr2054973pzk.16.1685436989211; Tue, 30 May 2023 01:56:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685436989; cv=none; d=google.com; s=arc-20160816; b=EHHYzfdBLTI9Dp1Jna0yCjaglXDYym76/bPNB3CZOVOVW15kX53RZhTzT5VMa3D7v/ xiNkEZo64T+h73nnuPfC90wXuHKqO3d+3J/VZP8Xp0YEAUL8xXJr+j4cnaUwKm8Or9LY DGfvfpByyUFQJJCTbCvhLu4LYbS01Odz2flb0Pp0usiZwgZh7r4lxb1cpEFt/wnzpBlc vLtX3g8kyONiDUJ6k7x0/3jZPhljs1NlweHcw/AMiwg6SyrdfCTfPMMY4QVd4logxVBf RhLMt7Td3LKK5nKHkU/f2ghB4Xwky1bBMQ/gIq4cedqd4sZdfp5pM/tPtZGDLP8fMbMJ VkDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Mffu6ylWARQW4BfTHGXq1ibj06+xnjhV8Hqf2Ub2Rms=; b=oSmm4JrtlZiNKLwaWP9cRpvyDnCgR/ziF1alrZXNDRvB/2jRN/f41WEK8R2kDqXKo7 ZBZjh9HWnOhfcWJnro1vggGGzsLP2A8GYVQR/mo/1BMisGmr2aDMqOzFQkx8B4s20D7l ADVqNQ9eudufnHcmH1zgHIgGfZjvuyJjgZIzmuG0oOB51bVNx6XNstoMt7b6U9KI62rR lykZoEM7P1W5a5umAAHCpe+Pm4KbwFKDp3kR6mSO18HI0/UEU9f91roy2AsXgkzH7t58 r6EpSv/OUBM8f/Y6jF2MnuCMlvguOxftsSjPnLbXkXf0vm+/SsLRpy1L+gci12u4klTA QjkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 138-20020a630190000000b0052ca7192647si11090800pgb.548.2023.05.30.01.56.16; Tue, 30 May 2023 01:56:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbjE3Ihw (ORCPT <rfc822;andrewvogler123@gmail.com> + 99 others); Tue, 30 May 2023 04:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbjE3Iha (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 30 May 2023 04:37:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23129BE for <linux-kernel@vger.kernel.org>; Tue, 30 May 2023 01:37:29 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ore@pengutronix.de>) id 1q3uqy-0002xU-JO; Tue, 30 May 2023 10:37:16 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1q3uqw-003pab-R1; Tue, 30 May 2023 10:37:14 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1q3uqw-00AbUl-3C; Tue, 30 May 2023 10:37:14 +0200 From: Oleksij Rempel <o.rempel@pengutronix.de> To: Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= <jerome.pouiller@silabs.com> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 1/3] dt-bindings: net: pse-pd: Update regex pattern for ethernet-pse nodes Date: Tue, 30 May 2023 10:37:11 +0200 Message-Id: <20230530083713.2527380-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230530083713.2527380-1-o.rempel@pengutronix.de> References: <20230530083713.2527380-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767308776124566392?= X-GMAIL-MSGID: =?utf-8?q?1767308776124566392?= |
Series |
Extend dt-bindings for PSE-PD controllers and update prtt1c dts
|
|
Commit Message
Oleksij Rempel
May 30, 2023, 8:37 a.m. UTC
This patch modifies the regex pattern for the $nodename property in the
device tree bindings documentation for PSE-PD controllers. The updated
pattern allows for additional node names, including those with a hyphen
followed by a hexadecimal digit.
Before this change, the pattern ^ethernet-pse(@.*)?$ only allowed for
node names like "ethernet-pse" or "ethernet-pse@1". With the new pattern
node names like "ethernet-pse-1" are now also valid.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/net/pse-pd/pse-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 30/05/2023 10:37, Oleksij Rempel wrote: > This patch modifies the regex pattern for the $nodename property in the Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > device tree bindings documentation for PSE-PD controllers. The updated > pattern allows for additional node names, including those with a hyphen > followed by a hexadecimal digit. > > Before this change, the pattern ^ethernet-pse(@.*)?$ only allowed for > node names like "ethernet-pse" or "ethernet-pse@1". With the new pattern > node names like "ethernet-pse-1" are now also valid. This part is duplicating first paragraph. What you should have here is answer to why we need it. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/pse-pd/pse-controller.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > index b110abb42597..3548efc2191c 100644 > --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > @@ -16,7 +16,7 @@ maintainers: > > properties: > $nodename: > - pattern: "^ethernet-pse(@.*)?$" > + pattern: "^ethernet-pse(@[0-9a-f]+|-([0-9a-f]+))?$" No need for inner () Let's make -N suffix only decimal, as discussed here: https://lore.kernel.org/all/20221123024153.GB1026269-robh@kernel.org/ I will send a patch for other files. > > "#pse-cells": > description: Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml index b110abb42597..3548efc2191c 100644 --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml @@ -16,7 +16,7 @@ maintainers: properties: $nodename: - pattern: "^ethernet-pse(@.*)?$" + pattern: "^ethernet-pse(@[0-9a-f]+|-([0-9a-f]+))?$" "#pse-cells": description: