From patchwork Tue May 30 07:53:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrizio Lamarque X-Patchwork-Id: 100648 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2011173vqr; Tue, 30 May 2023 01:04:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7IlPH9JvjFAkg1KtTxCPiVlT5ZjGv47RiSSXWkaVUWqkoSalQDaQgwQHv/jsM3Xczx0Q5U X-Received: by 2002:a05:6a00:2d1f:b0:63d:260d:f9dd with SMTP id fa31-20020a056a002d1f00b0063d260df9ddmr1435316pfb.33.1685433868435; Tue, 30 May 2023 01:04:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685433868; cv=none; d=google.com; s=arc-20160816; b=u5ozd3fyblIfxm+A4tjBes+RacZfoV/HTHrcWfU0DQWcXxPOV9PLdvY37NLN+TxEkD x1oKJ3Zl2+7G0WU7nd1Y+aF7ox34mJg5sYCsKmsvedqqItIsZOqAX9IFVVvC2cseDZz9 aRsaxbN0u4/d3CT36cf/NtJqyweI12b0PLDNrEinw9ZEbGuFlh4DOH/xUGQuPM0GvfdV 05Xr/UZw6OegC8yvdGJelTLCvYC4ZvQkyJ44Q0ffO5XmAj6an09Nl90p8DwwaupgNTUv YMg9H2mAtpbUyaEr0jRgO5Vylcjy4DNdQBBN5Q38uKBXAwAuFFLwhODxq1t5w2P/Mu9+ 5p/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oJat+S2GRgqfm5ZimEWfP+mzTLI8bh6EOyD08golq/0=; b=VVFwm5R/nvsw+vHP6CcqKGETKOJhCU3s3524CwKMKwH4DzfCZRatePQIdkRU/jrTdo TEzoxV5e37doNt4svpU2zwvV0XSd9yUy+lhwBK/gsYyORGxDl9oUuTW9Z4weKC+hY9wG TWBfcNxsvm0Ong/2VoMAuCWT5DGawTmQBTfKRu8P7cKeRzg9FmvlFF5X2xFDYh/WURfa gTpigBXOV404r/mamYDLCZE9pAnLenJ2s+jXpU+PVJE14sgIXit7G9Uq43cI08n3xT/o Z5jH2PzIXzkyZLgNzY8GXviEmTb6W7d+gE3eAaRX5dp+n8C497jC6Q1E+pursKftVJfI hd8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=UpieOk9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r18-20020aa79632000000b0064d72c6eab6si1323803pfg.274.2023.05.30.01.04.14; Tue, 30 May 2023 01:04:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=UpieOk9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229665AbjE3Hxl (ORCPT + 99 others); Tue, 30 May 2023 03:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbjE3Hxg (ORCPT ); Tue, 30 May 2023 03:53:36 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D9C1BF; Tue, 30 May 2023 00:53:33 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3f6d7abe9a4so27529025e9.2; Tue, 30 May 2023 00:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685433211; x=1688025211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oJat+S2GRgqfm5ZimEWfP+mzTLI8bh6EOyD08golq/0=; b=UpieOk9BHq8mFg2B9lc37PmA3YmachbEQ0bDEErszcfoGBe0Q038rWYwIecXoOtRcT nkBlkMm9WQoqsvG4DMUq7SfEjCcaQK6TmSuutlIDwikWKpm5fLfB6d++CCS7GpD2/7xs nZoNtzH4rU4uzR3mPE4sSP2AAHgFs3bKlE+J73Rbgwf2X01ndDdoFmz74rVzAH7Jty/a SrKn1+SZoR8nzn2kg1BsI6CVteNzPmUrXCeKJWJI6tevNOaQ+AV5mNtFzTEf67Y76/L6 8O0U2WE4d42JAwkHIzdDwEqJfh6KkI9btRSQrsTmTKpXtA/z4byklhMwzTeP8Qh77MyU xnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685433211; x=1688025211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oJat+S2GRgqfm5ZimEWfP+mzTLI8bh6EOyD08golq/0=; b=HvHG9+SbU6mVgkylZyjAgzV40EYBQYkK3bOdi0+ObsKjODmvMNPrtBPYTgotK8A05+ grPkiRiLZuMo+VqKpyaTqGRbedDSEDOfA32Gt8avp5R4yv4Z/Azu/30h4Iq8RcFP8t7+ dMbJmcsaxKdJZmOcrozIS4rSPOHGELSPXLq2nuQE3W7GgcJEykoF63PqvrZ4ZV6hmHUD fa1GeuWryjGqXzX7vfu/UtiFdP/+lLGT4/GxYXr2eVVpXlRTC10IqNTuMcot+Ny9CsD7 NHoMyBA/tegr+2hzcE25fXYIEmOhkiPUVt6Rs1vIrsvnpFaz/GHO4QNr4hrFuHEbmLCW F+Jw== X-Gm-Message-State: AC+VfDxSH9C3NlSLsHWVvRMrAnWOnqHF0/g0vtXxoNoPmhqgTwt2Ri9F 52oC49sGT7BD+C0HpNHjV+M= X-Received: by 2002:a05:600c:2106:b0:3f6:be1:b8d9 with SMTP id u6-20020a05600c210600b003f60be1b8d9mr752088wml.6.1685433211177; Tue, 30 May 2023 00:53:31 -0700 (PDT) Received: from PC-UT2.ad.ennebielettronica.com ([78.152.97.130]) by smtp.gmail.com with ESMTPSA id x21-20020a05600c21d500b003f6041f5a6csm16561275wmj.12.2023.05.30.00.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 00:53:30 -0700 (PDT) From: fl.scratchpad@gmail.com To: jic23@kernel.org, Alexandru Tachici , Lars-Peter Clausen , Michael Hennerich , Alexandru Ardelean Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Fabrizio Lamarque , Nuno Sa , Jonathan Cameron Subject: [PATCH v3 2/5] iio: adc: ad7192: Fix internal/external clock selection Date: Tue, 30 May 2023 09:53:08 +0200 Message-Id: <20230530075311.400686-3-fl.scratchpad@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230530075311.400686-1-fl.scratchpad@gmail.com> References: <20230530075311.400686-1-fl.scratchpad@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767305503992845736?= X-GMAIL-MSGID: =?utf-8?q?1767305503992845736?= From: Fabrizio Lamarque Fix wrong selection of internal clock when mclk is defined. Resolve a logical inversion introduced in c9ec2cb328e3. Fixes: c9ec2cb328e3 ("iio: adc: ad7192: use devm_clk_get_optional() for mclk") Signed-off-by: Fabrizio Lamarque Reviewed-by: Nuno Sa --- drivers/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index 94a9cf34a255..5a9c8898f8af 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -367,7 +367,7 @@ static int ad7192_of_clock_select(struct ad7192_state *st) clock_sel = AD7192_CLK_INT; /* use internal clock */ - if (st->mclk) { + if (!st->mclk) { if (of_property_read_bool(np, "adi,int-clock-output-enable")) clock_sel = AD7192_CLK_INT_CO; } else {