From patchwork Mon May 29 19:14:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 100387 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1722353vqr; Mon, 29 May 2023 12:19:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DdgKJ6nqddv6jj+/Fw4RshkIb0eTR5b1eMzY/g+an7X1eJrfAeJw8YZ4v22oT6ikEC+/k X-Received: by 2002:a17:902:ce84:b0:1ac:aac1:e344 with SMTP id f4-20020a170902ce8400b001acaac1e344mr199259plg.36.1685387982178; Mon, 29 May 2023 12:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685387982; cv=none; d=google.com; s=arc-20160816; b=tC0b3AvrkFRMMoM3b5pGc/6CYDVyWeUjGFnNbM30eHK1ptCG9scS39NhdljBeaVOIq KkE59FJ7II1sLWl1TqIo+Eb35fs6hXGAqkduTE5AJSldgxToUL6UT2eafWEkZuDnU7gK 9KidWI60HzkJqloLDh2/le0lH2sAJ95T57ONVCI3in3eHdhXqIee+hNhyIi1SgPXEb6W JVn1PoeoIqE36t81apyyVTSmKrpgkwIHWFGWXs4NpHQqNZlHYA//tjXhnB+R6UQujhpO pKLNDHUUeq33BWYrrhEzs6ono8/nbbDtGj15qeBvV3JKKXmxTfXxl3zhT+kHRL3uYR60 DhqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AG8T0dRwqEURuo50XJXwN0FInMeOvUVPZxn8hNbzcKU=; b=fZ8si7qjXoFkBBqIrwvBPWsqy5FcpVrfiEDBJIDnU9Y/TT7Ftxk6U/dgLMuRF/Yyb7 O5rsMobChtELGTDO8qHnEGZl8N7UxdFl7hV7Rnm627scjS+OQy+REH0g4aU6k0CFmQ7i vAXW/097ZcTiDMTbu4F3NRHTmIbPnbLajhBrU/8IFegVo3ppw5MtzD05i1vs++eOiPo6 jzOrTpkecosVdjr5Hxn4A+XLEus2rTUzUl7nwyIlBQP5yIg0pzOWfnl5EsuXr/Xhgumh zjzB26L1e+OEIV3tzg7zZRwGMbSbvMHO4V62ObMUc21mIKlbaor7ot1+you/xDcfmJXy iRYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@efficios.com header.s=smtpout1 header.b=JOryM4YH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c10-20020a170903234a00b001ae453d07a3si6116608plh.539.2023.05.29.12.19.07; Mon, 29 May 2023 12:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@efficios.com header.s=smtpout1 header.b=JOryM4YH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbjE2TO3 (ORCPT + 99 others); Mon, 29 May 2023 15:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbjE2TO1 (ORCPT ); Mon, 29 May 2023 15:14:27 -0400 Received: from smtpout.efficios.com (unknown [IPv6:2607:5300:203:b2ee::31e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1DE9DC; Mon, 29 May 2023 12:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1685387664; bh=4iL71aqYe6mylgQi/BMhO/DWKge19ME73V8LmRUiL0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JOryM4YHJrCJcZzUWSpChQleZcvut1kTGIIi7UFdFAE/7CiS+zzdzW052nujghcBL JJ2gaH2SB/CNXKa5sT3JBTRvmJrfA2VtAGeuUUCZEyUluxGWwzqu21PkZ5av/oK+zC QP9MryjatNN5GN28eOOM/mqsGR9Lz+5hERq2xXUD1G8BQbADOrtGcpWjMcQ4mw2SFJ dGSKFqu6RE3gThOyAXZ95I+LaTGDevfV15U5oYHnMi0JVXmVEmlqJqlYx4R9MxtQkW gIRMrhO8i6B5JFoya26rQiNKi6YV/2Qevg81Z5lPJKVbgjZidOktCFm3CxvPNUVe9S QpbUFNKg8Ts5w== Received: from localhost.localdomain (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4QVQFC4LtVz165R; Mon, 29 May 2023 15:14:23 -0400 (EDT) From: Mathieu Desnoyers To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Boqun Feng , "H . Peter Anvin" , Paul Turner , linux-api@vger.kernel.org, Christian Brauner , Florian Weimer , David.Laight@ACULAB.COM, carlos@redhat.com, Peter Oskolkov , Alexander Mikhalitsyn , Chris Kennelly , Ingo Molnar , Darren Hart , Davidlohr Bueso , =?utf-8?q?Andr=C3=A9_Almeida?= , libc-alpha@sourceware.org, Steven Rostedt , Jonathan Corbet , Noah Goldstein , Daniel Colascione , longman@redhat.com, Mathieu Desnoyers Subject: [RFC PATCH v2 4/4] selftests/rseq: Implement rseq_mutex test program Date: Mon, 29 May 2023 15:14:16 -0400 Message-Id: <20230529191416.53955-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230529191416.53955-1-mathieu.desnoyers@efficios.com> References: <20230529191416.53955-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767257388724666961?= X-GMAIL-MSGID: =?utf-8?q?1767257388724666961?= Example use of the rseq sched state. Signed-off-by: Mathieu Desnoyers --- tools/testing/selftests/rseq/.gitignore | 1 + tools/testing/selftests/rseq/Makefile | 3 +- tools/testing/selftests/rseq/rseq_mutex.c | 120 ++++++++++++++++++++++ 3 files changed, 123 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/rseq/rseq_mutex.c diff --git a/tools/testing/selftests/rseq/.gitignore b/tools/testing/selftests/rseq/.gitignore index a8db9f7a7cec..38d5b2fe5905 100644 --- a/tools/testing/selftests/rseq/.gitignore +++ b/tools/testing/selftests/rseq/.gitignore @@ -10,3 +10,4 @@ param_test_mm_cid param_test_mm_cid_benchmark param_test_mm_cid_compare_twice sched_state_test +rseq_mutex diff --git a/tools/testing/selftests/rseq/Makefile b/tools/testing/selftests/rseq/Makefile index 7c8f4f2be74c..a9d7ceb5b79b 100644 --- a/tools/testing/selftests/rseq/Makefile +++ b/tools/testing/selftests/rseq/Makefile @@ -14,7 +14,8 @@ OVERRIDE_TARGETS = 1 TEST_GEN_PROGS = basic_test basic_percpu_ops_test basic_percpu_ops_mm_cid_test param_test \ param_test_benchmark param_test_compare_twice param_test_mm_cid \ - param_test_mm_cid_benchmark param_test_mm_cid_compare_twice sched_state_test + param_test_mm_cid_benchmark param_test_mm_cid_compare_twice sched_state_test \ + rseq_mutex TEST_GEN_PROGS_EXTENDED = librseq.so diff --git a/tools/testing/selftests/rseq/rseq_mutex.c b/tools/testing/selftests/rseq/rseq_mutex.c new file mode 100644 index 000000000000..01afd6a0e8bd --- /dev/null +++ b/tools/testing/selftests/rseq/rseq_mutex.c @@ -0,0 +1,120 @@ +// SPDX-License-Identifier: LGPL-2.1 + +#define _GNU_SOURCE +#include +#include +#include +#include +#include +#include +#include + +#include "rseq.h" + +#define RSEQ_MUTEX_MAX_BUSY_LOOP 100 + +struct rseq_mutex { + /* + * When non-NULL, owner points to per-thread rseq_abi_sched_state of + * owner thread. + */ + struct rseq_abi_sched_state *owner; +}; + +static struct rseq_mutex lock = { .owner = NULL }; + +static int testvar; + +static void rseq_lock_slowpath(struct rseq_mutex *lock) +{ + int i = 0; + + for (;;) { + struct rseq_abi_sched_state *expected = NULL, *self = rseq_get_sched_state(rseq_get_abi()); + + if (__atomic_compare_exchange_n(&lock->owner, &expected, self, false, + __ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) + break; + //TODO: use rseq critical section to protect dereference of owner thread's + //rseq_abi_sched_state, combined with rseq fence at thread reclaim. + if ((RSEQ_READ_ONCE(expected->state) & RSEQ_ABI_SCHED_STATE_FLAG_ON_CPU) && + i < RSEQ_MUTEX_MAX_BUSY_LOOP) { + rseq_barrier(); /* busy-wait, e.g. cpu_relax(). */ + i++; + } else { + //TODO: Enqueue waiter in a wait-queue, and integrate + //with sys_futex rather than waiting for 10ms. + (void) poll(NULL, 0, 10); /* wait 10ms */ + } + } +} + +static void rseq_lock(struct rseq_mutex *lock) +{ + struct rseq_abi_sched_state *expected = NULL, *self = rseq_get_sched_state(rseq_get_abi()); + + if (__atomic_compare_exchange_n(&lock->owner, &expected, self, false, + __ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) + return; + rseq_lock_slowpath(lock); +} + +static void rseq_unlock(struct rseq_mutex *lock) +{ + __atomic_store_n(&lock->owner, NULL, __ATOMIC_RELEASE); + //TODO: integrate with sys_futex and wakeup oldest waiter. +} + +static +void *test_thread(void *arg) +{ + int i; + + if (rseq_register_current_thread()) { + fprintf(stderr, "Error: rseq_register_current_thread(...) failed(%d): %s\n", + errno, strerror(errno)); + abort(); + } + + for (i = 0; i < 1000; i++) { + int var; + + rseq_lock(&lock); + var = RSEQ_READ_ONCE(testvar); + if (var) { + fprintf(stderr, "Unexpected value %d\n", var); + abort(); + } + RSEQ_WRITE_ONCE(testvar, 1); + if (!(i % 10)) + (void) poll(NULL, 0, 10); + else + rseq_barrier(); + RSEQ_WRITE_ONCE(testvar, 0); + rseq_unlock(&lock); + } + + if (rseq_unregister_current_thread()) { + fprintf(stderr, "Error: rseq_unregister_current_thread(...) failed(%d): %s\n", + errno, strerror(errno)); + abort(); + } + return NULL; +} + +int main(int argc, char **argv) +{ + int nr_threads = 5; + pthread_t test_thread_id[nr_threads]; + int i; + + for (i = 0; i < nr_threads; i++) { + pthread_create(&test_thread_id[i], NULL, test_thread, NULL); + } + + for (i = 0; i < nr_threads; i++) { + pthread_join(test_thread_id[i], NULL); + } + + return 0; +}