diff mbox series

memblock: Update nid info in memblock debugfs

Message ID 20230529062002.157-1-ssawgyw@gmail.com
State New
Headers
Series memblock: Update nid info in memblock debugfs |

Commit Message

Yuwei Guan May 29, 2023, 6:20 a.m. UTC 
  The node id for memblock reserved regions will be wrong,
so let's show 'x' for reg->nid == MAX_NUMNODES in debugfs to keep it align.

Suggested-by: Mike Rapoport (IBM) <rppt@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Yuwei Guan <ssawgyw@gmail.com>
---
 mm/memblock.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Mike Rapoport June 1, 2023, 5:21 a.m. UTC | #1 
On Mon, May 29, 2023 at 02:20:02PM +0800, Yuwei Guan wrote:
> The node id for memblock reserved regions will be wrong,
> so let's show 'x' for reg->nid == MAX_NUMNODES in debugfs to keep it align.
> 
> Suggested-by: Mike Rapoport (IBM) <rppt@kernel.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Signed-off-by: Yuwei Guan <ssawgyw@gmail.com>

I believe this could use Co-developed-by tags.
Please take a look at Documentation/process/submitting-patches.rst

> ---
>  mm/memblock.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index c5c80d9bcea3..3d449aaba052 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -2169,17 +2169,21 @@ static int memblock_debug_show(struct seq_file *m, void *private)
>  {
>  	struct memblock_type *type = m->private;
>  	struct memblock_region *reg;
> -	int i, j;
> +	int i, j, nid;
>  	unsigned int count = ARRAY_SIZE(flagname);
>  	phys_addr_t end;
>  
>  	for (i = 0; i < type->cnt; i++) {
>  		reg = &type->regions[i];
>  		end = reg->base + reg->size - 1;
> +		nid = memblock_get_region_node(reg);
>  
>  		seq_printf(m, "%4d: ", i);
>  		seq_printf(m, "%pa..%pa ", &reg->base, &end);
> -		seq_printf(m, "%4d ", memblock_get_region_node(reg));
> +		if (nid != MAX_NUMNODES)
> +			seq_printf(m, "%4d ", nid);
> +		else
> +			seq_printf(m, "%4c ", 'x');
>  		if (reg->flags) {
>  			for (j = 0; j < count; j++) {
>  				if (reg->flags & (1U << j)) {
> -- 
> 2.34.1
>
Yuwei Guan June 1, 2023, 12:33 p.m. UTC | #2 
Mike Rapoport <rppt@kernel.org> 于2023年6月1日周四 13:21写道：
>
> On Mon, May 29, 2023 at 02:20:02PM +0800, Yuwei Guan wrote:
> > The node id for memblock reserved regions will be wrong,
> > so let's show 'x' for reg->nid == MAX_NUMNODES in debugfs to keep it align.
> >
> > Suggested-by: Mike Rapoport (IBM) <rppt@kernel.org>
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > Signed-off-by: Yuwei Guan <ssawgyw@gmail.com>
>
> I believe this could use Co-developed-by tags.
> Please take a look at Documentation/process/submitting-patches.rst
>
Hi Mike,

Thanks, I will look into it, and resend this patch soon.
> > ---
> >  mm/memblock.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/memblock.c b/mm/memblock.c
> > index c5c80d9bcea3..3d449aaba052 100644
> > --- a/mm/memblock.c
> > +++ b/mm/memblock.c
> > @@ -2169,17 +2169,21 @@ static int memblock_debug_show(struct seq_file *m, void *private)
> >  {
> >       struct memblock_type *type = m->private;
> >       struct memblock_region *reg;
> > -     int i, j;
> > +     int i, j, nid;
> >       unsigned int count = ARRAY_SIZE(flagname);
> >       phys_addr_t end;
> >
> >       for (i = 0; i < type->cnt; i++) {
> >               reg = &type->regions[i];
> >               end = reg->base + reg->size - 1;
> > +             nid = memblock_get_region_node(reg);
> >
> >               seq_printf(m, "%4d: ", i);
> >               seq_printf(m, "%pa..%pa ", &reg->base, &end);
> > -             seq_printf(m, "%4d ", memblock_get_region_node(reg));
> > +             if (nid != MAX_NUMNODES)
> > +                     seq_printf(m, "%4d ", nid);
> > +             else
> > +                     seq_printf(m, "%4c ", 'x');
> >               if (reg->flags) {
> >                       for (j = 0; j < count; j++) {
> >                               if (reg->flags & (1U << j)) {
> > --
> > 2.34.1
> >
>
> --
> Sincerely yours,
> Mike.
diff mbox series

Patch

diff --git a/mm/memblock.c b/mm/memblock.c
index c5c80d9bcea3..3d449aaba052 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -2169,17 +2169,21 @@  static int memblock_debug_show(struct seq_file *m, void *private)
 {
 	struct memblock_type *type = m->private;
 	struct memblock_region *reg;
-	int i, j;
+	int i, j, nid;
 	unsigned int count = ARRAY_SIZE(flagname);
 	phys_addr_t end;
 
 	for (i = 0; i < type->cnt; i++) {
 		reg = &type->regions[i];
 		end = reg->base + reg->size - 1;
+		nid = memblock_get_region_node(reg);
 
 		seq_printf(m, "%4d: ", i);
 		seq_printf(m, "%pa..%pa ", &reg->base, &end);
-		seq_printf(m, "%4d ", memblock_get_region_node(reg));
+		if (nid != MAX_NUMNODES)
+			seq_printf(m, "%4d ", nid);
+		else
+			seq_printf(m, "%4c ", 'x');
 		if (reg->flags) {
 			for (j = 0; j < count; j++) {
 				if (reg->flags & (1U << j)) {