From patchwork Sun May 28 19:09:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 99926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1134601vqr; Sun, 28 May 2023 13:53:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7F99Hi6DMspvlqL+IPMOKqqbZTwm/uhY5Y8KeWucz587kFHIec/93KbG4SNtAqVrw8ssNP X-Received: by 2002:a05:6a00:194a:b0:63b:7a55:ae89 with SMTP id s10-20020a056a00194a00b0063b7a55ae89mr12732499pfk.27.1685307230438; Sun, 28 May 2023 13:53:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685307230; cv=none; d=google.com; s=arc-20160816; b=JmMKSiUfYkaAzf/bGdV8FBZBzaXUbw8fOJzaIB9c+wAFxB/Mmh6WLdGgWHlIlGfTed RwxpM9SsqB9pe/Ac3d8sEkkoTYTPHceML0Fg/hTveyBlx0DA8wX4x2KL6fNyYwBoRxBz xtuHxj3YtY9Yrmhrs7Mmynz5uxSb1sRtR1/zPAAgLdZgCsvyLDcIB2T4szXg/YhOojU3 YSegpCH1nBGa/9P2G8ylw2fM2ddgtVHJ+WX4dk8t2oRxx1Qws9hXTrGAR0b+3FtehEAe GqhTjcTtTstMHN8JiHqm6AMgTZxwx5DnFM5EH+/gLbt69++8aMpIRKi702jPetmDtQ49 QtIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Eq/czt7O8sV5mAj8KzPvJo+euXSP794hbyLqIjZ4eJc=; b=M83ejusPB+1MaKqS7+eqfezpWDNQaXNz5i+nxttwYGRmYbRbm/Mk8EmbbK+IynLyV3 Zal0PEYhtL5nfDsUFeRS0Xhsrs1LZdKX7azlhm6oS8KoX2QAFRSUlxSQ+XIEIAtbNNDN IKSuD1GM+hJd7BBhfuTZwk/PHAQl+5Zj7oKz94VgSQP9IxHDNDcc/lSFP2dak6ZWyjUq UVvf12KCZJz5TFKuaiThj+/HEqwpWfUW3w5S0BfxQUAgPbR+cng3UG5XRwOu/Ou2UOHl M/OeAa1dq7oDMDMKSxtYwBSX1G79k2Kdl4MOudguwPb8C54hqCViOlH00/SXXm/cZHKR Hkkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yLZtjeSN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x21-20020aa78f15000000b00642ea71f6d9si4619056pfr.336.2023.05.28.13.53.34; Sun, 28 May 2023 13:53:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=yLZtjeSN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbjE1T3H (ORCPT + 99 others); Sun, 28 May 2023 15:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjE1T3C (ORCPT ); Sun, 28 May 2023 15:29:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE66BFF; Sun, 28 May 2023 12:28:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E29C61D13; Sun, 28 May 2023 19:28:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52876C433EF; Sun, 28 May 2023 19:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685302136; bh=5ggJml8Y0RdYXX3sXuOlmebpMMjT9tIUaTbIoZT4CQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yLZtjeSNITkCY8Z5dHB0SesboAQzp5YJ8WJ4zR0h7yDVDGXx/Gsy1LlSlfec2nCqB xSrHHbW79esCFJITxADKGhjtRZNjLApxiYOohWQ6JjiZwCwVko4UbT3Wboo0MLcsf2 djj5SW32DuOvqhWHeIVh/DPFbZfmgHRnf8HGwp/A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Arcari , Jithu Joseph , Ashok Raj , Tony Luck , Hans de Goede , Mark Gross , Thomas Gleixner , Dan Williams , linux-kernel@vger.kernel.org Subject: [PATCH 6.3 014/127] platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain Date: Sun, 28 May 2023 20:09:50 +0100 Message-Id: <20230528190836.689708217@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230528190836.161231414@linuxfoundation.org> References: <20230528190836.161231414@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767172714421116926?= X-GMAIL-MSGID: =?utf-8?q?1767172714421116926?= From: David Arcari commit 3279decb2c3c8d58cb0b70ed5235c480735a36ee upstream. Object Debug results in the following warning while attempting to load ifs firmware: [ 220.007422] ODEBUG: object 000000003bf952db is on stack 00000000e843994b, but NOT annotated. [ 220.007459] ------------[ cut here ]------------ [ 220.007461] WARNING: CPU: 0 PID: 11774 at lib/debugobjects.c:548 __debug_object_init.cold+0x22e/0x2d5 [ 220.137476] RIP: 0010:__debug_object_init.cold+0x22e/0x2d5 [ 220.254774] Call Trace: [ 220.257641] [ 220.265606] scan_chunks_sanity_check+0x368/0x5f0 [intel_ifs] [ 220.288292] ifs_load_firmware+0x2a3/0x400 [intel_ifs] [ 220.332793] current_batch_store+0xea/0x160 [intel_ifs] [ 220.357947] kernfs_fop_write_iter+0x355/0x530 [ 220.363048] new_sync_write+0x28e/0x4a0 [ 220.381226] vfs_write+0x62a/0x920 [ 220.385160] ksys_write+0xf9/0x1d0 [ 220.399421] do_syscall_64+0x59/0x90 [ 220.440635] entry_SYSCALL_64_after_hwframe+0x63/0xcd [ 220.566845] ---[ end trace 3a01b299db142b41 ]--- Correct this by calling INIT_WORK_ONSTACK instead of INIT_WORK. Fixes: 684ec215706d ("platform/x86/intel/ifs: Authenticate and copy to secured memory") Signed-off-by: David Arcari Cc: Jithu Joseph Cc: Ashok Raj Cc: Tony Luck Cc: Hans de Goede Cc: Mark Gross Cc: Greg Kroah-Hartman Cc: Thomas Gleixner Cc: Dan Williams Cc: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230523105400.674152-1-darcari@redhat.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/intel/ifs/load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/x86/intel/ifs/load.c +++ b/drivers/platform/x86/intel/ifs/load.c @@ -208,7 +208,7 @@ static int scan_chunks_sanity_check(stru continue; reinit_completion(&ifs_done); local_work.dev = dev; - INIT_WORK(&local_work.w, copy_hashes_authenticate_chunks); + INIT_WORK_ONSTACK(&local_work.w, copy_hashes_authenticate_chunks); schedule_work_on(cpu, &local_work.w); wait_for_completion(&ifs_done); if (ifsd->loading_error) {