From patchwork Sun May 28 05:17:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 99874 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp763844vqr; Sat, 27 May 2023 22:45:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ISo7REtITWXrkJQXIYJKPj/YMvHSE5Hg6ikFEsqNA/truBhGZCW2El1mZIk1L7fKVXxo/ X-Received: by 2002:a17:902:f687:b0:1b0:1d7b:ed33 with SMTP id l7-20020a170902f68700b001b01d7bed33mr6631331plg.69.1685252755584; Sat, 27 May 2023 22:45:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685252755; cv=none; d=google.com; s=arc-20160816; b=yjclqUbvO2TjN5o8oAGFOZMKqI4XtvQJN/N+FhjBrCG8d/uodLlJuV+VBaTWR2e805 z1HfzaYwGtl+xAdm2loV2FVMOxxW7ShXWFHWueE6Uuwvi60ngBYpKRT1e8+oiB3BXqEX 08Zyu87zKMjZ4ZueBD5M5KUD5wQcgt8wM2RtW1aoreslK6OQrdhqRxorrcmquqlz3Sq3 thzbI6V1RBXsb4DlXK7JyVe2MENxNDtwYBSPC/gLmtwfxRawagp1kSTEBar1/3RfGpvG 8Ve58yTFdiLMiAhHrhu5hhDSx2AyAgkxb+ZeBXV4a1I/eZ9cPooOysfg3ya0RnzbGil1 ZKow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NNdC3kqZxmu0p/NKkaMX6wQm7QKMNe9qlBseZo36tY8=; b=bXGtRm7wJlgOD2n1VtCsWKV4yc2cR3shbQl2OZppYLXaVcxLn8Asluf1BDAt67gYY7 gLicH4dKmOuPy8RhT6xGxjuS7Omw1V1jLPAHdZWw8/NeELMRLrGyL8RN+ogGS39AhADc ng8c5ltz+zujpR4Ft2E8mtxVOAUF0T3osWtfkcyZyb82AIwQ6xXtYFrHXBFlqsVfK5pn uqyapJuMWb1jwh49eyAZbigzojrwvTsfjDbLhVjS1OOx2AyQxPzsA/Sx/NxzAqyfWEDM vKXTBwu2+OZxW997YG2ut6pYbW7G6RiP3UmrUEBNtdGXb37F2xfbnf9b2CJ8ans61KZw Ua+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a1709028ec500b001a699fc81e8si7496145plo.98.2023.05.27.22.45.37; Sat, 27 May 2023 22:45:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbjE1F0x (ORCPT + 99 others); Sun, 28 May 2023 01:26:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjE1F0r (ORCPT ); Sun, 28 May 2023 01:26:47 -0400 X-Greylist: delayed 525 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 27 May 2023 22:26:40 PDT Received: from mammoth.local.home (cpe-172-100-189-27.stny.res.rr.com [172.100.189.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 94AC7D8; Sat, 27 May 2023 22:26:40 -0700 (PDT) Received: by mammoth.local.home (Postfix, from userid 5657) id D650C30113E; Sun, 28 May 2023 01:17:53 -0400 (EDT) From: Steven Rostedt To: LKML , Linux trace kernel Cc: Masami Hiramatsu , Mark Rutland , "Steven Rostedt (Google)" Subject: [PATCH 5/5] tracing: Have function_graph selftest call cond_resched() Date: Sun, 28 May 2023 01:17:42 -0400 Message-Id: <20230528051742.1325503-6-rostedt@goodmis.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230528051742.1325503-1-rostedt@goodmis.org> References: <20230528051742.1325503-1-rostedt@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, PDS_RDNS_DYNAMIC_FP,RCVD_IN_PBL,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767115593527668119?= X-GMAIL-MSGID: =?utf-8?q?1767115593527668119?= From: "Steven Rostedt (Google)" When all kernel debugging is enabled (lockdep, KSAN, etc), the function graph enabling and disabling can take several seconds to complete. The function_graph selftest enables and disables function graph tracing several times. With full debugging enabled, the soft lockup watchdog was triggering because the selftest was running without ever scheduling. Add cond_resched() throughout the test to make sure it does not trigger the soft lockup detector. Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_selftest.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c index a931d9aaea26..529590499b1f 100644 --- a/kernel/trace/trace_selftest.c +++ b/kernel/trace/trace_selftest.c @@ -848,6 +848,12 @@ trace_selftest_startup_function_graph(struct tracer *trace, } #ifdef CONFIG_DYNAMIC_FTRACE_WITH_DIRECT_CALLS + /* + * These tests can take some time to run. Make sure on non PREEMPT + * kernels, we do not trigger the softlockup detector. + */ + cond_resched(); + tracing_reset_online_cpus(&tr->array_buffer); set_graph_array(tr); @@ -869,6 +875,8 @@ trace_selftest_startup_function_graph(struct tracer *trace, if (ret) goto out; + cond_resched(); + ret = register_ftrace_graph(&fgraph_ops); if (ret) { warn_failed_init_tracer(trace, ret); @@ -891,6 +899,8 @@ trace_selftest_startup_function_graph(struct tracer *trace, if (ret) goto out; + cond_resched(); + tracing_start(); if (!ret && !count) {