diff mbox series

hwmon: (oxp-sensors) Differentiate new BIOS for the Mini

Message ID 20230526215621.16075-1-samsagax@gmail.com
State New
Headers
Series hwmon: (oxp-sensors) Differentiate new BIOS for the Mini |

Commit Message

Joaquín Ignacio Aramendía May 26, 2023, 9:56 p.m. UTC 
  Newer BIOS got some other changes aside from string changes. Add a board
enum to differentiate it from the old OneXplayer Mini AMD BIOS.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
---
 drivers/hwmon/oxp-sensors.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Guenter Roeck May 26, 2023, 11:31 p.m. UTC | #1 
On Fri, May 26, 2023 at 06:56:22PM -0300, Joaquín Ignacio Aramendía wrote:
> Newer BIOS got some other changes aside from string changes. Add a board
> enum to differentiate it from the old OneXplayer Mini AMD BIOS.
> 

I see no functional difference. What is the point of this change ?

Thanks,
Guenter

> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> ---
>  drivers/hwmon/oxp-sensors.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index 0ec7588610ad..423307ed4930 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -47,6 +47,7 @@ enum oxp_board {
>  	aya_neo_air_pro,
>  	aya_neo_geek,
>  	oxp_mini_amd,
> +	oxp_mini_amd_a07,
>  	oxp_mini_amd_pro,
>  };
>  
> @@ -104,7 +105,7 @@ static const struct dmi_system_id dmi_table[] = {
>  			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
>  			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER mini A07"),
>  		},
> -		.driver_data = (void *)oxp_mini_amd,
> +		.driver_data = (void *)oxp_mini_amd_a07,
>  	},
>  	{
>  		.matches = {
> @@ -206,6 +207,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
>  			case aya_neo_air_pro:
>  			case aya_neo_geek:
>  			case oxp_mini_amd:
> +			case oxp_mini_amd_a07:
>  				*val = (*val * 255) / 100;
>  				break;
>  			case oxp_mini_amd_pro:
> @@ -247,6 +249,7 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
>  			case aya_neo_air_pro:
>  			case aya_neo_geek:
>  			case oxp_mini_amd:
> +			case oxp_mini_amd_a07:
>  				val = (val * 100) / 255;
>  				break;
>  			case aok_zoe_a1:
> -- 
> 2.40.1
>
Joaquín Ignacio Aramendía May 26, 2023, 11:42 p.m. UTC | #2 
> On Fri, May 26, 2023 at 06:56:22PM -0300, Joaquín Ignacio Aramendía wrote:
> > Newer BIOS got some other changes aside from string changes. Add a board
> > enum to differentiate it from the old OneXplayer Mini AMD BIOS.
> >
>
> I see no functional difference. What is the point of this change ?
>
> Thanks,
> Guenter

It is nothing right now, honestly. But is necessary for a later change
i have queued and a bit of OCD on my part. Should I add this to the
other change?

Joaquín I. Aramendía
Guenter Roeck May 27, 2023, 12:19 p.m. UTC | #3 
On Fri, May 26, 2023 at 08:42:51PM -0300, Joaquin Aramendia wrote:
> > On Fri, May 26, 2023 at 06:56:22PM -0300, Joaquín Ignacio Aramendía wrote:
> > > Newer BIOS got some other changes aside from string changes. Add a board
> > > enum to differentiate it from the old OneXplayer Mini AMD BIOS.
> > >
> >
> > I see no functional difference. What is the point of this change ?
> >
> > Thanks,
> > Guenter
> 
> It is nothing right now, honestly. But is necessary for a later change
> i have queued and a bit of OCD on my part. Should I add this to the
> other change?
> 

It can stay as separate patch, but please resubmit it together with
the patch(es) actually using it.

Guenter
Joaquín Ignacio Aramendía May 27, 2023, 12:55 p.m. UTC | #4 
I have resubmitted the change that uses this that includes this change. So
drip this one and let's continue the review on the other.

Thanks!
Joaquín I Aramendía
diff mbox series

Patch

diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index 0ec7588610ad..423307ed4930 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -47,6 +47,7 @@  enum oxp_board {
 	aya_neo_air_pro,
 	aya_neo_geek,
 	oxp_mini_amd,
+	oxp_mini_amd_a07,
 	oxp_mini_amd_pro,
 };
 
@@ -104,7 +105,7 @@  static const struct dmi_system_id dmi_table[] = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER mini A07"),
 		},
-		.driver_data = (void *)oxp_mini_amd,
+		.driver_data = (void *)oxp_mini_amd_a07,
 	},
 	{
 		.matches = {
@@ -206,6 +207,7 @@  static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
 			case aya_neo_air_pro:
 			case aya_neo_geek:
 			case oxp_mini_amd:
+			case oxp_mini_amd_a07:
 				*val = (*val * 255) / 100;
 				break;
 			case oxp_mini_amd_pro:
@@ -247,6 +249,7 @@  static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
 			case aya_neo_air_pro:
 			case aya_neo_geek:
 			case oxp_mini_amd:
+			case oxp_mini_amd_a07:
 				val = (val * 100) / 255;
 				break;
 			case aok_zoe_a1: