From patchwork Sat May 27 01:41:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 99748 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp82085vqr; Fri, 26 May 2023 19:15:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jb2AJ5t7H7hs1sgAJzB8Lv2XPglp9Dx2+pZNd7JF5yQLRvkhryEz7UElg2xTwjIvdDwi3 X-Received: by 2002:a17:902:7790:b0:1af:b049:b32e with SMTP id o16-20020a170902779000b001afb049b32emr4039810pll.56.1685153702760; Fri, 26 May 2023 19:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685153702; cv=none; d=google.com; s=arc-20160816; b=qHQf6NTrSvVnr5dS/Xnyei856Kzyw2Hmw0VsP5iy5JOE3Jh2SvKOCSRYXhOin/CZSM nY2Bwe84/PaR0dxckBFL4hnWpp6WJx7fWHzdDWqqX6f71FdOhIDuilBiOA1Qp92JXnTz Cw3QI65zUAkpn6FIGZ7W7Qn4j+9MdeLf3cJtIiRORA2YBg5NNMPGqIqsrmdi5e9tUJtH +TpsQ0vFTY8SCbQfd5VCXCjR/hxQM1isvf+9uJq21wgYsEqolYx2UO07Zx7AuWk7X36y heUH9g0yAefPCql5KqXLyS7JpSfeKoEiXh2BA+M3msARZ4XEnLugLafURuI65abh0bRO y6/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hhZKQ5chvzZjdXAK7yuxvuaTNwo4ZylkC6Gy3ujvEec=; b=plaDVXoUeXTNhJKI1+oWOKATp/CpVoFmhr0k7OCVp5Aez6W3HkqgdlQVjprzWw/5Ji ivj9NXmJ0I73s0LmAm9e9nh7kIklSToEcYMcdaeWs1WYNgELdI1ot3StT5HRrXUyQxVf HXiPoeXdUIslLAuQI5btlZQLGlJCDPIqIXlIJd/kx+ib+I2RH9QhE9obMGwdbvSoFd9h dgY9LO5kkTe/6sKI2tl/Gv8S3X8WWQDNnDDyVTNsvNmhzrGwgVmVXudK/t1TfLcNtYVC A8lug8HJJKpghqKfMGiVJcSs3tePWLK/u2q1a1fD+pvETzip9ja9RDoYfvoC7evoo02E nEQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Aa2FnlO7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h128-20020a636c86000000b00528d90d40e4si4703610pgc.88.2023.05.26.19.14.47; Fri, 26 May 2023 19:15:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Aa2FnlO7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244148AbjE0BnJ (ORCPT + 99 others); Fri, 26 May 2023 21:43:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243853AbjE0Bmt (ORCPT ); Fri, 26 May 2023 21:42:49 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF4DDE4B for ; Fri, 26 May 2023 18:42:30 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-64d30ab1ef2so1217221b3a.2 for ; Fri, 26 May 2023 18:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685151750; x=1687743750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hhZKQ5chvzZjdXAK7yuxvuaTNwo4ZylkC6Gy3ujvEec=; b=Aa2FnlO7cA7GOt4jdHYmDdd1WDaYmdWhcVEaBF5A+6UaJVFXdOsQgbvTyfqoPjk4bh xDmNcaix5P9IJQEn4sRdp17S3cm+b5XkOk0LLoDg2dgEdaX2+JASBn14gthkz9JJvjeq /e8LlbDE1Czum9F+Yjho76XQANK+Ly3h8sjUk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685151750; x=1687743750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hhZKQ5chvzZjdXAK7yuxvuaTNwo4ZylkC6Gy3ujvEec=; b=Sxx0umG54cRN8epyzPjVKW35smt6Zal0sGkE4wwebusiDErLtDBfPMhfz3upDU50o/ ViCIWi71b+How6yEQwIDQUHZ9FB7MWgbUEBu2lIjjhLKc3+0JMIveyFEe0R/y1RNCpn3 z3cbr90zcaZHH3uSzRfzwsyvMcgd+R8w9VplzxdcRzal6fjlG40QzBUFXisP9nlw8W7F 9lIHRM414rZcNtanZ+NAALMuDV70Y7ITY57T8MvZoehkopPlXjJmA0fN7bWfgZ0IZAxr PzM9VKhCdI06rN+iciKyCRHfXQjBk2GEJ+z9vpw+z7o4KPJyiMT9LZn0zF/MTie3aq0w JK1g== X-Gm-Message-State: AC+VfDzR2vYlwTxq6uZE6VAtdNDkXWMVaBhFOQwXszkdUlcG9OSS3PA8 XW1eqWoCnZ5hGj2hyl6dJQbyxw== X-Received: by 2002:a05:6a00:3911:b0:63d:2f13:200 with SMTP id fh17-20020a056a00391100b0063d2f130200mr6100546pfb.16.1685151750426; Fri, 26 May 2023 18:42:30 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:4015:7255:c79a:26d7]) by smtp.gmail.com with ESMTPSA id x25-20020aa79199000000b0063b8ddf77f7sm3202440pfa.211.2023.05.26.18.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 18:42:29 -0700 (PDT) From: Douglas Anderson To: Petr Mladek , Andrew Morton Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, Nicholas Piggin , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , sparclinux@vger.kernel.org, "David S . Miller" , linux-perf-users@vger.kernel.org, Douglas Anderson Subject: [PATCH 08/10] watchdog/buddy: Simplify the dependency for HARDLOCKUP_DETECTOR_PREFER_BUDDY Date: Fri, 26 May 2023 18:41:38 -0700 Message-ID: <20230526184139.8.I49d5b483336b65b8acb1e5066548a05260caf809@changeid> X-Mailer: git-send-email 2.41.0.rc0.172.g3f132b7071-goog In-Reply-To: <20230527014153.2793931-1-dianders@chromium.org> References: <20230527014153.2793931-1-dianders@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767011729184563090?= X-GMAIL-MSGID: =?utf-8?q?1767011729184563090?= The dependency for HARDLOCKUP_DETECTOR_PREFER_BUDDY was more complicated than it needed to be. If the "perf" detector is available and we have SMP then we have a choice, so enable the config based on just those two config items. Suggested-by: Petr Mladek Signed-off-by: Douglas Anderson Reviewed-by: Petr Mladek --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index c9df93402237..eb1edd5905bc 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1065,7 +1065,7 @@ config HAVE_HARDLOCKUP_DETECTOR_NON_ARCH config HARDLOCKUP_DETECTOR_PREFER_BUDDY bool "Prefer the buddy CPU hardlockup detector" - depends on HAVE_HARDLOCKUP_DETECTOR_NON_ARCH && HAVE_HARDLOCKUP_DETECTOR_PERF && SMP + depends on HAVE_HARDLOCKUP_DETECTOR_PERF && SMP help Say Y here to prefer the buddy hardlockup detector over the perf one.