From patchwork Mon Jun 12 18:24:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 106762 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp65538vqr; Mon, 12 Jun 2023 11:46:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ76pF4so+m/O66mihi+VVYMP280sxrME8YPdzyemvQxHxGKTwdZb0WIy8lfnLVTR//P2oq/ X-Received: by 2002:a17:902:c943:b0:1b2:499f:674f with SMTP id i3-20020a170902c94300b001b2499f674fmr8131090pla.25.1686595582737; Mon, 12 Jun 2023 11:46:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686595582; cv=none; d=google.com; s=arc-20160816; b=isaY2VGMv4t9O9VoYlekqGdvhtfPQvsNgGHyQ5iGiQU1rO2PRrCoX8wApq2rEeewhu 3I3aahxBn2sepm/zbAhRUEIXg4OevpDGzDgsHcmFoX3IhoFDqnmzUON6T7nMyUcqy/dc kNFH7alUbkZVL8t0jLxgYEKcZkkI20lU3aVRS/Jz/I+Qc/+fwJ5W1ePUFUzPKecnRM3j tfCrNr7XwqIMNQw2IPsniBHwgN8HVBdKDTBV+hSsuQrAk4sleMZFKbFAAQFl8sdIB1ew A+51GsHIIEjsUz8IlUJAR2P6xicIbj4LMJ1VXQhmEdBA/U5iHyVoMrKeTQs7als2RKL1 n1Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=UIodkBRlayT0V/9pD2j/FIbmEOwVzB4ZwEjxODurwXg=; b=lWVdT4OAutypSsf7Otx8PKDxYPQhfM5ZeD5YygHj4iauKdFp5niWBKDGhDLlH5cWV/ k6X/qe7f6bGVo/mZlkQxg9KEYt9XgPctL4h9ETib/zoeA43TnuAevmZ4o4kBO/H+I1GJ y1iEoi1HJAHdWpT89tXkmAz/y7YDEXWS8VD0CCJ2Wpz4IoewbKroTRn8qFiVd3ec4FdV CTctWx9PqSUC/XByrQoZkaR56FaYGdF617EZYpHaqyS/wahJVpmloT5UCuAgXYySmEkw AtChe5fSMxqMp1bdK+4F1NqTCzE3C+6eFUL9++cSNCEO3YaPnAaIdr5wCCH+LnOyH3AI J2MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="TvL/4HpK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id le8-20020a170902fb0800b001b24857d1c4si3839059plb.508.2023.06.12.11.46.00; Mon, 12 Jun 2023 11:46:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="TvL/4HpK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237801AbjFLSZe (ORCPT + 99 others); Mon, 12 Jun 2023 14:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238094AbjFLSZM (ORCPT ); Mon, 12 Jun 2023 14:25:12 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 098F8E69 for ; Mon, 12 Jun 2023 11:25:10 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f63a2e1c5fso5589626e87.2 for ; Mon, 12 Jun 2023 11:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686594308; x=1689186308; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UIodkBRlayT0V/9pD2j/FIbmEOwVzB4ZwEjxODurwXg=; b=TvL/4HpKtWb+k6gMVu3rM/mxPnEc/LH21sIRnm6hq4G1BnkASKfttpKtNiNd3icsAS rgCnMsA+7Ovknx8I6gjBSwMijDDVDMTtHX/uErv7FvP255E1acNRJPjP0ntoUy2fySNE Pj+VgHbkD155XRUUzKo9eMaXLo2InLXH52TR/CsuXxn0E25rqU9mImrojU6ie3miDwNm EUv/s9WjEIRxrgErEeL6tmAiZET273qvn6+zzayO+KMMrn5TKI/H3LLogobR2p9c9iUK zSLvHJYROp6xRG13qkVHAYh6hVbu2qQpcFovt5WcXnxP9+iWFw9TyezFU7EbUV3DlluU j0ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686594308; x=1689186308; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UIodkBRlayT0V/9pD2j/FIbmEOwVzB4ZwEjxODurwXg=; b=Yyi4aayzYuW9WbVj2qTSp2Xg6TTo8PSFcZAFbruTlh950t1zPky212ysXPq65fJqMY /20sbgFE1TEHHeM4quRj2ogtmH3DNXRR4d0SXvY3t9TmF0IPmfWCbPx+j7MsCWNeRuyx OPANvF0xP4RW3uXqf75OPXHzDoaTwWRFBEphjDq1flW0dDFYn0hH57KwHD0giLw2klhM vVda1mfMssqmmza7BxgLEvcA9dSttwYRohp+xEDsU34N8NHsjp9QdLefXbV/oW5dtQ3s pjeA2dHMzI9mf1itvx4SWM6rjEpTT9QZltI/qJbwcv6xBDTLrY4sTsfRXKiLI5i1Kofa KblA== X-Gm-Message-State: AC+VfDy4fPxGHDLkySOhXmOw48LM/6syWvBMq6xgL5vewmtT3RtZtLpt SjSx/E5BDdF8tbvOeZ1DsTguKg== X-Received: by 2002:a05:6512:46a:b0:4f4:cd03:cec8 with SMTP id x10-20020a056512046a00b004f4cd03cec8mr5499858lfd.51.1686594308282; Mon, 12 Jun 2023 11:25:08 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id v24-20020ac25938000000b004f64073a252sm1502035lfi.96.2023.06.12.11.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:25:07 -0700 (PDT) From: Konrad Dybcio Date: Mon, 12 Jun 2023 20:24:39 +0200 Subject: [PATCH v3 22/23] interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req MIME-Version: 1.0 Message-Id: <20230526-topic-smd_icc-v3-22-5fb7d39b874f@linaro.org> References: <20230526-topic-smd_icc-v3-0-5fb7d39b874f@linaro.org> In-Reply-To: <20230526-topic-smd_icc-v3-0-5fb7d39b874f@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Georgi Djakov , Leo Yan , Evan Green , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Stephan Gerhold X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1686594276; l=1241; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=9Ldf/1D6mnr+DmG72PIWvhQfT7N7aniAjBwqWygdML0=; b=0neN5UyCnSYJ6t+VeLO5GgXbU3AUqIZD2454T+xAoOEeEiGAVAdpNgAN0RwtWuRNKN9szCHIX 9lbs9imkG0tCHqVb43vFt1CdPrB8oSoriJlVZs0xB6n1AYksNjN2kjY X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768523649733286026?= X-GMAIL-MSGID: =?utf-8?q?1768523649733286026?= Currently, we're setting the aggregated-on-provider bandwidth on each node, individually. That is of course incorrect and results in far too high votes. Use the correct values to ensure we're not wasting power. Fixes: 30c8fa3ec61a ("interconnect: qcom: Add MSM8916 interconnect provider driver") Reported-by: Stephan Gerhold Reviewed-by: Stephan Gerhold Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/icc-rpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c index 8e4eb0b90905..989b8a1de6d1 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -355,12 +355,12 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg); - ret = qcom_icc_rpm_set(src_qn, agg_avg); + ret = qcom_icc_rpm_set(src_qn, src_qn->sum_avg); if (ret) return ret; if (dst_qn) { - ret = qcom_icc_rpm_set(dst_qn, agg_avg); + ret = qcom_icc_rpm_set(dst_qn, dst_qn->sum_avg); if (ret) return ret; }