diff mbox series

[01/20] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM

Message ID	20230526-topic-smd_icc-v1-1-1bf8e6663c4e@linaro.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Konrad Dybcio <konrad.dybcio@linaro.org> Date: Tue, 30 May 2023 12:20:00 +0200 Subject: [PATCH 01/20] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230526-topic-smd_icc-v1-1-1bf8e6663c4e@linaro.org> References: <20230526-topic-smd_icc-v1-0-1bf8e6663c4e@linaro.org> In-Reply-To: <20230526-topic-smd_icc-v1-0-1bf8e6663c4e@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Georgi Djakov <djakov@kernel.org>, Leo Yan <leo.yan@linaro.org>, Evan Green <evgreen@chromium.org> Cc: Marijn Suijten <marijn.suijten@somainline.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Konrad Dybcio <konrad.dybcio@linaro.org> Precedence: bulk
Series	Restructure RPM SMD ICC \| [00/20] Restructure RPM SMD ICC [01/20] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM [02/20] clk: qcom: smd-rpm: Move some RPM resources to the common header [03/20] clk: qcom: smd-rpm: Separate out interconnect bus clocks [04/20] clk: qcom: smd-rpm: Export clock scaling availability [05/20] interconnect: qcom: icc-rpm: Introduce keep_alive [06/20] interconnect: qcom: icc-rpm: Allow negative QoS offset [07/20] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h [08/20] interconnect: qcom: smd-rpm: Add rpmcc handling skeleton code [09/20] interconnect: qcom: Add missing headers in icc-rpm.h [10/20] interconnect: qcom: Define RPM bus clocks [11/20] interconnect: qcom: sdm660: Hook up RPM bus clk definitions [12/20] interconnect: qcom: msm8996: Hook up RPM bus clk definitions [13/20] interconnect: qcom: qcs404: Hook up RPM bus clk definitions [14/20] interconnect: qcom: msm8939: Hook up RPM bus clk definitions [15/20] interconnect: qcom: msm8916: Hook up RPM bus clk definitions [16/20] interconnect: qcom: qcm2290: Hook up RPM bus clk definitions [17/20] interconnect: qcom: icc-rpm: Control bus rpmcc from icc [18/20] interconnect: qcom: icc-rpm: Fix bucket number [19/20] interconnect: qcom: icc-rpm: Set bandwidth on both contexts [20/20] interconnect: qcom: Divide clk rate by src node bus width

Commit Message

Konrad Dybcio May 30, 2023, 10:20 a.m. UTC

  Add a preprocessor define to indicate the number of RPM contexts/states.
While at it, use tabs instead of spaces for the existing entries.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 include/linux/soc/qcom/smd-rpm.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Dmitry Baryshkov June 1, 2023, 9:20 a.m. UTC | #1

On 30/05/2023 13:20, Konrad Dybcio wrote:
> Add a preprocessor define to indicate the number of RPM contexts/states.
> While at it, use tabs instead of spaces for the existing entries.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   include/linux/soc/qcom/smd-rpm.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h
> index 2990f425fdef..99499e4b080e 100644
> --- a/include/linux/soc/qcom/smd-rpm.h
> +++ b/include/linux/soc/qcom/smd-rpm.h
> @@ -4,8 +4,9 @@
>   
>   struct qcom_smd_rpm;
>   
> -#define QCOM_SMD_RPM_ACTIVE_STATE        0
> -#define QCOM_SMD_RPM_SLEEP_STATE         1
> +#define QCOM_SMD_RPM_ACTIVE_STATE	0
> +#define QCOM_SMD_RPM_SLEEP_STATE	1

This is what we usually try to abstain from: ident changes + functional 
changes. I'd say, leave spaces as is and just add the new entry.

> +#define QCOM_SMD_RPM_STATE_NUM		2
>   
>   /*
>    * Constants used for addressing resources in the RPM.
>

Konrad Dybcio June 1, 2023, 10:01 a.m. UTC | #2

On 1.06.2023 11:20, Dmitry Baryshkov wrote:
> On 30/05/2023 13:20, Konrad Dybcio wrote:
>> Add a preprocessor define to indicate the number of RPM contexts/states.
>> While at it, use tabs instead of spaces for the existing entries.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   include/linux/soc/qcom/smd-rpm.h | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h
>> index 2990f425fdef..99499e4b080e 100644
>> --- a/include/linux/soc/qcom/smd-rpm.h
>> +++ b/include/linux/soc/qcom/smd-rpm.h
>> @@ -4,8 +4,9 @@
>>     struct qcom_smd_rpm;
>>   -#define QCOM_SMD_RPM_ACTIVE_STATE        0
>> -#define QCOM_SMD_RPM_SLEEP_STATE         1
>> +#define QCOM_SMD_RPM_ACTIVE_STATE    0
>> +#define QCOM_SMD_RPM_SLEEP_STATE    1
> 
> This is what we usually try to abstain from: ident changes + functional changes. I'd say, leave spaces as is and just add the new entry.
I think I might wanna turn this into an enum..

Also, I'd like to rename it but that's a story for another day, as
it'd require even more messy merging..

Konrad
> 
>> +#define QCOM_SMD_RPM_STATE_NUM        2
>>     /*
>>    * Constants used for addressing resources in the RPM.
>>
>

diff mbox series

Patch

diff --git a/include/linux/soc/qcom/smd-rpm.h b/include/linux/soc/qcom/smd-rpm.h
index 2990f425fdef..99499e4b080e 100644
--- a/include/linux/soc/qcom/smd-rpm.h
+++ b/include/linux/soc/qcom/smd-rpm.h
@@ -4,8 +4,9 @@ 
 
 struct qcom_smd_rpm;
 
-#define QCOM_SMD_RPM_ACTIVE_STATE        0
-#define QCOM_SMD_RPM_SLEEP_STATE         1
+#define QCOM_SMD_RPM_ACTIVE_STATE	0
+#define QCOM_SMD_RPM_SLEEP_STATE	1
+#define QCOM_SMD_RPM_STATE_NUM		2
 
 /*
  * Constants used for addressing resources in the RPM.