From patchwork Thu May 25 18:01:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 99172 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp565994vqr; Thu, 25 May 2023 11:17:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4zimv5CU0GSD7cxGld+aRm2/y/YpWxiDOZpPmK89Lefeowt3jLGntoyolZZ/k0wWbKOOYI X-Received: by 2002:a05:6a20:4321:b0:10c:4ff5:38b7 with SMTP id h33-20020a056a20432100b0010c4ff538b7mr12976880pzk.6.1685038657314; Thu, 25 May 2023 11:17:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685038657; cv=none; d=google.com; s=arc-20160816; b=xE+VVshwrb6TpIIU+4SFEVMFynL2ZPMfskFzR9g0up9btTw9Z7k1HRmr1fUanTsWfl L47dI1KRNDpnDtjreiQ6H0Zdh/kvFYrnp+DRTBqtPjtWO+iT3arRsgTtSZd3tdh7alJ6 pBiHNj1JhV7Cn20frS6VwdRCpc5Of4SnQt3Yx6SuEzw8cxo1fy7DD16fUQGm1KVUjPgN DJBTawmtdMGwnHaxyS3jyaEoVjXyJqXpfLulZ1tgLpHG5C/6c2UkrhGOXgcu3u5soTQl 5DwFhTrDYIBo12ToeyevgHGOAnLi/QX6yvkqx7/2ouJYgX9pW/v7rnRADRB3mCiwqQP9 PL7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AnaEspv7yPHxWFYxao23k8O8tDzjRIv0xbGT3Sv6WLQ=; b=afy3gbYAbIWyOTe3AgaEof9oRxG3A5KrgX59Y4XnRXMpDgxN1ybV/cOiu/XmTzxgh1 qwmIZneoJICpNE1nQOF4YwT6ZWeadhS6wQhtxwEN1gXkUpOqP6jOYu2pssieDUuQtmjl 1xsJ5pYysuGYGM/5xxGjrwpZJM/k0BPSTt6aMAK2hneUjpL2j6E3XYl84J+SVMicZJwn xzJou96gdYM6T36j0wDdpzreDYLFTqdVn+PkWVlsOlqPY7MTk/wZnEfFIL2sLAnzb6Ut TLMdMVxPD3zRUF/IZ3yPd+SKMZ9nK6A8YrK0aWVWJutTIr1DHlCu4mpLp0RerxBvMyI8 LguA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b004fb8abdd188si1677062pgq.115.2023.05.25.11.17.22; Thu, 25 May 2023 11:17:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241134AbjEYSDi (ORCPT + 99 others); Thu, 25 May 2023 14:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbjEYSDQ (ORCPT ); Thu, 25 May 2023 14:03:16 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 695A9D3 for ; Thu, 25 May 2023 11:03:00 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5730D15BF; Thu, 25 May 2023 11:03:45 -0700 (PDT) Received: from merodach.members.linode.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8E43A3F6C4; Thu, 25 May 2023 11:02:57 -0700 (PDT) From: James Morse To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , James Morse , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com Subject: [PATCH v4 10/24] tick/nohz: Move tick_nohz_full_mask declaration outside the #ifdef Date: Thu, 25 May 2023 18:01:55 +0000 Message-Id: <20230525180209.19497-11-james.morse@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230525180209.19497-1-james.morse@arm.com> References: <20230525180209.19497-1-james.morse@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766891095011815214?= X-GMAIL-MSGID: =?utf-8?q?1766891095011815214?= tick_nohz_full_mask lists the CPUs that are nohz_full. This is only needed when CONFIG_NO_HZ_FULL is defined. tick_nohz_full_cpu() allows a specific CPU to be tested against the mask, and evaluates to false when CONFIG_NO_HZ_FULL is not defined. The resctrl code needs to pick a CPU to run some work on, a new helper prefers housekeeping CPUs by examining the tick_nohz_full_mask. Hiding the declaration behind #ifdef CONFIG_NO_HZ_FULL forces all the users to be behind an ifdef too. Move the tick_nohz_full_mask declaration, this lets callers drop the ifdef, and guard access to tick_nohz_full_mask with IS_ENABLED() or something like tick_nohz_full_cpu(). The definition does not need to be moved as any callers should be removed at compile time unless CONFIG_NO_HZ_FULL is defined. Signed-off-by: James Morse --- include/linux/tick.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/linux/tick.h b/include/linux/tick.h index 9459fef5b857..65af90ca409a 100644 --- a/include/linux/tick.h +++ b/include/linux/tick.h @@ -174,9 +174,16 @@ static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; } static inline void tick_nohz_idle_stop_tick_protected(void) { } #endif /* !CONFIG_NO_HZ_COMMON */ +/* + * Mask of CPUs that are nohz_full. + * + * Users should be guarded by CONFIG_NO_HZ_FULL or a tick_nohz_full_cpu() + * check. + */ +extern cpumask_var_t tick_nohz_full_mask; + #ifdef CONFIG_NO_HZ_FULL extern bool tick_nohz_full_running; -extern cpumask_var_t tick_nohz_full_mask; static inline bool tick_nohz_full_enabled(void) {