From patchwork Thu May 25 17:21:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagadeesh Kona X-Patchwork-Id: 99128 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp537319vqr; Thu, 25 May 2023 10:29:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4rLy5AEHMyCOlHe51HLjBckg+3engppL0qyqHxpTrv8KjZHwtnYi1Fx0Qx0BpktV3nYXhI X-Received: by 2002:a05:6a20:3c88:b0:10b:764b:a942 with SMTP id b8-20020a056a203c8800b0010b764ba942mr4119927pzj.11.1685035755023; Thu, 25 May 2023 10:29:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685035755; cv=none; d=google.com; s=arc-20160816; b=LCZTdfvsyFvW8rZ9fToByh1XHyalI9o2/cfYWt+m8u5JXF3DHhW47UcP7FYoWkS4hI zifiYh57evt6UVV1dLNuscq/zA+F/0tEhCfklUaK8iwE9LZB/WxNUb45L2M1f3DELXAE FZHOQKs00SM9p7FNdlHtWxIH9CnZAkqLiVfAFhCqFOOKUqUQ1cNs1A1w541PCIZ9GBRP vfh7eLmuizhBLVcE8ew2/OJb1oFeMhUtV7Zjqv9dZkABj3PT0IbhjATLQ1hG9ws1EKlc ZLyUk5pp7RN/YOwOpix0MkJYAK4Vy2dRiIMIZImv9dqF4bgl9eIUCUVl0OXELPPJEZl1 khRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=om99O895n9nkElG25jRtJLH/nTYqblB+s+qVJkGdeM8=; b=CW4LWvInDPznX40Jo3DgmImjPXDVW1K6cgKsTLz+MaGcOk2+wAe/XyvAlAwuYNr+l/ j/NDpvUzvej8zgvHyjzsBXto+uPZ2ejm/DtqA9a+lv4sk6HaQ/tIJuqySyLEUiOnzs8C 4fAPxWRKP6c3qKJwdmGc1Wm3QH3nciTxeRgyE5yCdLslCqUOv0RjkCq60BIn3HhTRZEA l3Jp8bRnMfABVOGdwxUmrXngULWHrnuBUxMEhuC2XQPDgcALOWp0hxhI9MPlm+lBfkwj GuGbADaU2zz56KWPIDfDRbW8/r9AZSwKELlSczdyY+pmILow42ramAKRFKUrNNF/KVzM uVrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=DhV6VYeE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b19-20020a639313000000b0053487937119si1548591pge.351.2023.05.25.10.29.01; Thu, 25 May 2023 10:29:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=DhV6VYeE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241048AbjEYRWk (ORCPT + 99 others); Thu, 25 May 2023 13:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241012AbjEYRWg (ORCPT ); Thu, 25 May 2023 13:22:36 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 295E41A4; Thu, 25 May 2023 10:22:34 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34PFAJmj023148; Thu, 25 May 2023 17:22:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=om99O895n9nkElG25jRtJLH/nTYqblB+s+qVJkGdeM8=; b=DhV6VYeE5+seqnAJY8NO2rZZ71jQM7wXJUG6ily9uJkXndz9825zwIrXJC7IDEHH5wFD NoHRzmvQh44MZGkloI1uUZVoy0aFVIfStaiRn5mR243NKzAPLkLOhzb2yEpuYP3Wytfw hQKlOzItAjeGLVCMNdYj/w1ZC+QJbZby3Io1WSohUzpLs3H6bfc5T7ahesEqY1AlycER 9kZqxXtR4L8LtDI2qWO0li6z2g7Pymq7g4BjjwxKsr9G7hGVb3I+MO/rB9cjnSKWFHv3 YcC/d/Hh73xsJOR66wyB3Zxe467khxAeEiARaapZYPHaxbw64He4LdoNaueJdw2GwdIk oA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qt02a9p7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 May 2023 17:22:29 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34PHM8Ck021031 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 May 2023 17:22:28 GMT Received: from hu-jkona-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 25 May 2023 10:22:15 -0700 From: Jagadeesh Kona To: Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: Bjorn Andersson , Konrad Dybcio , Vladimir Zapolskiy , Vinod Koul , , , , , Taniya Das , Jagadeesh Kona , "Satya Priya Kakitapalli" , Imran Shaik , Ajit Pandey Subject: [PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L configuration for EVO PLL Date: Thu, 25 May 2023 22:51:39 +0530 Message-ID: <20230525172142.9039-4-quic_jkona@quicinc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230525172142.9039-1-quic_jkona@quicinc.com> References: <20230525172142.9039-1-quic_jkona@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: aQPGxJ7asudKG2sMfT-tNz45TBqFX26S X-Proofpoint-ORIG-GUID: aQPGxJ7asudKG2sMfT-tNz45TBqFX26S X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-25_09,2023-05-25_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 clxscore=1015 mlxscore=0 phishscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305250144 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766888051673399979?= X-GMAIL-MSGID: =?utf-8?q?1766888051673399979?= In lucid evo pll, the CAL_L field is part of L value register itself, and the l value configuration passed from clock controller driver includes CAL_L and L values as well. Hence remove explicit configuration of CAL_L for evo pll. Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL configuration interfaces") Signed-off-by: Taniya Das Signed-off-by: Jagadeesh Kona --- Changes since V1: - Newly added. drivers/clk/qcom/clk-alpha-pll.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c index f81c7c561352..68a80395997b 100644 --- a/drivers/clk/qcom/clk-alpha-pll.c +++ b/drivers/clk/qcom/clk-alpha-pll.c @@ -270,7 +270,6 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_regs); #define LUCID_EVO_PCAL_NOT_DONE BIT(8) #define LUCID_EVO_ENABLE_VOTE_RUN BIT(25) #define LUCID_EVO_PLL_L_VAL_MASK GENMASK(15, 0) -#define LUCID_EVO_PLL_CAL_L_VAL_SHIFT 16 /* ZONDA PLL specific */ #define ZONDA_PLL_OUT_MASK 0xf @@ -2084,10 +2083,7 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_zonda_ops); void clk_lucid_evo_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap, const struct alpha_pll_config *config) { - u32 lval = config->l; - - lval |= TRION_PLL_CAL_VAL << LUCID_EVO_PLL_CAL_L_VAL_SHIFT; - clk_alpha_pll_write_config(regmap, PLL_L_VAL(pll), lval); + clk_alpha_pll_write_config(regmap, PLL_L_VAL(pll), config->l); clk_alpha_pll_write_config(regmap, PLL_ALPHA_VAL(pll), config->alpha); clk_alpha_pll_write_config(regmap, PLL_CONFIG_CTL(pll), config->config_ctl_val); clk_alpha_pll_write_config(regmap, PLL_CONFIG_CTL_U(pll), config->config_ctl_hi_val);