Message ID | 20230525150659.25409-9-rf@opensource.cirrus.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp454575vqr; Thu, 25 May 2023 08:24:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6g3YoDCbgwO4zS07y+RhupoDp9jjqS3u4WROR/6Wvd8jwM7orhHpRtQeVXwR0HXnS9hxIu X-Received: by 2002:a05:6a00:b50:b0:64f:35c8:8584 with SMTP id p16-20020a056a000b5000b0064f35c88584mr9434195pfo.18.1685028296486; Thu, 25 May 2023 08:24:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685028296; cv=none; d=google.com; s=arc-20160816; b=jvcnA9KmM8HDI6Wt7Z0PISbng0yhMQZz+3/vVTuAebdPACXK1o4E6Njd6fQ3UzEMNM JLiUTZe8qOg9u0pme8RzUWSlu0PRu5ye52ggUFb1DkeoRMG9TjNLFQm4J/tLUtMmeO4x yaUj8d0MPvpj3H4G93kmZnJvgi2+6zlSDThrMrq9FVvWOg7cIUtwNGi/Jgeetk7lZvX+ ObMijINxyZ4BNjSDfsD5FSMIpZ1ESXf5apJvOd1+UAycYViorqumjS0Q1VbHmYPEGGzl 7aI+4O5fRL+QRyqkw9NFH7954/WmyZF7HWBfXRh59A1U1dO8/V7qOeAPolrXwA2yyJqi Xwpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uKYzq/D3zt7bRv8BxAmrdUM7w25ZiebnATzlkyzSXQI=; b=ORi3XyqaxLg2GMaf6ADbXObAZ8R9f8QLSk9cE/SXYiISQ0cokCfu/Ls1keLjlm/kxy Il0FJP8xJFMf0ExsQHYDzXbvFLjfaV/vAJ5xRMQPp1qzmOEcwpVY3y/hJzJtAKzpwMM5 lmrid1zcis9bofirxtqxNd5LqefBTT9CdGyRU32HURf1wSJTSYbFsqV9unQDXCE0hB8I qBFheNlPOAZpb7U6tKynnz9N/BuLjEGghX6RDXaQDSNPjQgvRQcO9R1Uo1UR7YAOAfrR cHw8rcDfFG6wzg8eE9bIvQWkw1rgVE8kFt3N/lNSn+5721qFk3iw8tHgi/qMTCOJkENM LmXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=epxDMbK1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13-20020a637d0d000000b0053ef5472644si1267892pgc.482.2023.05.25.08.24.41; Thu, 25 May 2023 08:24:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=epxDMbK1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241521AbjEYPHk (ORCPT <rfc822;ahmedalshaiji.dev@gmail.com> + 99 others); Thu, 25 May 2023 11:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241426AbjEYPHb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 25 May 2023 11:07:31 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 470CE199 for <linux-kernel@vger.kernel.org>; Thu, 25 May 2023 08:07:30 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34PEE1BJ025344; Thu, 25 May 2023 10:07:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=uKYzq/D3zt7bRv8BxAmrdUM7w25ZiebnATzlkyzSXQI=; b=epxDMbK16aFoxr2pHRoDeq2N796Dm7yYuUpj1C6WzPDg1JgZZPd0pyhMsxDThif75/SN JtrDq0gsgmMnwig4BDc6wioDTvvteo4oYhgSGuQ/oO8IOGMnTTP06mVzIP29ogTVj5oa 7TCbhbdxfw/jroMb5nAAwAfAd8aKFZ+nZihUrNva4jO7J4Za/GG/0WOtD6B62FE2aoLy LjHSO80vbzTeg4ITU7w4RUISazuiX08zvjndZ6Nu0Ot/Sbcxnc8okbHFKIQevBo53jj1 SqU2GkbHdxjcGNyK6wLzUuCxJQazv/mZUXsmASDgVjTg3no/x6GLEy6t3PX+SstYE94T RA== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3qptmm70m7-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 May 2023 10:07:07 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 25 May 2023 10:07:04 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 25 May 2023 10:07:04 -0500 Received: from EDIN4L06LR3.ad.cirrus.com (EDIN4L06LR3.ad.cirrus.com [198.61.65.166]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 5104111D4; Thu, 25 May 2023 15:07:04 +0000 (UTC) From: Richard Fitzgerald <rf@opensource.cirrus.com> To: <tiwai@suse.com>, <broonie@kernel.org>, <perex@perex.cz> CC: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>, Richard Fitzgerald <rf@opensource.cirrus.com> Subject: [PATCH 08/13] ASoC: cs35l56: Pass correct pointer to cs35l56_irq() Date: Thu, 25 May 2023 16:06:54 +0100 Message-ID: <20230525150659.25409-9-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230525150659.25409-1-rf@opensource.cirrus.com> References: <20230525150659.25409-1-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: 5gdkB_Q5s2h0VWW4y0BMmtD463Dq6uyk X-Proofpoint-GUID: 5gdkB_Q5s2h0VWW4y0BMmtD463Dq6uyk X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766880230821752123?= X-GMAIL-MSGID: =?utf-8?q?1766880230821752123?= |
Series |
ALSA: hda: Adding support for CS35L56 on HDA systems
|
|
Commit Message
Richard Fitzgerald
May 25, 2023, 3:06 p.m. UTC
cs35l56_irq() was changed to take a cs35l56_base* but the code
in cs35l56-sdw was still passing it a cs35l56_private*.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/soc/codecs/cs35l56-sdw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, May 25, 2023 at 04:06:54PM +0100, Richard Fitzgerald wrote: > cs35l56_irq() was changed to take a cs35l56_base* but the code > in cs35l56-sdw was still passing it a cs35l56_private*. For bisection this should be squashed into the change it's fixing.
On 25/5/23 16:14, Mark Brown wrote: > On Thu, May 25, 2023 at 04:06:54PM +0100, Richard Fitzgerald wrote: >> cs35l56_irq() was changed to take a cs35l56_base* but the code >> in cs35l56-sdw was still passing it a cs35l56_private*. > > For bisection this should be squashed into the change it's fixing. Oh damn. I knew I had to do that and forgot.
diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c index 09d255cc7652..b433266b7844 100644 --- a/sound/soc/codecs/cs35l56-sdw.c +++ b/sound/soc/codecs/cs35l56-sdw.c @@ -230,7 +230,7 @@ static void cs35l56_sdw_irq_work(struct work_struct *work) struct cs35l56_private, sdw_irq_work); - cs35l56_irq(-1, cs35l56); + cs35l56_irq(-1, &cs35l56->base); /* unmask interrupts */ if (!cs35l56->sdw_irq_no_unmask)