From patchwork Wed May 24 15:32:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 98575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp2918286rwl; Wed, 24 May 2023 08:48:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7sTa5HpSsb/TuZw1Fr6S3fSm4yL5EtDVyvIdKC67np8+6u89Tc6uzK1eoop0qOcaYfF2vs X-Received: by 2002:a05:6a21:918c:b0:106:3b67:b5db with SMTP id tp12-20020a056a21918c00b001063b67b5dbmr16467937pzb.18.1684943323422; Wed, 24 May 2023 08:48:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684943323; cv=none; d=google.com; s=arc-20160816; b=V8QsHI7vJ+GkSlnrF7/H93C9qTFkTVpEKhdaQx6c+AiZhalVJ30xtn83NPzSDuTmjD omso2SRuhbMqbEtRlpmrLrfa4BsX/m1sC+pgATwFboX0lwI4k6IZH3gjYTEJQOu/4EPX JUFzXG8sn0OEpUuNnF69gZwYWNfPQWu0JpWcPoY6Oi+n1uTx7dFzwzUixXeRE7qGlJjl DaM8YfBbg1BjY0ScbgR+Fd8dnII3PiTi2kkhBaBTJNmYT6ebuyDiY0TLs0iOjol8YD+8 6EZzSpyJbqWJWZYW/sb6UHoyZFUDPlqKJVntNrC+KD3+B+3IudOB0gG9oJav3/uTVt3S 1SlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t64UzVHVroabp76Xd4g1LLeTmZtqX+n8nvVYbfjxh90=; b=ZHqQs7d3MuNOgQdhY77scseHjAtG7P0C9ivBvzkTLuNnO/Cps2+s1FGuIzkzpKXDJZ ftiiIUXhei0TgpUUQSX6p6MtCOavZKa8gB5dPT7WLcvLiAS2jXIArX4v7fFweOCsCs5t qka44oPVhr6jqVOnawGvBOiQN2AuyM+gT8uZG8hjWI1YI7DcZQuza8jKOlhaRpPpDPzD 4AvOLXQR0pJoJbphFB4MrzNRL2gXyDnA6+LwhURmXzZkGPoSoZ5h1txtOtlbfvax0TzP FnlNabWMNTzopecLR0j8h+cOXpTxmKHIlLl19Mz0E/iqvjb2p85436s2QZ3ej6xktEDh cKkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=fkkfqnJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c21-20020a637255000000b0053f144dc315si1045024pgn.427.2023.05.24.08.48.31; Wed, 24 May 2023 08:48:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=fkkfqnJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236100AbjEXPdH (ORCPT + 99 others); Wed, 24 May 2023 11:33:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235917AbjEXPc5 (ORCPT ); Wed, 24 May 2023 11:32:57 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD09E13E for ; Wed, 24 May 2023 08:32:55 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-75b17aa343dso87256785a.3 for ; Wed, 24 May 2023 08:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684942374; x=1687534374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t64UzVHVroabp76Xd4g1LLeTmZtqX+n8nvVYbfjxh90=; b=fkkfqnJ52t84oMcKxKF0Qg5EIe+H/e5iNykQYFnHWz3Bf1EAvgahlIVxTsm8Z0hi4V OFp1GA5hnGMxdsdMdpwgJqewYy3Q6MuKpYhOgU1MBi6rBu/XAAnTNc41obMlD1z1fxX9 KRxzh5JbqUbMmqvEK2VKJEfhsUNZsUg4KU2WI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684942374; x=1687534374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t64UzVHVroabp76Xd4g1LLeTmZtqX+n8nvVYbfjxh90=; b=TZLVHPfITjo3iXm/Nx3XXeiswUEKSgG3mbuJmeqO0KxnI4kniNjzJO+8HWieqRJJpj VfkdTB/iCBTGFmHoyVbAVGuUuSMMo+YkiwrzZ5IViPpgT7vEDk+pAelVbtaojuCzc+Oh U93WxFHiyl5uQ9+J8HjRrDCinITmZ78fOo0FwXElrndajG+Y24zchyf/YDp3dHzFbQSr VLgeowBKUL5dbksHDAD1S6XWYkE2lcJHmKsZOQ4eAT/sZtel46wXDIcVtpNJaa2Vkagr iTO2LPFrCUEeypYTPkfeL0KdsTgYLNC4pSeU0xNO8tgdZr6SkdNUt2jTQ10dcNrtrcHf K2jQ== X-Gm-Message-State: AC+VfDz45YmzvFQwxXkGHLukDC/7G80k1fWx9KX9qqz8IObULvzJY+05 3xEZfnd/cp86/YM1P4ab9FAGUgq0IDCEch+N42o= X-Received: by 2002:a05:620a:3d14:b0:75b:23a1:8306 with SMTP id tq20-20020a05620a3d1400b0075b23a18306mr7101918qkn.1.1684942374473; Wed, 24 May 2023 08:32:54 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v18-20020a05620a123200b007590aa4b115sm3296906qkj.87.2023.05.24.08.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 08:32:53 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: [PATCH v3 3/6] selftests: mm: Fix failure case when new remap region was not found Date: Wed, 24 May 2023 15:32:36 +0000 Message-ID: <20230524153239.3036507-4-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog In-Reply-To: <20230524153239.3036507-1-joel@joelfernandes.org> References: <20230524153239.3036507-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766791130138854553?= X-GMAIL-MSGID: =?utf-8?q?1766791130138854553?= When a valid remap region could not be found, the source mapping is not cleaned up. Fix the goto statement such that the clean up happens. Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..6822d657f589 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (addr + c.dest_alignment < addr) { ksft_print_msg("Couldn't find a valid region to remap to\n"); ret = -1; - goto out; + goto clean_up_src; } addr += c.dest_alignment; }