[v2,2/4] dt-bindings: power: reset: atmel,at91sam9260-shdwc: convert to yaml
Commit Message
Convert Atmel shutdown controller to YAML.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
.../devicetree/bindings/arm/atmel-sysregs.txt | 31 -------
.../power/reset/atmel,at91sam9260-shdwc.yaml | 82 +++++++++++++++++++
2 files changed, 82 insertions(+), 31 deletions(-)
create mode 100644 Documentation/devicetree/bindings/power/reset/atmel,at91sam9260-shdwc.yaml
Comments
On Wed, May 24, 2023 at 03:35:26PM +0300, Claudiu Beznea wrote:
> Convert Atmel shutdown controller to YAML.
>
Same here. Modulo thinking Rob should Ack it because I think this will
re-license the txt binding,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
On 24/05/2023 14:35, Claudiu Beznea wrote:
> Convert Atmel shutdown controller to YAML.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - atmel,at91sam9260-shdwc
> + - atmel,at91sam9rl-shdwc
> + then:
> + properties:
> + atmel,wakeup-rtt-timer:
> + description: enable real-time timer wake-up
> + type: boolean
No, don't define properties in allOf.
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - atmel,at91sam9rl-shdwc
> + - atmel,at91sam9x5-shdwc
> + then:
> + properties:
> + atmel,wakeup-rtc-timer:
> + description: enable real-time clock wake-up
> + type: boolean
Same problem.
> +
> +unevaluatedProperties: false
This should be additionalProperties: false.
> +
> +examples:
> + - |
> + shdwc: poweroff@fffffd10 {
> + compatible = "atmel,at91sam9260-shdwc";
> + reg = <0xfffffd10 0x10>;
> + clocks = <&clk32k>;
> + };
> +
> +...
Best regards,
Krzysztof
@@ -52,37 +52,6 @@ Example:
reg = <0xe3804000 0x1000>;
};
-SHDWC Shutdown Controller
-
-required properties:
-- compatible: Should be "atmel,<chip>-shdwc".
- <chip> can be "at91sam9260", "at91sam9rl" or "at91sam9x5".
-- reg: Should contain registers location and length
-- clocks: phandle to input clock.
-
-optional properties:
-- atmel,wakeup-mode: String, operation mode of the wakeup mode.
- Supported values are: "none", "high", "low", "any".
-- atmel,wakeup-counter: Counter on Wake-up 0 (between 0x0 and 0xf).
-
-optional at91sam9260 properties:
-- atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.
-
-optional at91sam9rl properties:
-- atmel,wakeup-rtc-timer: boolean to enable Real-time Clock Wake-up.
-- atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.
-
-optional at91sam9x5 properties:
-- atmel,wakeup-rtc-timer: boolean to enable Real-time Clock Wake-up.
-
-Example:
-
- shdwc@fffffd10 {
- compatible = "atmel,at91sam9260-shdwc";
- reg = <0xfffffd10 0x10>;
- clocks = <&clk32k>;
- };
-
SHDWC SAMA5D2-Compatible Shutdown Controller
1) shdwc node
new file mode 100644
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/reset/atmel,at91sam9260-shdwc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel SHDWC Shutdown Controller
+
+maintainers:
+ - Claudiu Beznea <claudiu.beznea@microchip.com>
+
+description:
+ Atmel SHDWC shutdown controller controls the power supplies VDDIO and VDDCORE
+ and the wake-up detection on debounced input lines.
+
+properties:
+ compatible:
+ enum:
+ - atmel,at91sam9260-shdwc
+ - atmel,at91sam9rl-shdwc
+ - atmel,at91sam9x5-shdwc
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ atmel,wakeup-mode:
+ description: operation mode of the wakeup mode
+ $ref: /schemas/types.yaml#/definitions/string
+ enum: [ none, high, low, any ]
+
+ atmel,wakeup-counter:
+ description: counter on wake-up 0
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 15
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - atmel,at91sam9260-shdwc
+ - atmel,at91sam9rl-shdwc
+ then:
+ properties:
+ atmel,wakeup-rtt-timer:
+ description: enable real-time timer wake-up
+ type: boolean
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - atmel,at91sam9rl-shdwc
+ - atmel,at91sam9x5-shdwc
+ then:
+ properties:
+ atmel,wakeup-rtc-timer:
+ description: enable real-time clock wake-up
+ type: boolean
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ shdwc: poweroff@fffffd10 {
+ compatible = "atmel,at91sam9260-shdwc";
+ reg = <0xfffffd10 0x10>;
+ clocks = <&clk32k>;
+ };
+
+...