From patchwork Wed May 24 07:06:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna-Maria Behnsen X-Patchwork-Id: 98344 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2653659vqo; Wed, 24 May 2023 00:16:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Ik6AQJhYkTIrIIFAzkNc+skNSLMsD1TVXU6WdRMY6TGDslUD9o8sabt4kWOVCYJPTw6OE X-Received: by 2002:a05:6a21:6811:b0:e9:5b0a:deff with SMTP id wr17-20020a056a21681100b000e95b0adeffmr15169790pzb.22.1684912595873; Wed, 24 May 2023 00:16:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684912595; cv=none; d=google.com; s=arc-20160816; b=pinWLgrh1ZYIxb/AcK/+k5NISjBviSwjEeqG18Uhw9RXTZPtky2erkdFTg0NoFGd7d fqEAfGHrTH0jMnmnM5mOz9JUorc+TmQ3fwGbk7+xxoE3DPIUcwEIlL/1fE9mojGlrxr/ 0JoYlD5Vx88zxsMmKpsP7NKU+/ejgUEpdm2EfMHLspXDjtXvrKtvdrr15cw7F/Rjt9x7 9+bnU+waP+1ZKlKVeEIgS9ZYDvHJlTlIAUd8ZMbz3KNnBCKNhVv1JQ3NptR5lX2VEXg2 WElpm33zbsM3OzsKeQBr+BC/nqPtrmwjjMXTMAAiBLN5AYB/NcWtr/D1rEBdWIPaOxdJ jBIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=GmrO3nNzYfXwzb1RvZTjX+af+BCpvVn7WiRHJl4Z/10=; b=w0ROPh0/iEJPSwUfaJKiyvgmDHjBudTrFPMNNRNz+2VOjmcei0+TEpDyt12JQBGDGt vJuXnQ+ivTtSUeugiHc6OVDruZveCwUaWpuyuClbD+JcVkT6ynpxYFkGqSjbJLSiSA6e QrynlzoH3ZtETokHjTIsA6lP2TDwUZJzIEbPqP8j7WzNI72vODp0fVEpviI+5jQob7bk dL6XhpLU2V5qycEtOKi8FkDljVna5DUJNWTQUf/x50NO4tNnJZpfxe7ZOG4747hMqvus cKGw6AgbZlqZrBllsszfrfHMPK4m2poW1nW/kVTpLxbGhd6rnKCnUehfW3MrGJtsEfa4 OKpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oQFmzl0h; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h4-20020aa79f44000000b006281ec442absi61846pfr.309.2023.05.24.00.16.17; Wed, 24 May 2023 00:16:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oQFmzl0h; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239847AbjEXHHI (ORCPT + 99 others); Wed, 24 May 2023 03:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239746AbjEXHG6 (ORCPT ); Wed, 24 May 2023 03:06:58 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B660199 for ; Wed, 24 May 2023 00:06:57 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684912016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmrO3nNzYfXwzb1RvZTjX+af+BCpvVn7WiRHJl4Z/10=; b=oQFmzl0hCgOVqO0CCwNu0rsAtbzxlfYbvPv/MREvfhtRZB1g8L68j32VDfZF3deIIpftGL Oj81rEJyxdz8wXJInIWretBl0CLUWAM9+DbMLieeu5mG9u2s4tzmBwkAExbqO89g67hOtc 0vjdETFq5rwod2wu988mY/G0AYBFksm+ChoWX6iLHGAji7CAqKhkwO02viZHdOMcAjrbFH yFfy1qb6pwTwe9UcfXpyjneBoW/R+DQ5AG0FDfWUGXTWqWVgv9NKmfJh0cAgdmeQGLUR6Z 8YXP6N0BjHDtjX8uWNKD1hLF5hwsCO8ukNhNnwlfWjklUzNF+8b9vZ2Uuupg8w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684912016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmrO3nNzYfXwzb1RvZTjX+af+BCpvVn7WiRHJl4Z/10=; b=OXnNcBY2JcZtsufQ7vxjReORO+MhFEQ2p/jHSbw/U1CzMcGn0NihckMjNahMgxFwWYKZQt gc8tTdaxcQGKCgDQ== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Anna-Maria Behnsen Subject: [PATCH v7 02/21] timer: Do not IPI for deferrable timers Date: Wed, 24 May 2023 09:06:10 +0200 Message-Id: <20230524070629.6377-3-anna-maria@linutronix.de> In-Reply-To: <20230524070629.6377-1-anna-maria@linutronix.de> References: <20230524070629.6377-1-anna-maria@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766758909767029837?= X-GMAIL-MSGID: =?utf-8?q?1766758909767029837?= Deferrable timers do not prevent CPU from going idle and are not taken into account on idle path. Sending an IPI to a remote CPU when a new first deferrable timer was enqueued will wake up the remote CPU and but nothing will be done regarding the deferrable timers. Drop IPI completely when a new first deferrable timer was enqueued. Signed-off-by: Anna-Maria Behnsen Reviewed-by: Frederic Weisbecker --- v6: new patch --- kernel/time/timer.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 63a8ce7177dd..6e251e3cf659 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -571,18 +571,15 @@ static int calc_wheel_index(unsigned long expires, unsigned long clk, static void trigger_dyntick_cpu(struct timer_base *base, struct timer_list *timer) { - if (!is_timers_nohz_active()) - return; - /* - * TODO: This wants some optimizing similar to the code below, but we - * will do that when we switch from push to pull for deferrable timers. + * Deferrable timers do not prevent CPU from going idle and are not + * taken into account on idle path. An IPI when a new deferrable + * timer is enqueued will wake up the remote CPU but nothing will + * be done with the deferrable timer base. Therefore skip remote + * IPI for deferrable timers completely. */ - if (timer->flags & TIMER_DEFERRABLE) { - if (tick_nohz_full_cpu(base->cpu)) - wake_up_nohz_cpu(base->cpu); + if (!is_timers_nohz_active() || timer->flags & TIMER_DEFERRABLE) return; - } /* * We might have to IPI the remote CPU if the base is idle and the