From patchwork Tue May 23 13:53:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Rokosov X-Patchwork-Id: 97997 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2160236vqo; Tue, 23 May 2023 06:55:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ZJxM3xejgWZA8AToWyyi28io8ZzNHwcJn+w60AziWgewrRFuhuIdunowocRXKHkP0QAXi X-Received: by 2002:a17:90a:71c2:b0:255:70e1:e41 with SMTP id m2-20020a17090a71c200b0025570e10e41mr6028139pjs.19.1684850152506; Tue, 23 May 2023 06:55:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684850152; cv=none; d=google.com; s=arc-20160816; b=Znb2FSiQYnp/iZ524SNI+Tlr15UrcC5yVVR6GrpHgmwx8wdIbeXFBn2SB1cai55Q92 FfMKJA8xlBhP/BjdElLOKo/He0Uqn5OkB/7mKhF2CpFIzogYO0GxnIGoVebUO9oEjWyD HCGO9xiVpkxEkFFZ3EWTnQX2HXpncc+5Yj46+0x2GDEAuTba475ys1X9w0WCQrS1vlv7 A/cxnVJp59849ZFA27e71C1hGGmXOYZyKpBptOISaiO9Z0bwohlNKUorR0aegKOcZhHK Wtu0zOMf+jNgciBCjruhgZO8OIW9T0Lo3Qd2ceBF+DQXirsKgPPSrDBARx/4O/EiymXP kLsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QACcL2z5H0WiVPZBqWtG1qVoEZA/+FwC6rxiZKbXGhQ=; b=SI0tdsOmNU6JK7CHhMT9pzLAQ2E590G3JPs+vnlbJWSW4BDJZM7o3YLlyRCK0Lac2j d6ir9AE6kps6Hb4htspbnZmblc7VLwXSBD2CNmqIVWQ7L0C+sCfVFHL0a7h+c9ecdp+L hOIPX/epYPRlInhs+I7K34+7DPa3fX33CTFnlJH2nze6O6408bioD/uQW65F+5SO0uI9 DMWmZeya/qWPm40wpEeuZ31JCvVz8VEQ7yF8ePuvKDNaFv0qOPsVVrj5uHKF0eTGBCwb 9WaI789XDE//jPny48NR3s1PgA4AAp9G5FI/PBHwQahEsbbhvX75dIjmNolyl3jtTEru Ngew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=d7cjZgy6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2-20020a636b02000000b005303b739292si3082787pgc.702.2023.05.23.06.55.37; Tue, 23 May 2023 06:55:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=d7cjZgy6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237023AbjEWNyN (ORCPT + 99 others); Tue, 23 May 2023 09:54:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237009AbjEWNyH (ORCPT ); Tue, 23 May 2023 09:54:07 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC167109; Tue, 23 May 2023 06:54:04 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 2CD4F5FD68; Tue, 23 May 2023 16:54:03 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1684850043; bh=QACcL2z5H0WiVPZBqWtG1qVoEZA/+FwC6rxiZKbXGhQ=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=d7cjZgy6FmwELYdiPA/MahxZUvDN4IL/6S6Sq6CN7KFg1OqB1O7fjfOezdXdi/og9 dqr4k9yNlx1UAJSQgBx4F7+DjoxAgRQl0CTzYMrm6EuPFA+gAHXWHNylRoQ5ufjT3v vRxtb5+1KzzIXcbyGJkNLyYTNfX6dFkt1z9cxyVTdQrQ7ph0i/qX3I107yONEBFTy3 FYb/lU59ijivs/2T5Q9f9A0kDvgmRDwmyO0G3cCg9B9CynqCRdfadaaoRHEUBLL4+/ OhTaOkTNuJMZD+9gZpGPb2EIBKb4zwKsNVWpMYgSwjSkOMpS4v5BnNDLlMkihOSCmM a9OWH9aXhvRCA== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Tue, 23 May 2023 16:54:03 +0300 (MSK) From: Dmitry Rokosov To: , , , , , , , CC: , , , , , , , , Dmitry Rokosov Subject: [PATCH v16 2/6] clk: meson: introduce new pll power-on sequence for A1 SoC family Date: Tue, 23 May 2023 16:53:47 +0300 Message-ID: <20230523135351.19133-3-ddrokosov@sberdevices.ru> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20230523135351.19133-1-ddrokosov@sberdevices.ru> References: <20230523135351.19133-1-ddrokosov@sberdevices.ru> MIME-Version: 1.0 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/05/23 12:15:00 #21372692 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766693433701878431?= X-GMAIL-MSGID: =?utf-8?q?1766693433701878431?= Modern meson PLL IPs are a little bit different from early known PLLs. The main difference is located in the init/enable/disable sequences; the rate logic is the same. In A1 PLL, the PLL enable sequence is different, so add new optional pll reg bits and use the new power-on sequence to enable the PLL: 1. enable the pll, delay for 10us 2. enable the pll self-adaption current module, delay for 40us 3. enable the lock detect module Signed-off-by: Jian Hu Acked-by: Martin Blumenstingl Signed-off-by: Dmitry Rokosov --- drivers/clk/meson/clk-pll.c | 23 +++++++++++++++++++++++ drivers/clk/meson/clk-pll.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c index 314ca945a4d0..56ec2210f1ad 100644 --- a/drivers/clk/meson/clk-pll.c +++ b/drivers/clk/meson/clk-pll.c @@ -358,6 +358,25 @@ static int meson_clk_pll_enable(struct clk_hw *hw) if (MESON_PARM_APPLICABLE(&pll->rst)) meson_parm_write(clk->map, &pll->rst, 0); + /* + * Compared with the previous SoCs, self-adaption current module + * is newly added for A1, keep the new power-on sequence to enable the + * PLL. The sequence is: + * 1. enable the pll, delay for 10us + * 2. enable the pll self-adaption current module, delay for 40us + * 3. enable the lock detect module + */ + if (MESON_PARM_APPLICABLE(&pll->current_en)) { + usleep_range(10, 20); + meson_parm_write(clk->map, &pll->current_en, 1); + usleep_range(40, 50); + }; + + if (MESON_PARM_APPLICABLE(&pll->l_detect)) { + meson_parm_write(clk->map, &pll->l_detect, 1); + meson_parm_write(clk->map, &pll->l_detect, 0); + } + if (meson_clk_pll_wait_lock(hw)) return -EIO; @@ -375,6 +394,10 @@ static void meson_clk_pll_disable(struct clk_hw *hw) /* Disable the pll */ meson_parm_write(clk->map, &pll->en, 0); + + /* Disable PLL internal self-adaption current module */ + if (MESON_PARM_APPLICABLE(&pll->current_en)) + meson_parm_write(clk->map, &pll->current_en, 0); } static int meson_clk_pll_set_rate(struct clk_hw *hw, unsigned long rate, diff --git a/drivers/clk/meson/clk-pll.h b/drivers/clk/meson/clk-pll.h index 367efd0f6410..a2228c0fdce5 100644 --- a/drivers/clk/meson/clk-pll.h +++ b/drivers/clk/meson/clk-pll.h @@ -36,6 +36,8 @@ struct meson_clk_pll_data { struct parm frac; struct parm l; struct parm rst; + struct parm current_en; + struct parm l_detect; const struct reg_sequence *init_regs; unsigned int init_count; const struct pll_params_table *table;