From patchwork Tue May 23 12:16:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junxian Huang X-Patchwork-Id: 97976 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2112183vqo; Tue, 23 May 2023 05:47:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ztihSPgpPuMgwHtjTWg5meaSW1LiY/tvSYcy23V2kgPdoF9/LWye9epWGS+y1IF7Q8GUC X-Received: by 2002:a17:902:6b8c:b0:1af:bae0:6bed with SMTP id p12-20020a1709026b8c00b001afbae06bedmr3859167plk.56.1684846062827; Tue, 23 May 2023 05:47:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684846062; cv=none; d=google.com; s=arc-20160816; b=a2ZHz/stcntsG8s0CLjTtvJRbQhBlwsAW266/Es4/iqHWEjPayuinCUP3xcr/SeVYv a94lyLr7hemcyA5sHRKtevP0GfVJZ1Mtb8+7HNNUNY1A6dyEcwY5SvzUWvmeAVT41D2X Z5iZb2k3VySQa17yygsDxBGcDd0ufuY+W39Ij+69tvYhH5jt2Xy474Mud0nqiugIQ47t T88qtE0RAmpH7OiySIDIbzFdWMkPoymV9kBMS+7qP57szWetDC2OkQ++r4ROZPayOgX1 LRVDEyERm72YCiLe0CdzKCKS9+8AoC2m0k3XgFDtiGrg0c96HTmf4Xq06dTuDf9A4+1x m56Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KbRZOWBh0IAtr5DvHgdetG7JCpt//0iKT6PR0wBLodw=; b=pRIIZwWuh+Mnqs6KPrzGSXiWVAR+axHBVddFaftHk8arQGMgLiGd277od8C7L+lbCt OSAzBgdvTa+JjcddbmBG8d1TTn6OWJgHKpgOG+vCaL6XfFzNRzLqPUuXxX1oTdO/yEN6 ny+vC6Y304jcTtyYeYfmgMVc1tLtU6fFoXmycX6TYpHeeabBWtrRxkP24sEVEiQIsll1 fp/RZL1LqxAW0+u3yVRnjkC8e83l5wZDIuqyZsV7HkPJLK2+qSx9GQ3z3P6n64kHtsX1 r99th6nVuerG7cDCjZTZiF8A053Sv5jHcG+yKc8G72PeIXhGpXI+zjV4BlF37h2Op10Z nZDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=hisilicon.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ij25-20020a170902ab5900b001aaf59c9633si1458549plb.565.2023.05.23.05.47.22; Tue, 23 May 2023 05:47:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=hisilicon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236742AbjEWMSy (ORCPT + 99 others); Tue, 23 May 2023 08:18:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235983AbjEWMSv (ORCPT ); Tue, 23 May 2023 08:18:51 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FE9118; Tue, 23 May 2023 05:18:50 -0700 (PDT) Received: from kwepemi500006.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QQYGn1b5WzLmFy; Tue, 23 May 2023 20:17:21 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemi500006.china.huawei.com (7.221.188.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 20:18:48 +0800 From: Junxian Huang To: , CC: , , , Subject: [PATCH for-rc 1/3] RDMA/hns: Remove unnecessary QP type checks Date: Tue, 23 May 2023 20:16:39 +0800 Message-ID: <20230523121641.3132102-2-huangjunxian6@hisilicon.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230523121641.3132102-1-huangjunxian6@hisilicon.com> References: <20230523121641.3132102-1-huangjunxian6@hisilicon.com> MIME-Version: 1.0 X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500006.china.huawei.com (7.221.188.68) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766689145241466890?= X-GMAIL-MSGID: =?utf-8?q?1766689145241466890?= It is not necessary to check the type of the queue on IO path because unsupported QP type cannot be created. Signed-off-by: Chengchang Tang Signed-off-by: Junxian Huang --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index d4c6b9bc0a4e..673fd31b9ecf 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -373,17 +373,10 @@ static int check_send_valid(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp) { struct ib_device *ibdev = &hr_dev->ib_dev; - struct ib_qp *ibqp = &hr_qp->ibqp; - if (unlikely(ibqp->qp_type != IB_QPT_RC && - ibqp->qp_type != IB_QPT_GSI && - ibqp->qp_type != IB_QPT_UD)) { - ibdev_err(ibdev, "not supported QP(0x%x)type!\n", - ibqp->qp_type); - return -EOPNOTSUPP; - } else if (unlikely(hr_qp->state == IB_QPS_RESET || - hr_qp->state == IB_QPS_INIT || - hr_qp->state == IB_QPS_RTR)) { + if (unlikely(hr_qp->state == IB_QPS_RESET || + hr_qp->state == IB_QPS_INIT || + hr_qp->state == IB_QPS_RTR)) { ibdev_err(ibdev, "failed to post WQE, QP state %u!\n", hr_qp->state); return -EINVAL; @@ -772,15 +765,6 @@ static int check_recv_valid(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp) { struct ib_device *ibdev = &hr_dev->ib_dev; - struct ib_qp *ibqp = &hr_qp->ibqp; - - if (unlikely(ibqp->qp_type != IB_QPT_RC && - ibqp->qp_type != IB_QPT_GSI && - ibqp->qp_type != IB_QPT_UD)) { - ibdev_err(ibdev, "unsupported qp type, qp_type = %d.\n", - ibqp->qp_type); - return -EOPNOTSUPP; - } if (unlikely(hr_dev->state >= HNS_ROCE_DEVICE_STATE_RST_DOWN)) return -EIO;