diff mbox series

drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags

Message ID 20230523114937.1080767-1-trix@redhat.com
State New
Headers
Series drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags |

Commit Message

Tom Rix May 23, 2023, 11:49 a.m. UTC 
  gcc with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error:
  ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=]
 1069 | static const struct resource_create_funcs res_create_maximus_funcs = {
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:727:38: error:
  ‘debug_defaults_diags’ defined but not used [-Werror=unused-const-variable=]
  727 | static const struct dc_debug_options debug_defaults_diags = {
      |                                      ^~~~~~~~~~~~~~~~~~~~

These variables are not used so remove them.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 .../drm/amd/display/dc/dcn20/dcn20_resource.c | 23 -------------------
 1 file changed, 23 deletions(-)

Comments

Hamza Mahfooz May 23, 2023, 2:36 p.m. UTC | #1 
On 5/23/23 07:49, Tom Rix wrote:
> gcc with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error:
>    ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=]
>   1069 | static const struct resource_create_funcs res_create_maximus_funcs = {
>        |                                           ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:727:38: error:
>    ‘debug_defaults_diags’ defined but not used [-Werror=unused-const-variable=]
>    727 | static const struct dc_debug_options debug_defaults_diags = {
>        |                                      ^~~~~~~~~~~~~~~~~~~~
> 
> These variables are not used so remove them.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Fixes: 00df97e1df57 ("drm/amd/display: Clean FPGA code in dc")

Applied, thanks!

> ---
>   .../drm/amd/display/dc/dcn20/dcn20_resource.c | 23 -------------------
>   1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> index 7dcae3183e07..6ef7e2634991 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> @@ -724,22 +724,6 @@ static const struct dc_debug_options debug_defaults_drv = {
>   		.underflow_assert_delay_us = 0xFFFFFFFF,
>   };
>   
> -static const struct dc_debug_options debug_defaults_diags = {
> -		.disable_dmcu = false,
> -		.force_abm_enable = false,
> -		.timing_trace = true,
> -		.clock_trace = true,
> -		.disable_dpp_power_gate = true,
> -		.disable_hubp_power_gate = true,
> -		.disable_clock_gate = true,
> -		.disable_pplib_clock_request = true,
> -		.disable_pplib_wm_range = true,
> -		.disable_stutter = true,
> -		.scl_reset_length10 = true,
> -		.underflow_assert_delay_us = 0xFFFFFFFF,
> -		.enable_tri_buf = true,
> -};
> -
>   void dcn20_dpp_destroy(struct dpp **dpp)
>   {
>   	kfree(TO_DCN20_DPP(*dpp));
> @@ -1066,13 +1050,6 @@ static const struct resource_create_funcs res_create_funcs = {
>   	.create_hwseq = dcn20_hwseq_create,
>   };
>   
> -static const struct resource_create_funcs res_create_maximus_funcs = {
> -	.read_dce_straps = NULL,
> -	.create_audio = NULL,
> -	.create_stream_encoder = NULL,
> -	.create_hwseq = dcn20_hwseq_create,
> -};
> -
>   static void dcn20_pp_smu_destroy(struct pp_smu_funcs **pp_smu);
>   
>   void dcn20_clock_source_destroy(struct clock_source **clk_src)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
index 7dcae3183e07..6ef7e2634991 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
@@ -724,22 +724,6 @@  static const struct dc_debug_options debug_defaults_drv = {
 		.underflow_assert_delay_us = 0xFFFFFFFF,
 };
 
-static const struct dc_debug_options debug_defaults_diags = {
-		.disable_dmcu = false,
-		.force_abm_enable = false,
-		.timing_trace = true,
-		.clock_trace = true,
-		.disable_dpp_power_gate = true,
-		.disable_hubp_power_gate = true,
-		.disable_clock_gate = true,
-		.disable_pplib_clock_request = true,
-		.disable_pplib_wm_range = true,
-		.disable_stutter = true,
-		.scl_reset_length10 = true,
-		.underflow_assert_delay_us = 0xFFFFFFFF,
-		.enable_tri_buf = true,
-};
-
 void dcn20_dpp_destroy(struct dpp **dpp)
 {
 	kfree(TO_DCN20_DPP(*dpp));
@@ -1066,13 +1050,6 @@  static const struct resource_create_funcs res_create_funcs = {
 	.create_hwseq = dcn20_hwseq_create,
 };
 
-static const struct resource_create_funcs res_create_maximus_funcs = {
-	.read_dce_straps = NULL,
-	.create_audio = NULL,
-	.create_stream_encoder = NULL,
-	.create_hwseq = dcn20_hwseq_create,
-};
-
 static void dcn20_pp_smu_destroy(struct pp_smu_funcs **pp_smu);
 
 void dcn20_clock_source_destroy(struct clock_source **clk_src)